From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 987A8C6FA82 for ; Wed, 21 Sep 2022 04:45:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230441AbiIUEpQ (ORCPT ); Wed, 21 Sep 2022 00:45:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230116AbiIUEpN (ORCPT ); Wed, 21 Sep 2022 00:45:13 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FC4B476FE for ; Tue, 20 Sep 2022 21:45:11 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id y8so6830752edc.10 for ; Tue, 20 Sep 2022 21:45:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=qzk5oLYbYGm3BHnsgSBtDHRCJL48j9t8HeQTS7gm2wg=; b=JxUWNI8TIHdFgVW1ngZne2CkuOQxif+pa+WY88wq2PlopW0EDUDjqn5HpjeYYMv+i0 KViOt3GPgDmkyqt1Z/qhvKgj0X4/bRphKTWbn6kPseH6bvajEKRR7pcj9uFjlpwWBAqh 30uffDwipf38NBdVVSL6ejnuz1edkAxWTwUk7c4HnyUzPHmH82KXM046fdsnIIejakaa 1IUmrViZEXVLRgEc5tjo2skcoQDycenjeh7l4cZmyYa8KG8ccAlPiLR7BmWBofJ5cwYJ 3d3HwK9T9JFItsMEdseerz+vKXidMCitosRO75NmfH0r9/U+IlUQsJV7i+L9Rk01xnwy acXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=qzk5oLYbYGm3BHnsgSBtDHRCJL48j9t8HeQTS7gm2wg=; b=E2Q1MP6kFbrKeh7+Z8em4Xk15A4YlAWKyYpWOAe4wIcP7UYpzWOSpwyS30kPM5mGb1 8qXDxBN9qIFtj+D1VPRo2nRdm4/stqCmNcPW4enBRZpHbq/SBA9K2n8Jo62nSmKD3+iz 0LGW7FwUcC7Gm9qIai5JTE1cnxPUI1kefjujM71mum23cPoQI7sky82aQdRx9kVtw3XJ ZAbnTK7cknbXtpy+PAepCYc+vEdrl/JMWQ/JFsTyR+hELgcLj39U3vMzZGwsym8LlQ8V pslbUKjFURjWFgcqVShGYycgsRSzKT963CIJM6KaKs7/7mAmbFmJ2VGYyPhVRpRpenjx GP8w== X-Gm-Message-State: ACrzQf0dnJ5x1bEfsY2cNo//XppCcidXNB0ok5VSMzaQzsffM8YghrLQ ill5J05763/Oaobt5VPMCl0ybA== X-Google-Smtp-Source: AMsMyM7+gW+ygA22gbwvi4QbDO0COr82ooOiqv4A3s3dNUtpnD2pI6UQO3Pvu/4MBUZrJnY8xt4Fng== X-Received: by 2002:aa7:d718:0:b0:454:5899:9eb0 with SMTP id t24-20020aa7d718000000b0045458999eb0mr7685676edq.37.1663735509924; Tue, 20 Sep 2022 21:45:09 -0700 (PDT) Received: from [192.168.0.111] (87-243-81-1.ip.btc-net.bg. [87.243.81.1]) by smtp.gmail.com with ESMTPSA id kx15-20020a170907774f00b0073dc8d0eabesm806342ejc.15.2022.09.20.21.45.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 21:45:09 -0700 (PDT) Message-ID: <3f2d6682-7c5c-5a6d-110b-568331650949@blackwall.org> Date: Wed, 21 Sep 2022 07:45:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH RFC net-next 0/5] net: vlan: fix bridge binding behavior and add selftests Content-Language: en-US To: Jakub Kicinski Cc: Sevinj Aghayeva , netdev@vger.kernel.org, "David S. Miller" , aroulin@nvidia.com, sbrivio@redhat.com, roopa@nvidia.com, Eric Dumazet , Paolo Abeni , linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org References: <78bd0e54-4ee3-bd3c-2154-9eb8b9a70497@blackwall.org> <20220920162954.1f4aaf7b@kernel.org> From: Nikolay Aleksandrov In-Reply-To: <20220920162954.1f4aaf7b@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/09/2022 02:29, Jakub Kicinski wrote: > On Tue, 20 Sep 2022 12:16:26 +0300 Nikolay Aleksandrov wrote: >> The set looks good to me, the bridge and vlan direct dependency is gone and >> the new notification type is used for passing link type specific info. > > IDK, vlan knows it's calling the bridge: > > + if ((vlan->flags ^ old_flags) & VLAN_FLAG_BRIDGE_BINDING && > + netif_is_bridge_master(vlan->real_dev)) { > This one is more of an optimization so notifications are sent only when the bridge is involved, it can be removed if other interested parties show up. > bridge knows it's vlan calling: > > + if (is_vlan_dev(dev)) { > + br_vlan_device_event(dev, event, ptr); > > going thru the generic NETDEV notifier seems odd. > > If this is just to avoid the dependency we can perhaps add a stub > like net/ipv4/udp_tunnel_stub.c ? > I suggested the notifier to be more generic and be able to re-use it for other link types although I don't have other use cases in mind right now. Stubs are an alternative as long as they and their lifetime are properly managed. I don't have a strong preference here so if you prefer stubs I'm good. >> If the others are ok with it I think you can send it as non-RFC, but I'd give it >> a few more days at least. :) Cheers, Nik