From: "Christian König" <christian.koenig@amd.com>
To: Nirmoy Das <nirmoy.das@amd.com>, rafael@kernel.org
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH 1/1] debugfs: use IS_ERR to check for error
Date: Thu, 2 Sep 2021 12:31:59 +0200 [thread overview]
Message-ID: <3f34d9a7-d5cb-5b41-7813-11d75eb25f0d@amd.com> (raw)
In-Reply-To: <20210902102917.2233-1-nirmoy.das@amd.com>
Am 02.09.21 um 12:29 schrieb Nirmoy Das:
> debugfs_create_file() returns encoded error so
> use IS_ERR for checking return value.
>
> References: https://gitlab.freedesktop.org/drm/amd/-/issues/1686
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> fs/debugfs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
> index 8129a430d789..2f117c57160d 100644
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -528,7 +528,7 @@ void debugfs_create_file_size(const char *name, umode_t mode,
> {
> struct dentry *de = debugfs_create_file(name, mode, parent, data, fops);
>
> - if (de)
> + if (!IS_ERR(de))
> d_inode(de)->i_size = file_size;
> }
> EXPORT_SYMBOL_GPL(debugfs_create_file_size);
next prev parent reply other threads:[~2021-09-02 10:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 10:29 Nirmoy Das
2021-09-02 10:31 ` Christian König [this message]
2021-09-02 10:38 ` Greg KH
2021-09-02 12:03 ` Christian König
2021-09-02 12:20 ` Greg KH
2021-09-02 15:10 ` Christian König
2021-09-02 16:34 ` Greg KH
2021-09-02 16:44 ` Das, Nirmoy
2021-09-02 16:48 ` Das, Nirmoy
2021-09-02 17:01 ` Das, Nirmoy
2021-09-03 6:27 ` Christian König
2021-09-21 7:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f34d9a7-d5cb-5b41-7813-11d75eb25f0d@amd.com \
--to=christian.koenig@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nirmoy.das@amd.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®