From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21C1F4334BD for ; Thu, 20 Aug 2026 11:35:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787225709; cv=none; b=X2cgUbm2m15hWLtpx5PYJa6+BnutBK6FtfC06cY/93jxbndlAPXUF+tz05kEjjYwvqSPnaFMQR6iCHm853g5Fl5DuL9s7IPNzTVv0TdSTCxmXpCcz6WWNBiY1y0fmJ8Kwv6AX1nzu1b8tcq4Jl13dVfPj6cX3bZeHALWzaFt6nA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787225709; c=relaxed/simple; bh=w/oe/n1XYNtDc0P/sdP49l4CFCqy7eqL6XVrY+vYFP0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LKrh8AfMUHyOnOG8kdcmARwTutwYBJwsPX6PQ8988c8nxxuIbKGRvBBnuyTOoN04Pp8X1qcMLREws3+A+H1aFQjwOfaHiZn/F7ihDFeIFAw5dN9Y7CG6pvFn4qM1NsSDAEfM942EZ5FTAVfuaA36gR5i7oINgx0yYIe6Mc5uMpU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=INnkzwFD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UYcvNaX6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="INnkzwFD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UYcvNaX6" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67K6n8pE3732030 for ; Thu, 20 Aug 2026 11:35:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ozwCerwZWysjPLIz52++2YvvXko1OeccWoS1EoE+S/c=; b=INnkzwFDr3Mt1N52 g+XzLhNJuP+bvMZ1xMcVQcUw5aLDHKyA8EVsfD9vtdhiDG/VqOAKHKPfbYiL5Ky0 4UfyOzpOTJgAS+VXDxyt6nu+I9LNrqrIrNUdqg0dgy/0fdYHvsofX89QYMvG3o3A WBJHYkd5w0pWXPGrq8ZZec33IxE6/yDkOTTs43JL0SAzWTRA4C9iRFe+i8JcV46n hbJDHDyU1D/pB9kGyG2DSDUcAq6dF6hpAYfUjbjJJkTzBEwgFJXJrqVTBcipwv2q 9bbd5+x/7UOk9WrPY//PscDf+SUWRq6XThmZ1eDWmLHyggSsg0oRT3qyVrZc8+MB GrA4aw== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g5vn893ds-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 20 Aug 2026 11:35:06 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-84e4ef9a74aso3602790b3a.1 for ; Thu, 20 Aug 2026 04:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787225705; x=1787830505; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ozwCerwZWysjPLIz52++2YvvXko1OeccWoS1EoE+S/c=; b=UYcvNaX67Q4SsodrwLa0qUNGoqlTsMX3degjh7YecLjj3iTZXhGe1GEMauB3eUepF7 GcWUgC11wppa7E84lHC5SIYIg9HpkTIGKh65WrWStKWZHFLGGmIF360ho280HB/cqt07 h0FbxfXuRzQ2qw0KMbQm8XHRmpxcfpEjEIVczalzmUFnHGE1wScVRwZZoynFh2xoQUoP AlOVj2A/oECOGDibCM1t8QamtKltqdiJI5TQ3BMpEPCpQ/nhCI/kvh8+l7Iz28JSRy/0 xxAcSABQXKso/ntbYeaeZrU+4NmLEFg8+0F5GzsfLZ7hRgE3G7IeGUTGURPaWgIVOOrc YInQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787225705; x=1787830505; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ozwCerwZWysjPLIz52++2YvvXko1OeccWoS1EoE+S/c=; b=DaQfE4JrXd4PCD35U5Pqb1oIC9ctP6tcmVeI9P+BUYKk8foDiW4rfle/Jj7V3ehhvp mIlxP7Fq1YqfuKwNDXh9OigdX7e5HIlvTq/v04DdNhnZKSenvItmR5K4XLMOkHzQReWN 8spImS7uzxAs81L9a+LKika9wO8Ek4e6/F7vRIR94ZtNpPQqeYmi5CWXxuPvGm4uYaF2 ELLbX4CIaA7qQqmWx8xNNZEyJE1vHjPjf4pv0on15vxSf4NUJeaPWtM67nOfdm7zxBMl WtjRV3HPaEEidmIn7Pn89L4MVFqnNWdciFhhwY6TOQ9k6dE6BMbHs2bvMmaEKyi4JXH8 duJQ== X-Forwarded-Encrypted: i=1; AHgh+Ro8/qryNjHHw5+8FY8QX9yE3daRDftjekW8kRZ8brFSjirOUoPTEH/vh+QT5VRxtkuvestpsEH3YCe/CYM=@vger.kernel.org X-Gm-Message-State: AOJu0YyWbAjmu/dQgKd4qsYc8Xd2g+7UYJuBWLPsVid5+4RWC9hpBzH1 F+UB5LAIQTj7sadHawGFBI7S7ewDLSjOXcIJfZUrxakY+8pQfTvm533aBlXpSsKKffpHZZPkQhk 6C3yTTXqeIqO641xdKiI5eNatGQ/8w9dzMhkf1MDOUZwjtmP5SpkKTmipgk0Ono1O+Xc= X-Gm-Gg: AR+sD11XdPf1wjAovSNXsVpoyGdTqLCuoUPHWBTqwox+A4BVw06FPJKWjX+mE+W2whv 9dPW/Khiv8YVaALpa3uaKnjyGNcebilqRgbnDbksKPQpE/6QCXBRA9OHLyzifiB5wO7lMCoFOOW vwJjMAF0dA+3ggUi8o9yfXikfn318Wkig55k23ZV8JMnLAtXPVAJf9A+I3/WZzL2hXGbhwXlGg6 G/x86CuEka833MJVc00Mw/u0+eLDv3Azl8nats46dJTTQxvmvK4Zs6kiS+f1NJh21VOS13Vrm7x ME5oMrkEaaE6zopLs9EpcEGC2OsbdMk2vzMgbb+MdLGNgPjW6dzsz2lTfc/W75yAZiaRsv0ZfPw /qlrE9atwR6X7B5IiuaQT3c8arZ7s/g== X-Received: by 2002:a05:6a00:808f:b0:848:56d4:3288 with SMTP id d2e1a72fcca58-851d383149amr20467236b3a.4.1787225705554; Thu, 20 Aug 2026 04:35:05 -0700 (PDT) X-Received: by 2002:a05:6a00:808f:b0:848:56d4:3288 with SMTP id d2e1a72fcca58-851d383149amr20467124b3a.4.1787225704987; Thu, 20 Aug 2026 04:35:04 -0700 (PDT) Received: from [10.239.133.197] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-851d3617efdsm1528743b3a.39.2026.08.20.04.35.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 04:35:04 -0700 (PDT) Message-ID: <3f352680-7090-456a-ab08-2d3367641783@oss.qualcomm.com> Date: Thu, 20 Aug 2026 19:34:57 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] cpufreq: loongson3: Replace per-package mutex with per-node To: Huacai Chen , "Rafael J . Wysocki" , Viresh Kumar , Huacai Chen Cc: loongarch@lists.linux.dev, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Xuerui Wang , Jiaxun Yang , stable@vger.kernel.org, Hongliang Wang , zhongqiu.han@oss.qualcomm.com References: <20260818123921.3600606-1-chenhuacai@loongson.cn> <20260818123921.3600606-4-chenhuacai@loongson.cn> Content-Language: en-US From: Zhongqiu Han In-Reply-To: <20260818123921.3600606-4-chenhuacai@loongson.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIwMDA4NSBTYWx0ZWRfX441/mWXjyu+n r82PtjBCK5ped+WFH9c6gSn26gK9s+tQcl4YJsMC9cLU05rl4t2L3+XDo1WW2kZ7DPBNj5pYOE+ NLfILuMJC1XVDUwKZX6Zr0b4FH/rvvSWeNqzKjh/8UQWlrnJ3PwNWrYPTVpE+EdNc19D2hqggOg 89lPkFncFqe/9x0CGY46Dlq1hKWpSDml66gn3qW1xZFmg8C4qlD8a4hiZVBiFOZI1OIsfd7a7hp 0BlKUaDDAQFRhHdNYvmcfWX+e7y6S8UcN/oVuOYNhVsq/l1UIetO0ryX5EMHDmUF7iVbbSUTran WJ5+t2RfA78R95/GeCMcroqNj/ZSIKp/VkrGtgLixLs20+ZNvkXlQFo8SHCUGIG/QUxHycLuYLb tgn4Hg9XIYuSv1ensheJaIfeQFa+KYIOCTwVnv/dRG6wd3G7LXxB6WB5hX5lImx6vqU848yN9Ib 4/yRLw2lxFItUDUtlRw== X-Authority-Analysis: v=2.4 cv=KpJ9H2WN c=1 sm=1 tr=0 ts=6a86e66a cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=aB35LMdZ1wvYvMI90LkA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODIwMDA4NSBTYWx0ZWRfXyQaFyrHUUrS4 tXlm2uy+Hvq18NbhT9Dl4nTrH6StojDz/XLpyd8SsPZghISvahHKl/BpmCCgMKO/V/W8IuV1p9W Q94+076qINmT5z3jmglPQluuQ8m4cyg= X-Proofpoint-ORIG-GUID: kbB5ssGLNMEeYOfvfe86n6F12WOQwB68 X-Proofpoint-GUID: kbB5ssGLNMEeYOfvfe86n6F12WOQwB68 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_06,2026-08-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608200085 On 8/18/2026 8:39 PM, Huacai Chen wrote: > Our server productions (e.g. Loongson-3D6000/3E6000) can have multiple > nodes in one package and SMC mailboxes are also per-node. So replace the > per-package mutex with per-node one. > > Cc: stable@vger.kernel.org > Signed-off-by: Hongliang Wang > Signed-off-by: Huacai Chen > --- > drivers/cpufreq/loongson3_cpufreq.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/cpufreq/loongson3_cpufreq.c b/drivers/cpufreq/loongson3_cpufreq.c > index 630f679aa739..e3cd78a5ab18 100644 > --- a/drivers/cpufreq/loongson3_cpufreq.c > +++ b/drivers/cpufreq/loongson3_cpufreq.c > @@ -169,7 +169,7 @@ struct loongson3_freq_data { > struct cpufreq_frequency_table table[]; > }; > > -static struct mutex cpufreq_mutex[MAX_PACKAGES]; > +static struct mutex cpufreq_mutex[MAX_NUMNODES]; > static struct cpufreq_driver loongson3_cpufreq_driver; > static DEFINE_PER_CPU(struct loongson3_freq_data *, freq_data); > > @@ -177,14 +177,14 @@ static inline int do_service_request(u32 id, u32 info, u32 cmd, u32 val, u32 ext > { > int retries; > unsigned int cpu = raw_smp_processor_id(); > - unsigned int package = cpu_data[cpu].package; > + unsigned int nid = cpu_to_node(cpu); > union smc_message msg, last; > > - mutex_lock(&cpufreq_mutex[package]); > + mutex_lock(&cpufreq_mutex[nid]); > > last.value = iocsr_read32(LOONGARCH_IOCSR_SMCMBX); > if (!last.complete) { > - mutex_unlock(&cpufreq_mutex[package]); > + mutex_unlock(&cpufreq_mutex[nid]); > return -EPERM; > } > > @@ -208,11 +208,11 @@ static inline int do_service_request(u32 id, u32 info, u32 cmd, u32 val, u32 ext > } > > if (!msg.complete || msg.cmd != CMD_OK) { > - mutex_unlock(&cpufreq_mutex[package]); > + mutex_unlock(&cpufreq_mutex[nid]); > return -EPERM; > } > > - mutex_unlock(&cpufreq_mutex[package]); > + mutex_unlock(&cpufreq_mutex[nid]); An optimization independent of this patch: considering to use guard(mutex)(xxx.lock) > > return msg.val; > } > @@ -337,7 +337,7 @@ static int loongson3_cpufreq_probe(struct platform_device *pdev) > { > int i, ret; > > - for (i = 0; i < MAX_PACKAGES; i++) { > + for (i = 0; i < MAX_NUMNODES; i++) { > ret = devm_mutex_init(&pdev->dev, &cpufreq_mutex[i]); > if (ret) > return ret; -- Thx and BRs, Zhongqiu Han