From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD632194091 for ; Mon, 27 Jan 2025 22:43:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738017817; cv=none; b=ZXb1BXAK9FJt635XlWDAiK2yYmxXqB/rN1f0Iv50i11VmqyLoqzxH5Uy/Mo+fd2IESNipx7Js0XEJ8OFneYdvrD4sTaY6a8QnE5iUsLPoHoRSeKdm5b/oULqdNh/UjXvWz8J9MvRcR6sHi4urvA631wPR6RzfnE6RDamlQrCZ1g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738017817; c=relaxed/simple; bh=nZ2PZDxOYffw3fIxkBpzrvJAhv3ukfRuhS6Z4PMFvig=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IGXmfvtKKn0fmr6hafFYVCxCdC40B+bYDqzyCQ8DS0UL2Ttjj2Gx9OBCYijSbOLJagD0Kizbtkns4msznnjUAjrkbal/X/zLSZOOCOJR4yR2E4AkRK/i/NlSGxoY2Z2hrV4rF0mLYqLA3M2YNGN2dufe9dHfCIzViOoz4GBOiYA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Ig2stEPc; arc=none smtp.client-ip=209.85.210.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Ig2stEPc" Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-71e2a32297dso2811311a34.0 for ; Mon, 27 Jan 2025 14:43:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738017814; x=1738622614; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zDNkNEpdnFoXUQ60eecA3sCT3Ukoe3YW3y86FzhMNSo=; b=Ig2stEPc9y/b0cYNyCeJ1D0sqpPQRAj7i6f5MyzXZW13sMPKsqyIWXnPux262JI6zE 1AGzynUI3ATgrkag5Ji/XEkZ7P8SxGK9LNfU0Jopw10ndGo1YYDGoy3LpCFjbLHfo708 3rf8FqyK1ZQ41NIsJPSmo6jeF7CSAoYWHIs4kONzVVR7t9j3ihx0yV3E8rbhhnzheFJh +UTyPItc/nHOT2PxjzeFg+2nrx9iHHfWnSbBFWaSEH49T5Ra6XGCgJm287RWcPwZWoTE 0mpHSiPqWSSPG6R8Y2twkwQjaxx8buNeKe7kwhmJaVlcOtW7yP0cT24GvwIk8g33rVCg NkeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738017814; x=1738622614; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zDNkNEpdnFoXUQ60eecA3sCT3Ukoe3YW3y86FzhMNSo=; b=tEwLrF43bXD6FUtIjNDa3czyESQcoao9fRSyCneLkLlvRRMrUQtCG655n3lgTUapf/ KAjgk3Kr1/012I+SxxctjIWCW/CzG8w7p6DrRohhzlwR7OCcmG/fucnU/h/GHwpAEmz9 OrsEY7Vvl+Ll8993A+SBCBqCCWwGAmXRBF50oDVaBooMd8RtJLW1QzfQNofv4j7DiAIi 9rWJeEgeSqD3lZw+owtGb+zYaPe48XXmM8mJpCDWlVSw6v7xDhi85UmpmSoEd2WRNGeV K995zEKnOIAjQbFGivLrX6pb0QU9kkgDWP/qD+/hSeQpMiR86T1Kt6IKKFw17XMdhL/e D2Lw== X-Forwarded-Encrypted: i=1; AJvYcCXQWOULRGPQUifXLsBf+czIBoX2QQ5p31UFgqJcp9nqOqwV5Om2ktHbpx080tKd0W/kdImloRA1NxAlKvY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0ilSEIqhG2ye3be6wsrpfIlpPd8HUA5wWJR0WPmCJBvITx5su 0lKheBAn8G4ATuGMo0LylIDmDNba186jRPdCFdO61vX8KGBMcDKQ0b1nMh6rPH4= X-Gm-Gg: ASbGncv7O9ZUZaRwaTQSQfgUbO3W1z+XdrO1tTc42U9qqwkEZZ9nqB35Nyh0N+TorYB fUUL0ms7IQaKKluTviDNu7t1RkCZl31vh0APTShV7Smj3k5FaJqNnSqfBJc6yfod7iT0GDL8+uL cCbawWguB70VcRpmHnxRGzAXk7uIjwcgedhwKh4WPI9vkjOyRU/DpZPBlc67NcPqsmQeiVhsAo2 S2agtHqlfUPhR8whWbNFgn0nEXHARShSjNYSYHjANuOVw2NB4o6RmhIueQNQmM5GZQ3nm4vMHW+ jRJ1TvVAXdlkudyb3dKft6adq5r60biaPWE8WWtNFw== X-Google-Smtp-Source: AGHT+IGG0EIXQSanj4mI6ftrrsuaTgRbSOGy3aZ/Tc95s25rH1GouqvtWdjuyaKysgGDS1S+BnO9aA== X-Received: by 2002:a05:6830:6184:b0:71d:ef3a:815c with SMTP id 46e09a7af769-72648bd192amr693896a34.4.1738017813886; Mon, 27 Jan 2025 14:43:33 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-724ecda4c98sm2540532a34.7.2025.01.27.14.43.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jan 2025 14:43:32 -0800 (PST) Message-ID: <3f3bf49e-0797-48e4-a2a9-25b9ad79c174@baylibre.com> Date: Mon, 27 Jan 2025 16:43:31 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/16] iio: adc: ad7768-1: Add reset gpio To: Jonathan Santos , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sergiu Cuciurean , lars@metafoo.de, Michael.Hennerich@analog.com, marcelo.schmitt@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, jonath4nns@gmail.com, marcelo.schmitt1@gmail.com References: <722340b0efff3ed22a763ce6581c96ca403316d8.1737985435.git.Jonathan.Santos@analog.com> From: David Lechner Content-Language: en-US In-Reply-To: <722340b0efff3ed22a763ce6581c96ca403316d8.1737985435.git.Jonathan.Santos@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/27/25 9:12 AM, Jonathan Santos wrote: > From: Sergiu Cuciurean > > Depending on the controller, the default state of a gpio can vary. This > change excludes the probability that the dafult state of the ADC reset > gpio will be HIGH if it will be passed as reference in the devicetree. > > Signed-off-by: Sergiu Cuciurean Since you (Jonathan Santos) are the one submitting these patches, you should add your Signed-off-by: here on the last line since you are the last one touching the patch. And if you feel you made significant changes on top of Sergiu's original patch, could could even add a Co-developed-by: line before that. More info: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin > --- > v2 Changes: > * Replaced usleep_range() for fsleep() and gpiod_direction_output() for > gpiod_set_value_cansleep(). > * Reset via SPI register is performed if the Reset GPIO is not defined. > --- Reviewed-by: David Lechner