From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06C9D319847 for ; Mon, 18 Aug 2025 13:31:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755523915; cv=none; b=jDV59JJiKmX/KtsyTalq9LHZxqFOollLdyGajcHpeMyE2Lslxs6cv7rzMlOCH8TFUjd+M12zzHCfhW8c4PGn7gqOEx3SgAemXwgCo5iEiN5YaHJtOWnKMPpeK0zuNTTCahet3414wMrD9vV5WB5uFWdu3bubUf/8HRsxzv9qL1U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755523915; c=relaxed/simple; bh=psGGo+q29tQwkhb2p9+G6aCr6y6wqU+zBZ3myvRYS2Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pFJYrir3xjj1m3ps511VsSjpjhuFlyLY0RT+kPU4IpRIgCvg9oV7CAj5bTAdD2Vmb8P5/fxy0A4u99mcN3gyf3C7Ny5fSz/4ESt1tO5hqsXYiI9YVf12odFl6PM/UWHh1J9cHPtjgid8uzlgBpaUNCpdGVcoleNSYw4f8eWJlJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=t0ybjQFT; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="t0ybjQFT" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3b9df0bffc3so2872934f8f.1 for ; Mon, 18 Aug 2025 06:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755523912; x=1756128712; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kxqOAdTahBCTy7k9I2OysnH6iHbDX78DGOE9Ul6vuMg=; b=t0ybjQFTBLH5xKuROBZPWOEP2X/uUDHLGWcC19rf28A8LYFuVYHp+t3CUhdvLRFk1a 7D8dVoUf7rZDBOeLy4iJxGd27JmtDmeGPIFTCaElS7aL5FjfuNUp6FFP11pbwbfg0kKt RktKRoPoG5Y0ELetAXrc0zOXc8oHW46fTqZx1hz/BkHBB4uuvW0AkLIh8vWyWEyVPKyP OAEMEaQ2xC4/FjGwaikDkCqxIBxLa4N/s9//qY1uGOWPkKlQAQltvR4C4zxGQ8bLVjZp WWp5Jfn+xZkQc8JQOZWlmSNnkOd9QDhjNGCPcyUezgANf/G5l5xO2EA9ukR6Uz86vX6V DlKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755523912; x=1756128712; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kxqOAdTahBCTy7k9I2OysnH6iHbDX78DGOE9Ul6vuMg=; b=j/H7sj9YI0VxsToBALmX2IaV6eePsXv227uUIbsJuJkhW2OKPoHwux07+F04bSlW1m h2qyqwWE6q4W6fe0L0+aNBOiFm6O94U5xQsCIZG+4xou3EblzJ2YOLd0E6N6IGZ71CVD 9jmLypigwxuLK73sHydw8Y0j7jsenSCo6fJIiHS+zXVaksZQn4NsW2NH4KtfB+xRaZCK Y9kTOQ1sEbDIzUEq2mBRj0IOvKIbJSeDEqipyQ4Ixsr0L/o5vADz/bMFr5kk0DuFf0jG 6qYAAUP2yw5BcoMC3KQz61C53AkI+UV4q12zE9suhKciXFYpoGWUbCrYCQ7VA9gUKfWx J/Uw== X-Forwarded-Encrypted: i=1; AJvYcCUZzgkOKY0BufW/v9qu4f0EMtJYk5SJc7hNEO5GQuW4cK5Rw7tqpBR2tmj0VvvIP/GxpdY7tWKUaAa13zE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywfvc4SK31djNCqP3MYJXCugsd5jK/QTmrWuNwQ/CEN/sfIIkOQ gHKNfHOesNlClq8aRTerbzCqeX2nbwAkGZJFJM6gtyanE+4uXi5qJGDmXxQLOfenT0s= X-Gm-Gg: ASbGnct41WYY9hC/atmFEDAFtG2FERIs/HrbY904ztasfDCLPBllsiv0g6Qne+xZniw nrUN4P6RspbJblV8TOyTyiHx6RRKhZyi2R/z1t9bN6nmQZ5kLH8jehYyZULxqdzyLEXY+yvjuug SJbi2dh00SKf05653uMXA33lBXPv35Di5n70Vkbxk0kRUESzzSsbBJwxCW93w+8tjbVkFDv3/Aq S8hqnYE42ZwyCH/BS8zX44r1kehnjhS7JBw76ZlIkaKq7X+Fmx9wmbyspG0a4QlkAfhETQNmAnR KXzfQJLjfDheToqXVri2zasLwWo5x7DuwHt5TqyRjNUhiyGDWzzs2KQgj5cc6JlgBgVN36eVPWw R7K0zaaY2Gamhgy80crIsyUql3UA= X-Google-Smtp-Source: AGHT+IEHaxfhHyN2OlOCJM1LCuzQK+0ngY10UoeZqNZoqkFY+N+fhTjcOBUMDDIKBauOY81Na0BJmA== X-Received: by 2002:a05:6000:18aa:b0:3b7:9af4:9c75 with SMTP id ffacd0b85a97d-3bb68545c71mr8765815f8f.30.1755523912274; Mon, 18 Aug 2025 06:31:52 -0700 (PDT) Received: from [192.168.1.3] ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3bb676c96dasm12687711f8f.43.2025.08.18.06.31.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Aug 2025 06:31:51 -0700 (PDT) Message-ID: <3f401e84-7236-457f-a2ce-ee45898f1ab9@linaro.org> Date: Mon, 18 Aug 2025 14:31:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/13] dt-bindings: lpspi: Update maximum num-cs value To: Frank Li Cc: Mark Brown , Clark Wang , Fugang Duan , Gao Pan , Fugang Duan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com, linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> <20250814-james-nxp-lpspi-v1-11-9586d7815d14@linaro.org> Content-Language: en-US From: James Clark In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14/08/2025 7:28 pm, Frank Li wrote: > On Thu, Aug 14, 2025 at 05:06:51PM +0100, James Clark wrote: >> As mentioned in commit f46b06e62c86 ("spi: spi-fsl-lpspi: Read >> chip-select amount from hardware for i.MX93"), some devices support up >> to 3 chip selects so update the max value. >> >> This isn't a fix or functional change because the devices with 3 chip >> selects support reading the number of chip selects from hardware, so the >> value wouldn't have needed to be set here. However the commit states >> that the DT could be used to overwrite any HW value, so the full range >> should be supported. This also avoids confusion for any readers about >> how many chip selects there are. >> >> Signed-off-by: James Clark >> --- >> Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml >> index a65a42ccaafe..ce7bd44ee17e 100644 >> --- a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml >> +++ b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml >> @@ -64,7 +64,7 @@ properties: >> description: >> number of chip selects. >> minimum: 1 >> - maximum: 2 >> + maximum: 3 > > You need keep the same restriction for other compatible string, or need Not sure I follow here. Don't the binding docs only cover the maximum range of valid inputs for all covered platforms? They don't go into details about which ranges are valid for every individual sub-platform. For example if a platform didn't support DMA we wouldn't say it's not valid to label DMA channels in the binding doc. If someone puts 3 instead of 2 then that's just a mistake, but documenting valid ranges can't really fix a mistake like that. And changing 2 to 3 doesn't break existing DTs, only making it smaller would. > reason for other platform which also support up to 3. The reason is that some platforms support 3, so I thought it made most sense to set the max to 3. I replied more on the thread with Rob, but we can just drop this one. > > Frank > >> default: 1 >> >> power-domains: >> >> -- >> 2.34.1 >>