From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: "Heiko Stübner" <heiko@sntech.de>,
"Shreeya Patel" <shreeya.patel@collabora.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
jose.abreu@synopsys.com, nelson.costa@synopsys.com,
shawn.wen@rock-chips.com, nicolas.dufresne@collabora.com,
"Sebastian Reichel" <sebastian.reichel@collabora.com>
Cc: kernel@collabora.com, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org, Tim Surber <me@timsurber.de>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Diederik de Haas <didi.debian@cknow.org>
Subject: Re: [PATCH v14 1/3] arm64: dts: rockchip: Add device tree support for HDMI RX Controller
Date: Thu, 6 Mar 2025 19:24:25 +0300 [thread overview]
Message-ID: <3f5da931-081a-4859-8833-655a5b5a3b9d@collabora.com> (raw)
In-Reply-To: <3216426.Mh6RI2rZIc@diego>
On 3/6/25 19:16, Heiko Stübner wrote:
>>>> + pinctrl-0 = <&hdmim1_rx>;
>>>> + pinctrl-names = "default";
>>> hmm, this might be better living in the board dts?
>> HDMI RX controller is a part of the SoC, it's not specific to a
>> particular board. If you meaning move it into rock5b.dts, then we
>> definitely shouldn't do it. It's like moving PCIe controller node into a
>> board DT 🙂
> sorry, should've been clearer. I meant the pinctrl.
> There are two sets of pins hdmim0-rx and hdmim1-rx which one is used is
> board specific.
>
> Can you check if "most" boards use the M1 variant?
>
> Rationale being, that if we know that most boards use the same set of
> pins, it's likely ok to just have the minority boards override it.
Will check, thanks for the clarification!
--
Best regards,
Dmitry
next prev parent reply other threads:[~2025-03-06 16:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 7:28 [PATCH v14 0/3] Enable HDMI RX controller on RK3588 Dmitry Osipenko
2025-03-06 7:28 ` [PATCH v14 1/3] arm64: dts: rockchip: Add device tree support for HDMI RX Controller Dmitry Osipenko
2025-03-06 13:06 ` Heiko Stübner
2025-03-06 15:53 ` Dmitry Osipenko
2025-03-06 16:16 ` Heiko Stübner
2025-03-06 16:24 ` Dmitry Osipenko [this message]
2025-03-06 7:28 ` [PATCH v14 2/3] arm64: dts: rockchip: Enable HDMI receiver on rock-5b Dmitry Osipenko
2025-03-06 13:07 ` Heiko Stübner
2025-03-06 7:28 ` [PATCH v14 3/3] arm64: defconfig: Enable Synopsys HDMI receiver Dmitry Osipenko
2025-03-06 9:26 ` [PATCH v14 0/3] Enable HDMI RX controller on RK3588 Heiko Stübner
2025-03-06 9:41 ` Hans Verkuil
2025-03-06 9:44 ` Heiko Stübner
2025-03-06 13:09 ` (subset) " Heiko Stuebner
2025-03-06 17:47 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f5da931-081a-4859-8833-655a5b5a3b9d@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=didi.debian@cknow.org \
--cc=heiko@sntech.de \
--cc=hverkuil@xs4all.nl \
--cc=jose.abreu@synopsys.com \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=me@timsurber.de \
--cc=nelson.costa@synopsys.com \
--cc=nicolas.dufresne@collabora.com \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=shawn.wen@rock-chips.com \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®