From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F727C433EF for ; Fri, 25 Feb 2022 10:26:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239473AbiBYK0w (ORCPT ); Fri, 25 Feb 2022 05:26:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231214AbiBYK0u (ORCPT ); Fri, 25 Feb 2022 05:26:50 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 216BE1DDFEF; Fri, 25 Feb 2022 02:26:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1645784778; x=1677320778; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Od2Q0PrAzsRZXZ0/z1Qgjp51QpoNvxr0jp+QIqhly54=; b=1N2xLO06AH5D+xfj4zQjH/E2qM4Lf8HyqCLW1M11IF+wXf1k6KT6r3Rf IdIQmRdH2wYHvcfy5P4LEaeYUt9UpCy4aAOhWRFdleKpycvPF4tAQHhyU R7odGBCRSwrmV/RRmetGUlVwgL6absWITu8Qw0zK0foFfEJdm9DRQg88Y zoV8Qa+qTJFkW/HpvO2GLdrmq35hCGmXNVXiDFQJXhb+392mA5BD8qNGu GXv8Xm0P2D/vNRC6HL8O4bpW8Z7P87bLWkFyrPqZvF9lydqw9RY/4BkwQ VGyNPvoMZmJHXYKzjQQcVTe7MTIUsqWCdgn5Bw8TZiBK7Sz1U/xn7hD0U g==; X-IronPort-AV: E=Sophos;i="5.90,136,1643698800"; d="scan'208";a="154399769" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 25 Feb 2022 03:26:17 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Fri, 25 Feb 2022 03:26:16 -0700 Received: from [10.12.72.56] (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Fri, 25 Feb 2022 03:26:13 -0700 Message-ID: <3f5fdfca-1bbc-d6aa-4649-c50a9cd92052@microchip.com> Date: Fri, 25 Feb 2022 11:26:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v7] ARM: dts: add DT for lan966 SoC and 2-port board pcb8291 Content-Language: en-US To: Michael Walle CC: Kavyasree Kotagiri , , , , , , , , , , References: <20220221080858.14233-1-kavyasree.kotagiri@microchip.com> <3b4c56201a478876783e69243c901cd8@walle.cc> <85566f97-dcfc-f477-1ebb-5cac955b791a@microchip.com> <413b29b8a2e7a73561f942d4b7c78b9b@walle.cc> From: Nicolas Ferre Organization: microchip In-Reply-To: <413b29b8a2e7a73561f942d4b7c78b9b@walle.cc> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/02/2022 at 15:55, Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Hi, > > Am 2022-02-24 15:51, schrieb Nicolas Ferre: >>>> +/ { >>>> + model = "Microchip LAN966 family SoC"; >>>> + compatible = "microchip,lan966"; >>> >>> As mentioned earlier, this isn't a documented compatible string. So, >>> I guess without overwriting this in the board dts it will throw an >>> error with the dt schema validator. OTOH, there are many dtsi files >>> in arch/arm/boot/dts/ doing this. I don't know what is correct here. >> >> I see it documented here: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/atmel-at91.yaml#n165 >> >> Isn't it what is expected? > > That only documents > compatible = "microchip,lan9662-pcb8291", "microchip,lan9662", > "microchip,lan966"; > > But not the one above. Oh, you mean the "microchip,lan966" string alone in the compatibility string and not with the other ones before it... I didn't know it could be different in yaml syntax. Thanks for highlighting that. Best regards, Nicolas > >> >>> Everthing else looks good. >> >> Thanks a lot for your reviews. >> >>> Reviewed-by: Michael Walle >> >> Acked-by: Nicolas Ferre >> I'm queuing it to at91-dt branch for reaching arm-soc in 5.18 merge >> window. > > Nice, then I'm good to go for my patches on top of this :) > > -michael -- Nicolas Ferre