From: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
To: "andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"s-vadapalli@ti.com" <s-vadapalli@ti.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"dan.carpenter@linaro.org" <dan.carpenter@linaro.org>,
"jpanis@baylibre.com" <jpanis@baylibre.com>,
"npitre@baylibre.com" <npitre@baylibre.com>,
"c-vankar@ti.com" <c-vankar@ti.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"horms@kernel.org" <horms@kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"rogerq@kernel.org" <rogerq@kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"vigneshr@ti.com" <vigneshr@ti.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"srk@ti.com" <srk@ti.com>
Subject: Re: [PATCH net v3] net: ethernet: ti: am65-cpsw: Fix NAPI registration sequence
Date: Tue, 11 Mar 2025 18:49:38 +0000 [thread overview]
Message-ID: <3f6b99966ff7ad119d087e65f0f58e5b1411066f.camel@siemens.com> (raw)
In-Reply-To: <20250311154259.102865-1-s-vadapalli@ti.com>
Thanks Siddharth for reworking the patch!
On Tue, 2025-03-11 at 21:12 +0530, Siddharth Vadapalli wrote:
> From: Vignesh Raghavendra <vigneshr@ti.com>
>
> Registering the interrupts for TX or RX DMA Channels prior to registering
> their respective NAPI callbacks can result in a NULL pointer dereference.
> This is seen in practice as a random occurrence since it depends on the
> randomness associated with the generation of traffic by Linux and the
> reception of traffic from the wire.
>
> Fixes: 681eb2beb3ef ("net: ethernet: ti: am65-cpsw: ensure proper channel cleanup in error path")
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> Co-developed-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
LGTM,
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> drivers/net/ethernet/ti/am65-cpsw-nuss.c | 32 +++++++++++++-----------
> 1 file changed, 18 insertions(+), 14 deletions(-)
--
Alexander Sverdlin
Siemens AG
www.siemens.com
next prev parent reply other threads:[~2025-03-11 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 15:42 Siddharth Vadapalli
2025-03-11 18:49 ` Sverdlin, Alexander [this message]
2025-03-12 13:39 ` Roger Quadros
2025-03-18 10:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f6b99966ff7ad119d087e65f0f58e5b1411066f.camel@siemens.com \
--to=alexander.sverdlin@siemens.com \
--cc=andrew+netdev@lunn.ch \
--cc=c-vankar@ti.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jpanis@baylibre.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=npitre@baylibre.com \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®