From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C1FF1422D2 for ; Tue, 30 Jul 2024 21:00:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722373208; cv=none; b=e7ZwcHLgRIAOvnk/KMsazGDIVKi7BWnrbQs5EzmzOxk6IiNbcqLOwa1eiXMhC/gwAYrRHX5P0+WQJeKXZszceRk8vxIF9YBtMPDvRY4fhFOe8NjKnLifBsYmoAtsCsvTwMwWCBTOEva9Woqad0SKkY7jKReP/bWhRr/4CwGAl0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722373208; c=relaxed/simple; bh=O5Ol+FhNUttO8Rc6kBMkNVl92zf0rjm0gCmDpPRvkZI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pjLGqMcBQ+xI+cdT/T3wh+vWGUZP9XbRERbw/bi9hVCaT0Ge42y/CL9QwLKJoxgsJbwprBZqiydNHsz/JbSEQ8oFRb0hD94AtVx+tj8pbODahPYyrIaZe1UMwYQxHywppgZOXkihpVEKz2n84YAft4uALl88gMIaPm0t4etHz0I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ds0Iyeqq; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ds0Iyeqq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722373205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Dd2GE5fxYQXd3FamrUnZxrNJqYzFYBEEnX6o4Yw/b8A=; b=Ds0Iyeqq+K2mtBd4rFUY/MeypVuxnuLEIyrGhKl5fzglaLBhgLlCW3Pxrt2tLL/mkgph2e LqNzLq1Ug12uCzXuJMIcmVjtrRUwj0xCln50j7FlHeZOArRPRiHyQ4hnmkNNFJ9ERUY77h MMSvF6DKKc65ImkDkzO+Y4Qt21upBS8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-499-dILhNo8kMDWglbwc_7yZWw-1; Tue, 30 Jul 2024 17:00:03 -0400 X-MC-Unique: dILhNo8kMDWglbwc_7yZWw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4281ca9f4dbso22625175e9.0 for ; Tue, 30 Jul 2024 14:00:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722373203; x=1722978003; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Dd2GE5fxYQXd3FamrUnZxrNJqYzFYBEEnX6o4Yw/b8A=; b=CXF4SK3o0/BUHCKoAKmDmh08ZBSfJi26W+D7JRRlPj5fUqJBAC4yKk8nhXlHWnofyZ O03FeqQggsrOcTtgaUPTbpDCnlPoD31dnAtugibrailPTV3dGyzXzKPb655AuuuwaEBb RhfNmZIKqR1ajUgwmVwNkQP+oJkyhj2br9XlBKMpT8AyNEh5GJm+2XMvPUfR9Ijv8zlo wzBJ2DVxJT8fOZXBuzRQ3cikM67z4/IfgqfHwR9Li2uenio38qju1UPV2F6iVy8D27LE 2jUC1NSMjTi9WmYdrJZDCBhckeWh/LmE07MfxqJQUaLGDsULmVX8lXDe+zZtmq2iM7NL 4Xhg== X-Gm-Message-State: AOJu0Yyg/2L0QjD+cRknCm/FwLcbakV7lJYPg75xi/D1HwojcBmPNz1H jAOrX/cmr5TbXvb91xIE8NQ9J4b65JYT2oW0oqhpD6lKklScSsF+m8n34zqaHsU5qx3OyHGNh+j hUYfBmnngAfnInFnST0uw9+5s/0yF8qmUuJ1mlXpHKJgjNWckxNWgxnc4Z4xUuw== X-Received: by 2002:a05:600c:3109:b0:428:1663:2c2e with SMTP id 5b1f17b1804b1-42816632d21mr72811335e9.17.1722373202598; Tue, 30 Jul 2024 14:00:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFNCsRwlsvh43ZSSbMWT/1ocm0X/IsCJR1zXxkMwP6xwcDRthKIbvBG39LDykQwp4+7n9CM9g== X-Received: by 2002:a05:600c:3109:b0:428:1663:2c2e with SMTP id 5b1f17b1804b1-42816632d21mr72811245e9.17.1722373202064; Tue, 30 Jul 2024 14:00:02 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:4e00:31ad:5274:e21c:b59? (p200300cbc7064e0031ad5274e21c0b59.dip0.t-ipconnect.de. [2003:cb:c706:4e00:31ad:5274:e21c:b59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-428175e60b7sm123163245e9.42.2024.07.30.14.00.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jul 2024 14:00:01 -0700 (PDT) Message-ID: <3f6c97b5-ccd8-4226-a9ac-78d555b0d048@redhat.com> Date: Tue, 30 Jul 2024 23:00:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/hugetlb: fix hugetlb vs. core-mm PT locking To: James Houghton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, Peter Xu , Oscar Salvador , Muchun Song , Baolin Wang References: <20240730200341.1642904-1-david@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 30.07.24 22:43, James Houghton wrote: > On Tue, Jul 30, 2024 at 1:03 PM David Hildenbrand wrote: >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index b100df8cb5857..1b1f40ff00b7d 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -2926,6 +2926,12 @@ static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pmd_t *pmd) >> return ptlock_ptr(page_ptdesc(pmd_page(*pmd))); >> } >> >> +static inline spinlock_t *ptep_lockptr(struct mm_struct *mm, pte_t *pte) >> +{ >> + BUILD_BUG_ON(IS_ENABLED(CONFIG_HIGHPTE)); >> + return ptlock_ptr(virt_to_ptdesc(pte)); > > Hi David, > Hi! > Small question: ptep_lockptr() does not handle the case where the size > of the PTE table is larger than PAGE_SIZE, but pmd_lockptr() does. I thought I convinced myself that leaf page tables are always single pages and had a comment in v1. But now I have to double-check again, and staring at pagetable_pte_ctor() callers I am left confused. It certainly sounds more future proof to just align the pointer down to the start of the PTE table like pmd_lockptr() would. > IIUC, for pte_lockptr() and ptep_lockptr() to return the same result > in this case, ptep_lockptr() should be doing the masking that > pmd_lockptr() is doing. Are you sure that you don't need to be doing > it? (Or maybe I am misunderstanding something.) It's a valid concern even if it would not be required. But I'm afraid I won't dig into the details and simply do the alignment in a v3. I'm hoping I'll be done with that hugetlb crap soon; it's starting to annoy me and I really should be working on other stuff ... -- Cheers, David / dhildenb