mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: rkrcmar@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] kvm: VMX: do not use vm-exit instruction length for fast MMIO
Date: Fri, 18 Aug 2017 14:41:52 +0200	[thread overview]
Message-ID: <3f6fd875-037c-91c8-b570-d5010751d175@redhat.com> (raw)
In-Reply-To: <3b7afdfc-d308-7645-2105-6bb339188aa6@redhat.com>

On 18.08.2017 14:35, Paolo Bonzini wrote:
> On 18/08/2017 13:57, David Hildenbrand wrote:
>> What about a hack:
>>
>> 1. clear instruction length when entering
>> 2. check if instruction length is set when trying to forward the RIP
>> 2a. if set, use it
>> 2b. if not set, compute it
> 
> It's undefined, so we don't know that the instruction length remains
> zero (also, on older processors and possibly some nested setups the
> field is read-only).

Oh I see, too bad :(

> 
> Testing the hypervisor bit is the first line of action.
> 
> Paolo


-- 

Thanks,

David

      reply	other threads:[~2017-08-18 12:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-16 13:34 Paolo Bonzini
2017-08-16 14:10 ` Michael S. Tsirkin
2017-08-16 16:56   ` Radim Krčmář
2017-08-16 17:04     ` Michael S. Tsirkin
2017-08-17  8:07     ` Yang Zhang
2017-08-17  8:28       ` Wanpeng Li
2017-08-17  8:31         ` Wanpeng Li
2017-08-17  8:48           ` Yang Zhang
2017-08-17  8:51             ` Wanpeng Li
2017-08-18  3:33               ` Yang Zhang
2017-08-18  8:46   ` Jason Wang
2017-08-21 16:03     ` Radim Krčmář
2017-08-18 11:57 ` David Hildenbrand
2017-08-18 12:35   ` Paolo Bonzini
2017-08-18 12:41     ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f6fd875-037c-91c8-b570-d5010751d175@redhat.com \
    --to=david@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®