From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49F53399377 for ; Thu, 4 Jun 2026 08:30:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780561857; cv=none; b=CSJxtumv3EuRwlfQJC9M/cGJD61WOruQp6H3lxA5MlQj9d2bAhQVGISFTc/ztiL1vGr3iO5endAkej9N1fScqrRN6jWQsUHz8cOVqH6OwE2HOUWqI2JxWMIWWPoGOcRxXL1Y0g9HpFC8VCXlZdIQPl1ovgyZON+bWBgO76RVVhI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780561857; c=relaxed/simple; bh=Z8OVP16ejdIREmaWRl+L2yDU+RGvvMKUI+ywOyOT+Dc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CxoD2a6NkLoGwmcWRTIoY3/pED9pKO03GjdQ69FDu6RXY4Gvazl95eb4pMdTlmjdKq9Ovwe7PWbJQMuzDcHSmCqR7+EHqjJrkCzF6mCkW6MYAYhQ14SXVoXtR1MK5VNHcOD2g9f2/oHNxNCDBv1+ps5vgjgUkEa82dD5KRBgRSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UD+liWiU; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ebhXAAJO; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UD+liWiU"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ebhXAAJO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780561854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zfG24Fn7ZF6pSbC0Um/66jIGY3WmDN4xCLgytW1z1jY=; b=UD+liWiUdumWgI82Sin9aF50Ki4tBRxzVKrhCF3+A6WPX1Fe7YXyd3d5mKHUUebneTT24m hBKu25QjSOWXqj8G9gHqkUofX4f1PQFU+wQh5udUqsK9QWXG8iqvmUDBBd0csv+N76953K 8edV/Kkr+ypLUuEXtBMFFGGagM2mL58= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-B1znBhWVO5a3h7muiGweYw-1; Thu, 04 Jun 2026 04:30:52 -0400 X-MC-Unique: B1znBhWVO5a3h7muiGweYw-1 X-Mimecast-MFC-AGG-ID: B1znBhWVO5a3h7muiGweYw_1780561851 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-bec23d0e9dcso37697366b.1 for ; Thu, 04 Jun 2026 01:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780561851; x=1781166651; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zfG24Fn7ZF6pSbC0Um/66jIGY3WmDN4xCLgytW1z1jY=; b=ebhXAAJOxPuYUCm2E+Z4/MnGMbPsbrcllRKVD3X8qYICrtHb2fn87aGtR3Q0SWeES5 xzAFHDQ/hMUrIXb0/Jl5ZezTSgwLssVIsqJ0wB5XJTzU60djQ07AdrhfR4aLCj7mVvlb 8KKjSo53B2lG1CwNhw9V2qaDpGl4EhBLZh4zVxeydMQQV6rW2k0EdMplmQ9xJeJwI4WL HuPHgv0ty0/oUW8KNilhfj0KA/3y5j3wmem9Mp5lNaXCPXL4JUoC3/FJL+zfGU6ocwYF piSigVdiGf07hJf9s+BYSEc6TbfK4KO3bONkPCKhM9uE4csMKsuE2Qeiun54wnrvBdqV 4Hdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780561851; x=1781166651; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zfG24Fn7ZF6pSbC0Um/66jIGY3WmDN4xCLgytW1z1jY=; b=XPBH8Ph4dN62MPINxg7PgUjLFNfM5PbfRQf30k7zF1obYzTAh3lgiYG8h2wow/idhk kZqxA1pRyTfhModdmUh2jNICN2bEHDjnpzmCLSc+HN2NeRLTFRupppKNaaJWjcP/guHU IuFrgC74Ax5anO60o/CLk/Hkm2M/FMgg0ONmRts8MChqhQv7CEye8ggddg55pbLnPJNm LSFkXWMDhCf09hN8IBlQ2XnL8p/iIVOOyC6wc5LZTzJKbrdNP6UgvB4HsBDRCyMOX6jq ua/0MC06JPUuJZYm8tBVUZ6fgn5I23zWIReQx0uIxqqm2LPGYdiQIetnYh2QLE7+DYU8 gzaA== X-Forwarded-Encrypted: i=1; AFNElJ/HjagHz1O1SBKC+eOTr2jlDOxzCw6P6K15nZSwj6qqUWRtgCxtE+DVq/c/mI5jqCXkCucDtqfybHqAl4I=@vger.kernel.org X-Gm-Message-State: AOJu0YwOsIT/5liB9wvRQtbCTB7h0ozBpkG7cX+lzxlhcprqGy2U1cmN r1Vxc50a7sZMnGHNeEm5IEkIAoK9cAPMxtzUPdqJV+bYi0KNIroBMLcr4fxkiEqKZBxnVaWavKU Uq91rpIY2gIOlndTOLquTXz3wmkVUuvea6GxzQkXXT9BxvzTLGPIUxgiudg6IdrgThQ== X-Gm-Gg: Acq92OFuxp7MztZsAy9MpZVacsWXKt1W7xZVf1IhbLLYnUrICUzU7OyTPFItefsNLjd BpzaJeaNSbQBnNeLCvNBWRf0Bgo6w1ucNbi/XqJk75V1NL7Ir3Pfx5+5YerTU2+PiYKfzs/bEMy gq6+NcWJxRb8RnXe814iQgIkvt9qf9vEPHfRwfQfQ0rZbNqN35htdxmJpuF/9ogFzxnnEsprZRG vWzNikS4EV/Ji6KSELq4to2IHSMzQsxlFVfy1WXy30WVj7iZzlO4AE0WTlBcZrDyIyEapSibAQw UenyCPf+4vEUJUXa1cATABDooft5a+yksp0XWxWE0H/auahCyu6e4+gD20kkDUtdhbcPzergweZ wilWMha9LrIQ8H3w0BnmfJaemmLpuOwwr3prKdCj4qRxVuvAxE6ghzcPoH5z/4En6J84= X-Received: by 2002:a17:907:2668:b0:bed:6e53:bb16 with SMTP id a640c23a62f3a-bf0af3019camr239312966b.43.1780561850920; Thu, 04 Jun 2026 01:30:50 -0700 (PDT) X-Received: by 2002:a17:907:2668:b0:bed:6e53:bb16 with SMTP id a640c23a62f3a-bf0af3019camr239311266b.43.1780561850384; Thu, 04 Jun 2026 01:30:50 -0700 (PDT) Received: from [192.168.88.32] ([212.105.155.59]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf0517721c2sm261120066b.3.2026.06.04.01.30.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2026 01:30:49 -0700 (PDT) Message-ID: <3f73e314-756e-494e-a1aa-0bc39c14f41b@redhat.com> Date: Thu, 4 Jun 2026 10:30:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v6 4/5] net: sched: add timeout count to NETDEV WATCHDOG message To: hawk@kernel.org, netdev@vger.kernel.org Cc: Jakub Kicinski , =?UTF-8?Q?Jonas_K=C3=B6ppeler?= , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Simon Horman , linux-kernel@vger.kernel.org References: <20260527135418.1166665-1-hawk@kernel.org> <20260527135418.1166665-5-hawk@kernel.org> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260527135418.1166665-5-hawk@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/27/26 3:54 PM, hawk@kernel.org wrote: > diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c > index 237ee1cd0136..2aebab985c00 100644 > --- a/net/sched/sch_generic.c > +++ b/net/sched/sch_generic.c > @@ -533,13 +533,12 @@ static void dev_watchdog(struct timer_list *t) > netif_running(dev) && > netif_carrier_ok(dev)) { > unsigned int timedout_ms = 0; > + struct netdev_queue *txq; > unsigned int i; > unsigned long trans_start; > unsigned long oldest_start = jiffies; > > for (i = 0; i < dev->num_tx_queues; i++) { > - struct netdev_queue *txq; > - > txq = netdev_get_tx_queue(dev, i); > if (!netif_xmit_stopped(txq)) > continue; > @@ -561,9 +560,10 @@ static void dev_watchdog(struct timer_list *t) > > if (unlikely(timedout_ms)) { > trace_net_dev_xmit_timeout(dev, i); > - netdev_crit(dev, "NETDEV WATCHDOG: CPU: %d: transmit queue %u timed out %u ms\n", > + netdev_crit(dev, "NETDEV WATCHDOG: CPU: %d: transmit queue %u timed out %u ms (n:%ld)\n", > raw_smp_processor_id(), > - i, timedout_ms); > + i, timedout_ms, > + atomic_long_read(&txq->trans_timeout)); It looks like txq could be uninitialized here if num_tx_queues is 0. I'm unsure if some weird/buggy device driver could actually hit that case, but grep '->num_tx_queues = 0;' has more than 0 hits in the current tree and I would err on the safe side. /P