From: Markus Elfring <Markus.Elfring@web.de>
To: Tzung-Bi Shih <tzungbi@kernel.org>,
kernel-janitors@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Subject: Re: [PATCH v2 1/2] reset: Fix reset_control leak when put after controller unregister
Date: Wed, 4 Nov 2026 18:38:20 +0100 [thread overview]
Message-ID: <3f79de27-213e-4622-bca1-a5f382ecf32b@web.de> (raw)
In-Reply-To: <20261104162038.48622-2-tzungbi@kernel.org>
…
> +++ b/drivers/reset/core.c
> @@ -160,6 +160,9 @@ int reset_controller_register(struct reset_controller_dev *rcdev)
> }
> EXPORT_SYMBOL_GPL(reset_controller_register);
>
> +static void __reset_control_release(struct kref *kref);
> +static void __reset_control_free(struct reset_control *rstc);
…
How do you think about to reconsider the usage of double underscores
in such identifiers any more?
https://cmu-sei.github.io/secure-coding-standards/sei-cert-c-coding-standard/rules/declarations-and-initialization-dcl/dcl37-c/
Regards,
Markus
next prev parent reply other threads:[~2026-11-04 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 16:20 [PATCH v2 0/2] reset: Fix issues reported by Sashiko Tzung-Bi Shih
2026-11-04 16:20 ` [PATCH v2 1/2] reset: Fix reset_control leak when put after controller unregister Tzung-Bi Shih
2026-11-04 17:38 ` Markus Elfring [this message]
2026-11-04 16:20 ` [PATCH v2 2/2] reset: Fix circular locking dependency in reset_controller_unregister() Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f79de27-213e-4622-bca1-a5f382ecf32b@web.de \
--to=markus.elfring@web.de \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®