From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7D86379964; Mon, 15 Jun 2026 11:34:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781523292; cv=none; b=TnuHDKtX5//7ZHYsH5lXvAjuDePYlw0iDltKvyF4xGOSnz99xfm6iYL05aLbmW+n5abEU3MFXngqqIhsAOMLtSrZCc4UyH6d9dQdovAuDp1q+IjRYsUnnWs/tDaXCH9WEsrA9yqxtngNrZd9xJuxRuylZ2nKdHu9mLapW5tWi30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781523292; c=relaxed/simple; bh=CCf4Lsv/KZfmAydYSbK56SSDoxFvAX4Rmljmcxd+XOE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Zkz+4WGr5l/NVuVkRVZ3pfuF8H6zJweuJPrVQpH51M+dg/2siO87xGlz7YvikmimBmj5XI9hVej/MdTSEVJI0IO1OXwMQ4bmQm2ysTPTXjM7G4Zfdlfqb6IltYNlaAfIIRkGZXwnH+OWXr6FLsU8NawBQ1OPwZsnlzGg+QPfMfM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=gufDbY83; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="gufDbY83" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=MMpI+QUdBgNaQ8BRTEv9IJWFS9jCGGOTP7odTlRuEhQ=; b=gufDbY83IvZnXSgYcf0E2czW+P CEHXRHE/R+8xbQ1jf1Iu0LJiZgU9qGwj0ylp88KWzAIeMmghE3WpStZyz6k6yDgezmybSvbC/WTiO lbFJjzl3O9y0PsPG1v8oWpQFze/3TCz1SmCW4b2beVpPBm3ehXfC2db2vHPGsDEDlMOA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wZ5aT-007n2z-9k; Mon, 15 Jun 2026 13:34:41 +0200 Date: Mon, 15 Jun 2026 13:34:41 +0200 From: Andrew Lunn To: Kyle Switch Cc: mmyangfl@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ming.xu@motor-comm.com, xiaolin.xu@motor-comm.com, jianmin.wang@motor-comm.com, de.ge@motor-comm.com Subject: Re: [RESEND PATCH v1] net: dsa: motorcomm: add yt92xx dsa driver Message-ID: <3f7bf73b-c8dc-451d-981f-5e5343291960@lunn.ch> References: <20260615111235.3544282-1-kyle.switch@motor-comm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260615111235.3544282-1-kyle.switch@motor-comm.com> On Mon, Jun 15, 2026 at 07:12:35PM +0800, Kyle Switch wrote: > Add yt92xx dsa driver supports yt921x and yt922x switch series. > To support more switch series in the future (e.g., yt923x), the most common configurations are abstracted into switch operation interfaces, due to yt921x and yt922x share similar register layouts and operational logic. > > - Merge drivers/net/dsa/yt921x.c and the new yt922x support into a > unified yt92xx.c driver. > > - Add support for yt922x, which can operate with either 4 bytes or > 8 bytes DSA tag. > > - Not change yt921x behaviour but use common switch apis A 35K line patch is way too big. Please break this up into lots of small patches, each with good commit messages, which are obviously correct. Andrew --- pw-bot: cr