From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAA133AF646 for ; Fri, 27 Mar 2026 10:27:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774607275; cv=none; b=g9BiMhFGl5uWCuqrTtLeX++uvuqorbZ/AVWg2KyRlyrNF65UXdD5LMVXN6h9xFy2p4qXoyUzoPHLb2zyWfXiADWpVH1mhqaV7+kO/DA/saewTxVFJVIkKIu+sS1kFwvRDQBMLggafCxOXdigXi+Tl4PPCb3y35NtT996SfaO9tw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774607275; c=relaxed/simple; bh=hczkyq1Z0Cmb5UFUuhiSqB2G+okw/40DjLip2hZqg0Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LwcH5oEx1os5E9awm6qXZBdmLe2a/fJjdbs+D21D8qYprjneFd7loMuL/t6Y9JzDlGMKLed2DrXME8O6LoCw9oVg1/oVG/oUDoRVOFL+OmRVPyPjNCTelfooqXUJPHaX96M1t6uenwN5vW6wz7vw62QQnuxXwNXBhyC+EaC3WNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=J0auL5Hu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LICgAFkt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="J0auL5Hu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LICgAFkt" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62R6vi4o731311 for ; Fri, 27 Mar 2026 10:27:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3cl5BrM2CLM613ebLhk8oT8pQ9yMV+of2cphHRUa3Z4=; b=J0auL5HuhoT5yM8B hFGgwhNn+am4wiXgv8h1YoB30rc8jtSmik/CvHvFPb1SB2uIYZV2kKrh6gjvsG10 ivyxvGDrQT3RmsME86fEW3+sLBLok7dSG3WaNwRGcpf0f6gP4KkaaYz5SjmSlf2p /XSmFhXXDvce69JpiqvX41navEpZbYpNcMXZcQ5HRPnGcgOe/E00rwxgUr6XLfHI vAiYV9/9x1LXV1JvVDgWZN7t3+NhY24T+kLQCPXHm0shuRq9NFZJbKoXEfPtUGnr FCNo8Awecs8vqTcVjjHNtr4EpKRaGfXm3PNzZXHb1e58xp6BQ3+19ls4vSb3Q5V/ ZypBcQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d5a9q2y1c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 27 Mar 2026 10:27:50 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cdae902bccso34271285a.0 for ; Fri, 27 Mar 2026 03:27:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774607269; x=1775212069; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3cl5BrM2CLM613ebLhk8oT8pQ9yMV+of2cphHRUa3Z4=; b=LICgAFktk8ZikTevhiEUgr/dnIjVGHqSJehtE7Omv9EPe5nssMTXyA502jSEdJqp+/ L1tTE//5xrl0Y7u/YKevsy3Sl9CKV+B5jB+0MHwVVjrfaJLq7ZCSaIQWiJluSU0MsNJB Jx+zrQVa6nBm/f0k3jNPEW647Tt2yk3mPNHPVmjAs8H6uYVeEBSDPindjEZGOb55MZ+w Dy71SiuXcJXSYtG5Y40TolFNoOz3p+Y5eM0MleUw8B2T79WGoSwy6CDWvSP0IHJEYaK+ s+CqqMNoX0IXWxyZ2NAS4lzmrq8JE80bRW70iRe/ywLgJoZn3liyO02RV8Rt3iLJRkdS 5CNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774607269; x=1775212069; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3cl5BrM2CLM613ebLhk8oT8pQ9yMV+of2cphHRUa3Z4=; b=O1+sMgv8ganSE0CmIsDx7bBd6DOy+LfNjyFpdgZ6zqwS7c1Dx30EXzKnKkDhLRePLU m1I6FPOnt6h95iphZmAAFWT2WfM9h2o1GyVfuvoG4cKWvdAFqwBJnR+2KKyJdnKXm/Dg FQDe6u29/pXPPvcGGg8n/+zf01mfs4JcRCJ5vbxqL3pa+BfTXF1KLqKuagHGNljz5O8A yKlMWQ0jhGMpWXfzP3W2RwLiLKBYwy72FOFRsgg0zyPnUPFcH1z3VPXtQ5oz58yx908d PUo64etJYft1e4mFYVFGn5MDg+qDcpF/IY5XLHhzGELurX731TqtcqvqGMV5ERTxG54u SR9g== X-Forwarded-Encrypted: i=1; AJvYcCVW0wBDvsmYT46n9nfzLfxjzRdFHqmWcbyr9xv/ojwz6MWrLXkvvT3FZO3rD1o28War2pj8fLYKllMewlo=@vger.kernel.org X-Gm-Message-State: AOJu0YzamXvnBIityiKwyc71sivTR1YCtT4+8PL7DY/x8xwG9MNM5Wts ordZyuUngcSQeMZzLArV3e7pA6kjSce2LFgJyHnlrMWRS4AAQ/qa/5OGGy2dMtl0D37mdrcyY2i q94LpvQPkRRQHFeXW7xBJs5inbRxhGuVt9cW9DClYCIM4MQH9c0oBKzaf7hbzvUKdrME= X-Gm-Gg: ATEYQzwcvOMy+ztrFrAumRovmIbjpSU+/GkjcxXeo2mE1kOe87u3AYoKllrVvj6ofr5 aYi0qbigFHi71AY795d4RS7jMBKjrDhXFUUIit1rV9/Kn4JZIY5HPauQvPiVVtZ0lipIAPHj05U 8pstwk3NBmST/QMcZgT4cKGBkHHGxB9w6H085+M0XB5VyyDagvR2a+ilQ6Wfxu/Jlf52pxmYs79 oHuqeotEwoO2Da44yvmUYg+Hvkgm0WGWyphHNEtVpmRN/rMg4uHH7ObwN1ecg/1u+aRK6Vuq/CC wO39L+S39g9kv8o2Y/bJS/670wMic2+yt6aN3U0cc3IOqrL5v5eN0SRU8c7fwN30fBCSYS+LFHI Bg/ExIl1rJb71soz4kcSTD9Svl4T4RT9J1oZrnBDw8UsHv4wuYZytRRlKOp8FZsBlghKPlWlnBB 57YW6DE83O X-Received: by 2002:a05:622a:1993:b0:50b:2e8c:6ae0 with SMTP id d75a77b69052e-50ba38bc54dmr23120011cf.45.1774607269242; Fri, 27 Mar 2026 03:27:49 -0700 (PDT) X-Received: by 2002:a05:622a:1993:b0:50b:2e8c:6ae0 with SMTP id d75a77b69052e-50ba38bc54dmr23119721cf.45.1774607268757; Fri, 27 Mar 2026 03:27:48 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:b656:6dd8:ce4d:18d5? ([2a05:6e02:1041:c10:b656:6dd8:ce4d:18d5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48725fca5f2sm15199245e9.12.2026.03.27.03.27.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2026 03:27:48 -0700 (PDT) Message-ID: <3f7c9daa-ebf6-4871-8496-0e080afc3322@oss.qualcomm.com> Date: Fri, 27 Mar 2026 11:27:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] thermal: fix error condition for reading st,thermal-flags To: Gopi Krishna Menon , rafael@kernel.org, daniel.lezcano@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com Cc: daniel.baluta@nxp.com, simona.toaca@nxp.com, d-gole@ti.com, m-chawdhry@ti.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260327090526.59330-1-krishnagopi487@gmail.com> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <20260327090526.59330-1-krishnagopi487@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 4nVuSoKFSXtP0uycqkFHhGJNvCCoXKBR X-Proofpoint-ORIG-GUID: 4nVuSoKFSXtP0uycqkFHhGJNvCCoXKBR X-Authority-Analysis: v=2.4 cv=J4GnLQnS c=1 sm=1 tr=0 ts=69c65ba6 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=7CQSdrXTAAAA:8 a=8AirrxEcAAAA:8 a=pGLkceISAAAA:8 a=EUd0EORqmQtM46NuxkEA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=a-qgeE7W1pNrGK8U0ZQC:22 a=ST-jHhOKWsTCqRlWije3:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI3MDA3NSBTYWx0ZWRfXzw3/mCFoslsA +i47OjUPpMe73bOoZZ6D/c3Q6FntIp5UNP+eo+Amn0Md+QiRGvN4bqYXMp9U9H4wOpLSlDaVbpT 2kbsjzIfcOF7XiUxGdooet5rbkJnvZOYfM4vp5pAJs+kfe9Eq8Xcy0hIVsI1wzLYwCA8MrSevA5 hx5rmi9htZLEjvcXhCukcpPbyzJUeiCPA6RggwOtC0GYdbyQRgj761l8vVvq6BblAx+s22Kqtjf 4StfjnWYtSlgpy+HnSKfm+vvA1KDklw8CQSP5L7BAu17pp67g4DF9TcCfZgdFKKJzl0PhSPKcbT q1khiRBKYdiLAVl4o+KzkzPYw6hqECJnFhRfQRPfQQAmW3jD3G30RgtQ9XNhB+TkLXRBx9DxmEh 4fWwEsWosK6DoBpPagyvgNYCn5OMO9N3Iee1aJFVFNEUW3QXt20x4DrXOr5xvBRjhGAgzhXRM5o /bKlwBGuH3d6zExfOqQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_04,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 phishscore=0 impostorscore=0 bulkscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270075 On 3/27/26 10:05, Gopi Krishna Menon wrote: > of_property_read_u32 returns 0 on success. The current check returns > -EINVAL if the property is read successfully. > > Fix the check by removing ! from of_property_read_u32 > > Fixes: b9c7aff481f1 ("drivers/thermal/spear_thermal.c: add Device Tree probing capability") > Reviewed-by: Lukasz Luba > Suggested-by: Daniel Baluta > Signed-off-by: Gopi Krishna Menon > --- > Changes since v1: > - Add Fixes and Reviewed-by tags Applied, thanks