mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcos Del Sol Vives <marcos@orca.pet>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-kernel@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH] gpio: vortex86: add new GPIO device driver
Date: Mon, 7 Jul 2025 16:49:44 +0200	[thread overview]
Message-ID: <3f80b31d-855c-4591-9237-272895165f13@orca.pet> (raw)
In-Reply-To: <CAMRc=Me5dfNFLS1qF0AWgg8sb_vk9J=d-JV3-C5xWv7pZM+sFg@mail.gmail.com>

El 07/07/2025 a las 16:10, Bartosz Golaszewski escribió:
> Hi!
> 
> This patch immediately rings alarm bells in my head because the chip
> is not registered with the driver model. It's not 2005 anymore so I'd
> need some more explanation. IMO there's nothing that makes it
> impossible to implement this as a platform device. Could you elaborate
> more on why you chose to implement it this way?
> 
> Bart

Hi Bart!

This is my first time writing a driver in general, so the only reason is
that the drivers I used as a reference (gpio-it87 and gpio-winbond) look
more or less like this. I used those because they are fairly simple and
also use fixed x86 ports for control.

I see now on gpio-f7188x that it is possible to detect if the SoC matches
using platform_driver and platform_device. I guess that is what you were
referring to? Should I thus make a V2 patch using those facilities? 

Thanks,
Marcos

      reply	other threads:[~2025-07-07 14:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07 13:21 Marcos Del Sol Vives
2025-07-07 14:10 ` Bartosz Golaszewski
2025-07-07 14:49   ` Marcos Del Sol Vives [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f80b31d-855c-4591-9237-272895165f13@orca.pet \
    --to=marcos@orca.pet \
    --cc=brgl@bgdev.pl \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®