From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Alexandre Courbot <acourbot@chromium.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] venus: vdec: fix format enumeration
Date: Sat, 24 Mar 2018 01:54:18 +0200 [thread overview]
Message-ID: <3f82e52d-7e5e-4184-ea36-e76d924ab00c@linaro.org> (raw)
In-Reply-To: <35d51db4-bbca-e76a-abff-ed74172a5fe2@linaro.org>
Hi Hans,
Could you take this patch it not too late.
On 20.03.2018 15:42, Stanimir Varbanov wrote:
> Hi Alex,
>
> Thanks!
>
> On 03/19/2018 11:32 AM, Alexandre Courbot wrote:
>> find_format_by_index() stops enumerating formats as soon as the index
>> matches, and returns NULL if venus_helper_check_codec() finds out that
>> the format is not supported. This prevents formats to be properly
>> enumerated if a non-supported format is present, as the enumeration will
>> end with it.
>>
>> Fix this by moving the call to venus_helper_check_codec() into the loop,
>> and keep enumerating when it fails.
>>
>> Fixes: 29f0133ec6 media: venus: use helper function to check supported codecs
>>
>> Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
>> ---
>> drivers/media/platform/qcom/venus/vdec.c | 13 +++++++------
>> drivers/media/platform/qcom/venus/venc.c | 13 +++++++------
>> 2 files changed, 14 insertions(+), 12 deletions(-)
>
> Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>
regards,
Stan
prev parent reply other threads:[~2018-03-23 23:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 9:32 Alexandre Courbot
2018-03-20 13:42 ` Stanimir Varbanov
2018-03-23 23:54 ` Stanimir Varbanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f82e52d-7e5e-4184-ea36-e76d924ab00c@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=acourbot@chromium.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome