From: bot+bpf-ci@kernel.org
To: dennylin0707@gmail.com,ast@kernel.org,bpf@vger.kernel.org
Cc: daniel@iogearbox.net,andrii@kernel.org,eddyz87@gmail.com,ihor.solodrai@linux.dev,iii@linux.ibm.com,bjorn@kernel.org,pulehui@huawei.com,linux-kselftest@vger.kernel.org,linux-kernel@vger.kernel.org,dennylin0707@gmail.com,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,mason@kernel.org,ihor.solodrai@linux.dev
Subject: Re: [PATCH bpf-next] selftests/bpf: Account for zero extensions in patch list expectations
Date: Tue, 3 Nov 2026 22:30:56 +0000 (UTC) [thread overview]
Message-ID: <3f89e3df5173e081e45425852c59a5a32cc979ee67c37ab53cd563da24a98572@mail.kernel.org> (raw)
In-Reply-To: <20261103215309.19950-1-dennylin0707@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1856 bytes --]
> selftests/bpf: Account for zero extensions in patch list expectations
TL;DR: Commit message only: the Fixes: tag names a merge commit rather than
the commit that introduced patch_list_insert_in_front(), and it lacks a
preceding blank line.
> selftests/bpf: Account for zero extensions in patch list expectations
>
> patch_list_insert_in_front() checks the translated instructions around
> the call of an inlined bpf_loop() and its callback. On s390, the verifier
> adds zero extensions after the two 32-bit register writes in the loop.
> The call is therefore at instruction 25 rather than 23, and the later
> instructions checked by the test are also shifted by two. The test
> fails despite the call and jump offsets being correct.
> Use the corresponding instruction indices on s390 and RISC-V, whose
> JITs request explicit zero extensions. Keep the original expectations
> for the other enabled architectures and retain all branch offset and
> callback entry checks.
> Fixes: 57fae4059380 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf 7.4-rc1")
> Link: https://github.com/kernel-patches/bpf/actions/runs/41696128762/job/126138168160
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
The Fixes: tag names 57fae4059380, which is a merge commit. Should it name
the commit that introduced patch_list_insert_in_front() instead?
Fixes: d86e6695cb2f ("selftests/bpf: Test the tables that follow patched and removed instructions")
Also, the Fixes: line follows the body paragraph directly. Could a blank
line be added between them?
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/41728315768
next prev parent reply other threads:[~2026-11-03 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 21:53 Hungyu Lin
2026-11-03 22:30 ` bot+bpf-ci [this message]
2026-11-04 0:44 ` Alexei Starovoitov
2026-11-04 0:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f89e3df5173e081e45425852c59a5a32cc979ee67c37ab53cd563da24a98572@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dennylin0707@gmail.com \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=iii@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=mason@kernel.org \
--cc=pulehui@huawei.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®