From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 846C83E7172 for ; Fri, 10 Jul 2026 08:03:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783670607; cv=none; b=Rxgtrtk7SwMmo/igUyQL/GTiR4qf0TZGDvti1c6uzRQrsc8AApr6NeHqhfklu2XR5cKN9kelKstMKml7oSWIAOu1Di+9ykc7cjErVvPTk4niYK+57PxuebC6OWouW6ZrSPjEMUrY3AHF4Kl5YZBQECu9ahVzzuyl3JbZ4sqr8Y0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783670607; c=relaxed/simple; bh=ViUn+uiCJZsRa84IMRr8/kyysPo9FWpX7B0SgkVTbkU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i1TAR+wTjCj8tmfTf00u9QHd3FyfVE5/QwM3/kMK0fdMTE4a89bokWLR9mId/TNW8f+S3RfAJPNme4wmaCyO+nefBpUn7Zillw220Mg4sPooWPaJ3wYGsOc1A8bKmsY8A/vtkz8iTvGOriYAIVjdmyhSHyxjKIRPRWLXf56LjDE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XjrkTx//; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=D11oupqA; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XjrkTx//"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="D11oupqA" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66A7eHXh141506 for ; Fri, 10 Jul 2026 08:03:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ap9hHDubMVCMsfg7cGTWsN/PZnCJfGCkkJHZ64FkGVU=; b=XjrkTx//8jIWJS9y lM+/LQmLTmT3ouZ77LSTFFa8Fvcvfhj0GCwVIKEHyp+BDzVaVe++gqcHd1f9aiOq RlRRCc8kvZ4DEJSTGT6PGSj6fcZAEv7Wb4llLhpBJDpg4/ewoT2w3IXgMK8axCsw vDey1eK+YMU14awAgdJ6jY5tcBGrdrfok9mxjMcq61tSsdtBaZ4tbF2aegj+L0re ldCS3qoJJFcPVHOmLgbP+WwPtP6zbnCh0+0x0dCc8nJqZtVrt2DJuB1QNF9k5X54 Ijp0XVGVwVQ7OY3Nz8O0qO74db6+wuZbLWbcMC1nJmQJbLGtOi6TYYGrvrZ2wKYS z3nmiQ== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4faf5mu6mm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 08:03:21 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c88aab7c1fcso1204248a12.3 for ; Fri, 10 Jul 2026 01:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783670600; x=1784275400; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ap9hHDubMVCMsfg7cGTWsN/PZnCJfGCkkJHZ64FkGVU=; b=D11oupqAlik32McWOMg+fq+Ja/cyMP6d8fqWWlcth67+nL+MXCNpOIsLq2ufHTQhAP gHjTMPRI2551XOvs6eyTHXAIPR6qVYdgRko+CI95KnP1m+t1J/5M7xOOwPadbO610Y8y F0bBX/mZgt5pc8p/pf85rVJVjo9aCWBCW+iYHHCgd3PKedwp2ss2mi+vk4yMXkw+bI8J sC6GoEgafTNoQQM0ehMJYMZJAVAXeWpNjhpWUnYnTQ9U7WJBysBd5DAw2DY980z4y9rM LzUpETyIAwIzpbqHmk68KilkrOZ1XFb6YD0KFVBEHoi+oeyhW4Uw+EV3PT2OzpO8zaWR MCmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783670600; x=1784275400; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ap9hHDubMVCMsfg7cGTWsN/PZnCJfGCkkJHZ64FkGVU=; b=oIWeqbhpb07u+GNkBz4jA1v19HijbRXBSBamkK8OS9iSIo1x9syp4DlAcx+VpbRbzc igNhay8x0Y2fZnb6u34J6qFffFMqabGqbk9TY5qzyCedh3MjGyqSXkZXQwp+7m/cNFy4 X46adUAXDnh5V/2UowypwZqJzDYMGu4v0kZ8jxlEvCurzyfhWsT+0XyG4dLNTOlwtH8z 1qMGsnT4aYx65JoM3N9FBBUWSqcKW8EHFMSoVRNgbtcHNyjB0kb7gh7IGGgMrYIis0mp /VqbykqimWvkr4IGASpMeklFZRgXlRsEEIyNs8XOF3A819eq1/1d78qGEBKxzDl+gRgK nWpA== X-Forwarded-Encrypted: i=1; AHgh+Rq6P8broK26/KvwN7P44drSHys8lj21Uc5dAxdvx/BWGfcTKm2ekQ7ZgwAMvSvm8vM11Emmy4oZGRCRj1g=@vger.kernel.org X-Gm-Message-State: AOJu0YziSiZ+PFo5KiqKvRimCppIXvSY9S4k+cQR9NzM58MHAhIPbh6Z YIADdiPK1+FIwHc4pxajZeDdm2BngdYjK+tReIRnCF129s5ncrcxhzH2YqzaXgQ5+Tfl4tRWy/S HGIxwubhdtYgLjBfJp0kOkqTiqmage1qAprOa/S4uwkPZs1hlWsUuH4wU11MhIuV1PQc= X-Gm-Gg: AfdE7ckZv5AyfmjozihZvOsujfuO+bgRlxPyMk+HBeCfZ42Jn2SVvWu3Omaq/H+bu4f hDRyoUccA8wpAfh0p3s5bQi+5Qqh4s7rL5pcaaj8ps7d+UzKrf86dyL6zv1TrhKu7l4f+g9VQTR GXjlkS7XpWEJmY9YGsrdGVxbkTxjygRW+WyZHLbHLOTNtD68LrnlNML+fWAoqaFjdix2q4SVRf3 DTNFYdShhXpY9UalzvPqSQ41fLjjrkUjl7xZ9l+X/p3SJSnmDAsk2uRq0wCJnWR4jPEF8lLT8l2 5wpqMalAocWMOHD07JjLkIMmdPfaGrW01VE8R1hGzh5ktUfmy9gJBxHBGQm18TxgIOlF5mfO2B2 1Lw2OvmdvK0hN0ZJjabsHtgFtT9em2PQbmXKDxQtfhr8zHR0QMoeb4Eq8vu1LiutuCx6y9/S17h Ij X-Received: by 2002:a05:6a20:3d94:b0:39b:ba95:b14c with SMTP id adf61e73a8af0-3c0bceccfabmr12625905637.24.1783670600510; Fri, 10 Jul 2026 01:03:20 -0700 (PDT) X-Received: by 2002:a05:6a20:3d94:b0:39b:ba95:b14c with SMTP id adf61e73a8af0-3c0bceccfabmr12625864637.24.1783670600014; Fri, 10 Jul 2026 01:03:20 -0700 (PDT) Received: from [10.133.33.242] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643ecdsm4926620a12.24.2026.07.10.01.03.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 01:03:18 -0700 (PDT) Message-ID: <3f8a74b0-1f0b-41de-af64-03cb6e983a04@oss.qualcomm.com> Date: Fri, 10 Jul 2026 16:03:13 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] coresight: Fix clock refcount imbalance on platform remove To: Leo Yan Cc: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Anshuman Khandual , Yeoreum Yun , Yuanfang Zhang , Maxime Coquelin , Alexandre Torgue , Tingwei Zhang , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20260702-fix-clock-refcount-unbalance-v2-0-2383fbb9952e@oss.qualcomm.com> <20260702-fix-clock-refcount-unbalance-v2-1-2383fbb9952e@oss.qualcomm.com> <20260709152410.GE1024232@e132581.arm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20260709152410.GE1024232@e132581.arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: yG0zQ9bk64BeTL588eQK4F5b4sl3zGSo X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDA3NyBTYWx0ZWRfX+6FDwrphuPvN 3ISyhZNht65r3yJ5EFwrjUwdN+NklH7Hd8gvl9Mv+nvWZcYyp6oOg6LCCol5DrCyM7E0NyHvjsn jSUPzgHt+f/uAA+JM3YLueS4xI1SF5U= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDA3NyBTYWx0ZWRfX0Cn28ZafojHO /khUsINnZPqUCcKYs4k5wS3gycwOWc3Oq0FZohOcCpM7EBzx8IQSaD6w23Hl9B+JFAngnkGB41I K/tMj8xrXjnluZzWd33EnAYOI2MMR21qKlj8VeGluUonnpVXW/pnhbNlgE5Vxl3LYr3Z8Oy5TfP GYM2FArSppzVD7+IqsmOS1HCSVyk95E4wP21LWZT61emj5DEAXpEQZFDAAbcLhfS8oy1PR7ntNl SL/+gkDsrht0wcnJBsVLrIRq3AbjJ935BqtKXiAjSttdBDvP+seshMidNBsbgLJ7iy/gSOaFhiP CsTB8+zi1upx2uRkfp/U0zr0q0PyUdk+7PkiMvA67IOrZ7oNPKI8ewrPbH5OOvbE1agKF5Fu9WI GHtMWuJFynBS44toKe4hup1xDhCHvvodTg1OWwyvZfO+6DGfjU3//qG6nBnH9RmSyP/bH6OqTUX 1C5ZMc+UosCiaX0xOfw== X-Proofpoint-GUID: yG0zQ9bk64BeTL588eQK4F5b4sl3zGSo X-Authority-Analysis: v=2.4 cv=N+QZ0W9B c=1 sm=1 tr=0 ts=6a50a749 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=7CQSdrXTAAAA:8 a=d1ZDJawjCgYNIZ84EkIA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_02,2026-07-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 priorityscore=1501 phishscore=0 adultscore=0 suspectscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100077 On 7/9/2026 11:24 PM, Leo Yan wrote: > On Thu, Jul 02, 2026 at 04:54:19PM +0800, Jie Gan wrote: > > [...] > >> static void etm4_remove_platform_dev(struct platform_device *pdev) >> { >> struct etmv4_drvdata *drvdata = dev_get_drvdata(&pdev->dev); >> >> if (drvdata) >> etm4_remove_dev(drvdata); > > I understood this is not an issue caused by this patch, could you refine > a bit as blow so can be consistent: > > if (WARN_ON(!drvdata)) > return; > >> + /* >> + * Resume the device so its clocks are enabled again, balancing the >> + * clk_disable_unprepare() that devm runs when the driver detaches. >> + * Then mark it suspended and drop the usage count taken here. >> + */ >> + pm_runtime_get_sync(&pdev->dev); > > etm4_remove_dev(drvdata); > >> pm_runtime_disable(&pdev->dev); >> + pm_runtime_set_suspended(&pdev->dev); >> + pm_runtime_put_noidle(&pdev->dev); >> } > > With above change: Fixed and sent new version. Thanks, Jie > > Reviewed-by: Leo Yan