From: Randy Dunlap <rdunlap@infradead.org>
To: David Yang <mmyangfl@gmail.com>, linux-crypto@vger.kernel.org
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] crypto: engine - Fix struct crypto_engine_op doc
Date: Sun, 23 Apr 2023 18:25:33 -0700 [thread overview]
Message-ID: <3f8ba0cc-5665-916d-b211-b2d5d6e952f4@infradead.org> (raw)
In-Reply-To: <20230424002925.2740296-1-mmyangfl@gmail.com>
Hi,
On 4/23/23 17:29, David Yang wrote:
> Remove redundant underscore and fix some grammar in prepare_request doc.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
No, I didn't report this issue. You either found it on your own or someone/something
else reported it.
> Link: https://lore.kernel.org/r/b58dc77c-c975-46cf-581c-368d9a87ae64@infradead.org
Also drop the Link: line.
> Signed-off-by: David Yang <mmyangfl@gmail.com>
> ---
> include/crypto/engine.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/crypto/engine.h b/include/crypto/engine.h
> index ae133e98d813..2038764b30c2 100644
> --- a/include/crypto/engine.h
> +++ b/include/crypto/engine.h
> @@ -78,7 +78,7 @@ struct crypto_engine {
>
> /*
> * struct crypto_engine_op - crypto hardware engine operations
> - * @prepare__request: do some prepare if need before handle the current request
> + * @prepare_request: do some preparation if needed before handling the current request
That part looks good.
> * @unprepare_request: undo any work done by prepare_request()
> * @do_one_request: do encryption for current request
> */
--
~Randy
prev parent reply other threads:[~2023-04-24 1:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 0:29 David Yang
2023-04-24 1:25 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f8ba0cc-5665-916d-b211-b2d5d6e952f4@infradead.org \
--to=rdunlap@infradead.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmyangfl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®