From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1F92C433FE for ; Fri, 11 Feb 2022 17:29:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352131AbiBKR32 (ORCPT ); Fri, 11 Feb 2022 12:29:28 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:47722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348138AbiBKR3Z (ORCPT ); Fri, 11 Feb 2022 12:29:25 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AAB5C2C3 for ; Fri, 11 Feb 2022 09:29:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644600562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fJwoEUodOxqJxI6JQu9HVJf3q8mKU8ZP5xXQX7JvN34=; b=KERomP3JuBY93UD9qPoExJf5iDzt9bBCoiGxPywHpDOgZVgrpKKW+y0svxICAQ72UJw9Uv 9O4WZghIVQKtjf24N0n2VpncaCkxQ1SKmAz9+WzDK13HtkTqsuoypY2Qrd9jmnHDVmZnX9 wMs8rKUWgG4EsYoVfRj9RISN8EDV7mo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-78-INMAVaueOAqLpsL_hFPvsQ-1; Fri, 11 Feb 2022 12:29:21 -0500 X-MC-Unique: INMAVaueOAqLpsL_hFPvsQ-1 Received: by mail-wm1-f69.google.com with SMTP id be14-20020a05600c1e8e00b0037c2a7b3ab6so957630wmb.9 for ; Fri, 11 Feb 2022 09:29:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=fJwoEUodOxqJxI6JQu9HVJf3q8mKU8ZP5xXQX7JvN34=; b=V0y0THNhT5fdv4eNsQvqdZP+vat5LUCuD18iGmHrUpY2DvPI7Vf/7EujtWXvCj1qww Q/D8zIdhtQmKESfi07DOmTNy/8k70xX5MmkC6w6gnM2q04nnRlQTzhE47mHTfwBTnb9I wwfkO+B5Dpgk0or/JoVycaUUeshTdsdIbLpQ0HklJcLxYyY8X96NVGx6SvV6nkxOfm6x JFy5t4l9xS+dYlBDDPX6aPvcty0jrFyourG5HjfYj+i6S9v2o/3Of+MUPT+R/B6AxbZf sxtNkq7YURgbEhCiwrIpGgjMCufOLUjd9lag++7YT4bb6yOgnitmdn7T0pBp0WUIwSEK f+9Q== X-Gm-Message-State: AOAM530uKOW0SKPIvEHySuo3dq1rM+cvmTKkjxLlHAd8ip19NT+uVUcw rI1j8qXP3pVSlCCMrWq/aK+l70FCubg2gx/C2X2XuhaLvw/a/wlCMHhDCgHFfYK2UjxSeLt0PLQ /1Yn2EbkOYJ7PuTvmfSS+1Yfd X-Received: by 2002:adf:f9ca:: with SMTP id w10mr2228489wrr.190.1644600560229; Fri, 11 Feb 2022 09:29:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7p0FZpxIDDsgFffzaBDj6oFCNLkazIuT0L/L4KWvjnftItejXB/GIXaQlFVoH1z3tOSTE4g== X-Received: by 2002:adf:f9ca:: with SMTP id w10mr2228479wrr.190.1644600560059; Fri, 11 Feb 2022 09:29:20 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.googlemail.com with ESMTPSA id j30sm1936734wms.2.2022.02.11.09.29.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Feb 2022 09:29:19 -0800 (PST) Message-ID: <3f8e8e3d-8bd7-dfd4-f4a0-63520d817c10@redhat.com> Date: Fri, 11 Feb 2022 18:28:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 3/3] KVM: SVM: fix race between interrupt delivery and AVIC inhibition Content-Language: en-US To: Sean Christopherson Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, mlevitsk@redhat.com References: <20220211110117.2764381-1-pbonzini@redhat.com> <20220211110117.2764381-4-pbonzini@redhat.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/22 18:11, Sean Christopherson wrote: >> + /* Process the interrupt with a vmexit. */ > > Double spaces at the end. But I would prefer we omit the comment entirely, > there is no guarantee the vCPU is in the guest or even running. Sure, or perhaps "process the interrupt in inject_pending_event". Regarding the two spaces, it used to a pretty strict rule in the US with typewriters. It helps readability of monospaced fonts (https://www.cultofpedagogy.com/two-spaces-after-period/), and code is mostly monospaced... But well, the title of the article says it all. Paolo