From: Sarthak Sharma <sarthak.sharma@arm.com>
To: John Hubbard <jhubbard@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>, Peter Xu <peterx@redhat.com>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] selftests/mm: rewrite gup_test as a standalone harness-based selftest
Date: Mon, 18 May 2026 11:40:13 +0530 [thread overview]
Message-ID: <3f92ed55-a2d2-4f14-9b75-2b218d3e53e1@arm.com> (raw)
In-Reply-To: <c99048de-1e2a-4c92-8589-0abba45bcc29@nvidia.com>
Hi John!
On 5/16/26 2:03 AM, John Hubbard wrote:
> On 5/15/26 1:48 AM, Sarthak Sharma wrote:
>> Rewrite gup_test.c using kselftest_harness.h. The new test uses
>> FIXTURE_VARIANT to cover seven configurations (private/shared,
>> read/write, THP, hugetlb) and runs four test cases per variant
>> (GUP_BASIC_TEST, PIN_BASIC_TEST, DUMP_USER_PAGES_TEST with get and
>> pin), giving 28 TAP-reported cases in total without requiring any
>> command-line arguments.
>>
>> Update run_vmtests.sh: remove run_gup_matrix() and the multiple flagged
>> invocations of gup_test, replacing them with a single unconditional
>> invocation. Benchmark functionality is handled by tools/mm/gup_bench
>> introduced in the previous patch.
>
> Hi Sarthak,
>
> Looks like sashiko has a few good observations, these are
> worth considering IMHO:
>
>
> https://sashiko.dev/#/patchset/20260515084840.174652-1-
> sarthak.sharma@arm.com
>
> thanks,
Yes, the observations are valid. I will address them and send out a v2.
next prev parent reply other threads:[~2026-05-18 6:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 8:48 [PATCH 0/2] selftests/mm: separate GUP benchmarking from functional testing Sarthak Sharma
2026-05-15 8:48 ` [PATCH 1/2] tools/mm: add a standalone GUP microbenchmark Sarthak Sharma
2026-05-15 8:48 ` [PATCH 2/2] selftests/mm: rewrite gup_test as a standalone harness-based selftest Sarthak Sharma
2026-05-15 20:33 ` John Hubbard
2026-05-18 6:10 ` Sarthak Sharma [this message]
2026-05-18 15:40 ` David Hildenbrand (Arm)
2026-05-19 4:45 ` Sarthak Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f92ed55-a2d2-4f14-9b75-2b218d3e53e1@arm.com \
--to=sarthak.sharma@arm.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®