From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B06403E1222 for ; Tue, 31 Mar 2026 12:31:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774960275; cv=none; b=dJ4qULfVBiwjvGYEPbCuR45YxxS50Vu+/h9QKGaIjMhV1FdIHgn5QdcBH5oi4N+3ClzsmzzzmtdxZR8BbLZpTsVLKRIr5o/rjS+St40K0pVkX2187NgNNs8HDWlDq+UlOBfRl1/uZyRXAkE775rTK+LwcLRztOj1o5PzA8GK4eo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774960275; c=relaxed/simple; bh=7CuDpe2wlh2ZFuYPuQwq6yR4eJTk1K6GjF5gvydHqtI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SEQ4aOTVrezpFeua+NZgOgLMjvP7opzAJV+cIKfAtYiehlyAKU0K8SnAeinW5/Ev2YNaXLmh5/BtXReOGRIaI8ohgO/xeIOf58dlzkD1d56mPovZARhfapCZAZ6+Aiw5ysiUVg7JdMHe8tit5HEtFxo3rQZjUCJOtq44PR1Sqv8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UPGQZ/ES; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=e0rOitiO; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UPGQZ/ES"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="e0rOitiO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774960272; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qywi7ozJpAOVApe14ykhQ23+WXfQ13sP2QxoRhqseiw=; b=UPGQZ/ESoFJRYnnN4Z8kJwShpB+kEOELljgNPf4xlLxBd2RYvhPDRuc21EW3Syw9EeesXt ej0a8/fQ2FT0HuRtcwsAdy5+Ydf97orEnsF2ZBbX2e750nAKfBjuBxa/X07FNRS0OrxbDb UgmjcGRmcq+/zh7+8sunU+c/O/eQDZU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-NJZjAIYtMluY2tJaV6iFZQ-1; Tue, 31 Mar 2026 08:31:11 -0400 X-MC-Unique: NJZjAIYtMluY2tJaV6iFZQ-1 X-Mimecast-MFC-AGG-ID: NJZjAIYtMluY2tJaV6iFZQ_1774960270 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4853466655dso38583015e9.3 for ; Tue, 31 Mar 2026 05:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774960269; x=1775565069; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Qywi7ozJpAOVApe14ykhQ23+WXfQ13sP2QxoRhqseiw=; b=e0rOitiO/Zp9B4F7vX6EE9mhglrpq/Y1fAZze09cjVZ1kjqeKyzpZ7l7oT/7BDdRh1 +dUUhjA1d6odFBP5N7KTTcH8FQnLHO5U26gto6/gTt3SGzOC/h8ORUk0UWp3Al/bsVW6 TpsUr8xYxz3VQ4qpEZNRtTVHroTurV6Uutfoy1OWC/rHKfh50eEVuqH/UcJ0L31et1x8 gp6gRbl2McoUZBvM/ZZ5qPN8JX3vB4ONLd+orKROs5aY0aNEjx5240s4g6WsYWlArwQX FP8BN/9HyY80GWhdeIDSx287csQUPJQCYPi/60bMvISB8Bf2liHKi7uqlTu0REj5rRws /eDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774960269; x=1775565069; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qywi7ozJpAOVApe14ykhQ23+WXfQ13sP2QxoRhqseiw=; b=MaPB5pcDPd1uRFALIIrCvC8EiP4WL+nKxlHsWYGCDoOQ5KZ6uQHqcaRKmPOHbisdhj Sb7onxdJWGHEZh5RL3aldy0OIdr5A2LmMUTMNvugTDp0lbwkHh3kdD3z6dVrJ+Q8mEyw q/PIGqOHAMfi4cBq4m4dY7iy7BMW+AQ/WzbrNQNbpHDMYqL34uSKPSMMosLciZeuv4Ry 56EheU3yWz6rtqKqByjlDrInUMxVQcWSZMco3h9yDHMZMXFqy81KlLJh1A0e7aBb1v9N sHAVAHFjsJdQxdFOjtCq1eYTVkNT3QXaEFBxUyfsOgTelLNPtLJ7uGl0Py2CoJamhhZl dCiA== X-Forwarded-Encrypted: i=1; AJvYcCUruwv6G79gdcLNNIxyoCAUMoBFKnute10T+MG+U41jv3RK8pFTqUM1oiKuPUkmbyskL9iQ/Mg+D0nsuSc=@vger.kernel.org X-Gm-Message-State: AOJu0YykjkE6H/R7uC8cuV6T788HmfEq3rkJYnq9NurK8qxaWERUybjr prIVRVEjUaLiGhSVnkBASxzxeovTd/g+57z0XA7/sF1SJzWUO1LYryrz1y5/JVBHOuAaSzo8xGm pv4tZHtXwBu6mNBmkip5OZV3i7SxzXbS2KuLKL5C6IfXc1JwspMlPhe3yt7AsmE+ZGEztR0xJuA == X-Gm-Gg: ATEYQzwmsfNgsH3oV6VotFX9Fc3cZ8kINCXNu7X8IPc/q7NSC/CKxlZ3k/XVR63ZpIn 69h3KM97F4i3QB8vv1b+llt998fjE4WqTKWSEgikErAGkQpccOuxBw8CRYLCkrZU4H9QNgJwgTy TKaW3ic785nlsGdT/QrWTxsMyNd4D1RGLkR4H6cGUY04Y88r1K9yv36oI0pltUj5Lr673Y5YRmv BJeK6t89TF240u76vPTbirBpMYvD53UEWGt0eqfLNf1HcyMAjMHJ2PCaPRQcMxlMsbf/+lReuDn bJxCtOeQpXTeF6L5BGvWcLN1WdZDwLjtjSnIluPxUEQmiVAYEdYuWfGW3iKFMa+Zbup/ydqT03G GmpTME7dLsmHFd4a5rAnzhRcLbvgo++z638r1kjqK54JXJP+09JXu71jpwv7rUw== X-Received: by 2002:a05:600c:160a:b0:486:d76c:fa21 with SMTP id 5b1f17b1804b1-48735166d0amr108920305e9.12.1774960269478; Tue, 31 Mar 2026 05:31:09 -0700 (PDT) X-Received: by 2002:a05:600c:160a:b0:486:d76c:fa21 with SMTP id 5b1f17b1804b1-48735166d0amr108919845e9.12.1774960268956; Tue, 31 Mar 2026 05:31:08 -0700 (PDT) Received: from ?IPV6:2a01:e0a:c:37e0:8998:e0cf:68cc:1b62? ([2a01:e0a:c:37e0:8998:e0cf:68cc:1b62]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e82e262sm34244735e9.10.2026.03.31.05.31.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 05:31:08 -0700 (PDT) Message-ID: <3f9664d0-2252-4dc1-ab3d-03193fa9764f@redhat.com> Date: Tue, 31 Mar 2026 14:31:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/panic: Fix panic logo alignment To: Dileep Sankhla , Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260329102454.11357-1-dileepsankhla.ds@gmail.com> Content-Language: en-US, fr From: Jocelyn Falempe In-Reply-To: <20260329102454.11357-1-dileepsankhla.ds@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29/03/2026 12:24, Dileep Sankhla wrote: > Display the panic logo at the top center of the screen when > drm_panic_type is set to DRM_PANIC_TYPE_USER to keep the layout > properly aligned. Hi, I think this is more a preference, than a fix. At boot the logo is at the top left corner, and I choose to let it at the same place. Additionally, on low resolution (like 800x600) the logo has less chance to overlap the text, so the user is more likely to see it. Best regards, -- Jocelyn > > Signed-off-by: Dileep Sankhla > --- > drivers/gpu/drm/drm_panic.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.c > index d6d3b8d85dea..c7fecc5e857a 100644 > --- a/drivers/gpu/drm/drm_panic.c > +++ b/drivers/gpu/drm/drm_panic.c > @@ -491,6 +491,8 @@ static void draw_panic_screen_user(struct drm_scanout_buffer *sb) > > r_screen = DRM_RECT_INIT(0, 0, sb->width, sb->height); > drm_panic_logo_rect(&r_logo, font); > + /* Center the panic logo */ > + drm_rect_translate(&r_logo, (sb->width - r_logo.x2) / 2, 0); > > msg_width = min(get_max_line_len(panic_msg, panic_msg_lines) * font->width, sb->width); > msg_height = min(panic_msg_lines * font->height, sb->height);