mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jaswinder Singh Rajput" <jaswinderlinux@gmail.com>
To: "Mike Travis" <travis@sgi.com>
Cc: "Jaswinder Singh Rajput" <jaswinder@infradead.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Rusty Russell" <rusty@rustcorp.com.au>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Jack Steiner" <steiner@sgi.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 04/11] x86: cleanup remaining cpumask_t ops in smpboot code
Date: Tue, 6 Jan 2009 19:58:13 +0530	[thread overview]
Message-ID: <3f9a31f40901060628t3bffe020v6e70c5d6cf17f51e@mail.gmail.com> (raw)
In-Reply-To: <4963645A.1040201@sgi.com>

Hi Mike,

On Tue, Jan 6, 2009 at 7:32 PM, Mike Travis <travis@sgi.com> wrote:
>
> I'll look closer but I had assumed that these masks would not be
> used for UP configurations (it did not get any compile errors
> with the allnoconfig).  In fact, any access to these masks for
> UP would be unnecessary since there are no callouts, the boot
> cpu is assumed initialized, and it has no siblings.  So the
> masks are specific to SMP.
>

If it is specific to SMP then:
CONFIG_X86_64 should be CONFIG_X86_64_SMP
CONFIG_X86_32 should be CONFIG_X86_32_SMP

I am in the process of cleaning smp.h and moving out non-smp from
smp.h as per Ingo's suggestion.

I am planning to move cpumask related things to asm/cpumask.h

Is this OK to you.

--
JSR

  reply	other threads:[~2009-01-06 14:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1231222512.3235.6.camel@jaswinder.satnam>
2009-01-06  6:31 ` Jaswinder Singh Rajput
2009-01-06 14:02   ` Mike Travis
2009-01-06 14:28     ` Jaswinder Singh Rajput [this message]
2009-01-06 15:25       ` Mike Travis
2009-01-04 13:17 [PATCH 00/11] x86: cpumask: some more cpumask cleanups Mike Travis
2009-01-04 13:18 ` [PATCH 04/11] x86: cleanup remaining cpumask_t ops in smpboot code Mike Travis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f9a31f40901060628t3bffe020v6e70c5d6cf17f51e@mail.gmail.com \
    --to=jaswinderlinux@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jaswinder@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=steiner@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=travis@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®