From: Jaswinder Singh Rajput <jaswinderlinux@gmail.com>
To: Hans de Goede <j.w.r.degoede@hhs.nl>
Cc: George Joseph <George.joseph@fairview5.com>,
lm-sensors@lm-sensors.org, Jean Delvare <khali@linux-fr.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [lm-sensors] Status of Andigilog asc7621 driver submitted by George Joseph on 2008-05-29
Date: Sun, 24 Jan 2010 10:35:45 +0530 [thread overview]
Message-ID: <3f9a31f41001232105l58d36ffdp8d06231f524a98ec@mail.gmail.com> (raw)
In-Reply-To: <4B5B38C1.5080109@hhs.nl>
Hello Hans,
On Sat, Jan 23, 2010 at 11:28 PM, Hans de Goede <j.w.r.degoede@hhs.nl> wrote:
> Hi,
>
> On 01/23/2010 06:52 PM, Jaswinder Singh Rajput wrote:
>>
>> Andigilog asc7621 driver submitted by George Joseph on 2008-05-29,
>> This chip is used by various Intel Motherboards.
>>
>> Is it still under review and testing :
>>
>> http://lists.lm-sensors.org/pipermail/lm-sensors/2008-May/023257.html
>>
>> http://www.spinics.net/lists/lm-sensors/msg26915.html
>>
>> http://www.spinics.net/lists/lm-sensors/msg26916.html
>>
>> http://www.lm-sensors.org/wiki/Devices
>>
>
> I guess this is partly my fault, I started a review but never finished
> it. One of the big problems is that George did many things completely
> different to how every other single hwmon driver does things. Which made
> the review harder then necessary, and more over made me wonder if we
> should accept the driver in that incarnation at all.
>
George Joseph submitted the driver on 2008-05-29 and then he updated
the driver on 2009-10-15 for 2.6.30 and many developers are able to
test it and used it.
Are you able to compile the driver with latest kernel git.
> Then a lot of things happened and I never got around to doing anything
> with it at all.
>
Many new Intel Motherboards are coming with this chip, if we complete
this driver then it will be great.
> I just checked my Drafts folder, and I still have my unfinished review
> in there. So if there is interest I can send that, note that it is
> not a complete review though (there is a note in there which part
> of the code is reviewed and which still needs to be reviewed).
>
Please provide your review so that we can discuss about this driver
and make relevant changes to accept it.
Thank you,
--
Jaswinder Singh.
next prev parent reply other threads:[~2010-01-24 5:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 17:52 Jaswinder Singh Rajput
2010-01-23 17:58 ` [lm-sensors] " Hans de Goede
2010-01-24 5:05 ` Jaswinder Singh Rajput [this message]
2010-01-24 5:44 ` Constantine A. Murenin
2010-01-24 6:23 ` Jaswinder Singh Rajput
2010-01-24 7:58 ` Constantine A. Murenin
2010-01-26 11:55 ` Hans de Goede
2010-01-24 9:30 ` Jean Delvare
2010-01-24 12:14 ` Jaswinder Singh Rajput
2010-01-24 12:22 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f9a31f41001232105l58d36ffdp8d06231f524a98ec@mail.gmail.com \
--to=jaswinderlinux@gmail.com \
--cc=George.joseph@fairview5.com \
--cc=j.w.r.degoede@hhs.nl \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome