From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754055Ab2L1THp (ORCPT ); Fri, 28 Dec 2012 14:07:45 -0500 Received: from terminus.zytor.com ([198.137.202.10]:37703 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753711Ab2L1THm (ORCPT ); Fri, 28 Dec 2012 14:07:42 -0500 User-Agent: K-9 Mail for Android In-Reply-To: References: <1356712001-12198-1-git-send-email-jlee@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH 1/3] rtc-efi: register rtc-efi device when EFI enabled From: "H. Peter Anvin" Date: Fri, 28 Dec 2012 11:07:11 -0800 To: Matthew Garrett , "Lee, Chun-Yi" CC: "matt.fleming@intel.com" , "linux-kernel@vger.kernel.org" , "linux-efi@vger.kernel.org" , "Lee, Chun-Yi" , Thomas Gleixner , Ingo Molnar , Jan Beulich Message-ID: <3fa7337e-6bbc-4462-9704-2d8ac20a9cf2@email.android.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We do have such machines, which is why this change has been reverted twice already. I believe we should stick to the priority scheme I proposed a few weeks ago. Matthew Garrett wrote: >On Sat, 2012-12-29 at 00:26 +0800, Lee, Chun-Yi wrote: >> UEFI time services, GetTime(), SetTime(), GetWakeupTime(), >SetWakeupTime() are also >> supported by other non-IA64 architecutre with UEFI BIOS, e.g. x86. >> >> This patch changed RTC_DRV_EFI configuration to depend on EFI but not >just IA64. It >> checks efi_enabled flag and efi-rtc driver should enabled. > >In theory, certainly - but do we still have machines that explode if >the >get_time call is made? We may also want to think about disabling the >legacy access to the RTC if the EFI calls are present. -- Sent from my mobile phone. Please excuse brevity and lack of formatting.