From: Johannes Berg <johannes@sipsolutions.net>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, richard@nod.at
Cc: anton.ivanov@cambridgegreys.com, linux-um@lists.infradead.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] um: Use swap() instead of open coding it
Date: Wed, 22 Nov 2023 08:25:54 +0100 [thread overview]
Message-ID: <3fa7ec68a0302667f1b73682e4db96f6ba618397.camel@sipsolutions.net> (raw)
In-Reply-To: <20231122032518.53305-1-jiapeng.chong@linux.alibaba.com>
On Wed, 2023-11-22 at 11:25 +0800, Jiapeng Chong wrote:
> Swap is a function interface that provides exchange function. To avoid
> code duplication, we can use swap function.
>
> ./arch/um/os-Linux/sigio.c:81:28-29: WARNING opportunity for swap().
>
Hm. There's already a use of swap() here in this file, but I actually
think we should revert that? This is basically userspace code, not
kernel code, so I don't think it should include linux headers, even if
those happen to be "standalone enough" right now to work.
johannes
next prev parent reply other threads:[~2023-11-22 7:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 3:25 Jiapeng Chong
2023-11-22 7:25 ` Johannes Berg [this message]
2023-11-22 23:32 ` kernel test robot
2023-11-23 1:54 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fa7ec68a0302667f1b73682e4db96f6ba618397.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=abaci@linux.alibaba.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®