From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A860C3002AB for ; Mon, 27 Apr 2026 22:24:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777328650; cv=none; b=g2A/rtRj5Lrk6cBaY/34BgA7ZDj4e6fk1y7+vG1DRdTcz2FjG1h0okTBxyGnm7FJIPN0xVIsr4dMI+Da9Bb7XKew4ERSeaiEpVmWdvAGl9dvQLsnPG/Y6GZRSYIL0h0Haey9dKkHqxsAynQM5vK/+qQ7duLr9iTlenA6tAXnVMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777328650; c=relaxed/simple; bh=fkBhFSaTfOZt0+Y2HNLPKq3aDf0L7LqRsapHRqJebH8=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=ljwUXBz5djj5pBm+GDmfk422FCrFKDv+fFD85TGSWJ2lmwIGTN/f8lhMlVNucRglFqI6A98k25Slz27eah1R9WN1cRi76ng/Kf8bPAhwFNKIt3S9viwbejcISJ2vSLJ9FnmsYAG7Y704pZYWp6SqOjG9hilzWplqxK7eiMupmYU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=KyeeFekw; arc=none smtp.client-ip=209.85.219.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="KyeeFekw" Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-8a1e1817db6so86116236d6.2 for ; Mon, 27 Apr 2026 15:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1777328647; x=1777933447; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=FJFUnWE7fNzZGO1t3HTUL6y2hEPfYC2QrpMhK9FhHI8=; b=KyeeFekwNSM0wEEv2ByLpvFVcYzYNQWEgPH4syTvJ2M8gTwfsuHFkbGeRMS0Dx1O+o LXIDHKiRLxgflOk3UHawscHdjDXwZB1uX2AnTAa9qzs+ZWka5NYPPklFcbJSFYdqKX/O +kb5qe3YuUmfQlmQTA+rEG6Pv31n/FOS8NH3p/OcpopJt2ZlVU+vhhGq2i+V2Enil/HI MKenCMCYJw6jzh1MGDniwugTQSfHMBSru0adIeV5Vm8UNSfnY79DYxkaO1y9+Yv7MWfg uh+wgca20n/ez2csBWtYnXGQw2JBDYEdUX5IAXDFsScwi7zAJkH04oP8tVIxDwf/xndE u8Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777328647; x=1777933447; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FJFUnWE7fNzZGO1t3HTUL6y2hEPfYC2QrpMhK9FhHI8=; b=OusQOhOD+95VifbaIV9c2HfF19wgWHqEygVdOHUVPOJfDDb9R1a+sWzBJz6spDQIAP Kjq9jCZAOhBdPLivj/mlKlys7mFrYlynXInG5H8agfUWsb8ibeq1tXKmqnSZiSZzycVa 8EYB0P0zh/o2JxmZqqb4xj/UKcXBLLsYkUMFK8JC5aFi+Xpvma9sB+z0rWpMjIfXEuIz rczza5z6MvKMCIWevbYIKa3VRuH/7kCI7y93sEGSkazrMGK1wXkR/zYGR2EMmUEeimHK GaYhdp/s0TD7WT1t2gv0z9beI5Mt2X+0ial4wCvY8XY6iUMUl5EHlktI+ZgZQ/aTy418 iHqQ== X-Forwarded-Encrypted: i=1; AFNElJ9nQbbTBhPMUzr5wVQslcZ1ajvuLwxeFQ5TOVXs4MOoyt/gaTH/OUankf96wfxs3oYomLVf9mm4F+uducI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4rySPtS3Kg4WaeQQ7tutafVb5XgCcP5XjaSBnZD5b8O+Akx3m UxbocWUem7zFVvuXNzi+AxOs+3V11y/SkebjY3a/pZgQwC5AyjwXvycZjNT18spl9A== X-Gm-Gg: AeBDietq92yl6KtOkHLFLhnd7EPOHCyuiCQZGhEu9mpiLxPtbpMs+W5YkoFej2dpQ8f 7oHUPp/QAvm6bvvxSs/ute4uUMK5MHRnuqOVtHCl9Qa1XR4hoESVQ1IWrKp5ASXKAy5C8am/9W+ 4WxqC7YbQD7lg+RbuFwQ8aPtzosJ1WnYukIoKQwRkjYcW9cqtKPrfwX35z6kY//YivWKJuYjqfm 463nZPaE2/6WrUloQVm2yl8fhQT0YC+uOkQpsO90F1iZlfbs20zcswSjHl2TbltJ4tWhLknj/Pc tLDLFlL39usFX71ho3yd3jQa0iM069BVzQsj4MmGy04FU8pGxFEKTKD84mSwsYa9AZaVjL/JJQO Dnf0Un20/mmw8aEq0ZtGl5G3A1KBVvsFyD4RwkIFmua291EBX5PAkZmehxy/f4nyc+DWu3jpsY5 uynxxXAhiHbGtT1Uy6dLraT3UdjOe47sXRz8w/6GvGjkYgw26O1Ou92oUFE0y5WgNRPJyDxBNeh XtfAL8= X-Received: by 2002:a05:6214:320d:b0:8ac:af40:53d5 with SMTP id 6a1803df08f44-8b3e31bed7cmr15006596d6.34.1777328647372; Mon, 27 Apr 2026 15:24:07 -0700 (PDT) Received: from localhost (pool-71-126-255-178.bstnma.fios.verizon.net. [71.126.255.178]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b3e299d76asm6325296d6.48.2026.04.27.15.24.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 15:24:06 -0700 (PDT) Date: Mon, 27 Apr 2026 18:24:05 -0400 Message-ID: <3fa89f553526d4d68e1d5c0ba51a9664@paul-moore.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20260427_1759/pstg-lib:20260427_ 820/pstg-pwork:20260427_1759 From: Paul Moore To: Thorsten Blum , Stephen Smalley , Ondrej Mosnacek Cc: Thorsten Blum , selinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selinux: use QSTR() instead of QSTR_INIT() in init_sel_fs References: <20260422123104.100014-3-thorsten.blum@linux.dev> In-Reply-To: <20260422123104.100014-3-thorsten.blum@linux.dev> On Apr 22, 2026 Thorsten Blum wrote: > > Drop the length argument and use the simpler QSTR(). > > Signed-off-by: Thorsten Blum > --- > security/selinux/selinuxfs.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c > index 83aa765a09f9..8c107af5140e 100644 > --- a/security/selinux/selinuxfs.c > +++ b/security/selinux/selinuxfs.c > @@ -2107,8 +2107,7 @@ struct path selinux_null __ro_after_init; > > int __init init_sel_fs(void) > { > - struct qstr null_name = QSTR_INIT(NULL_FILE_NAME, > - sizeof(NULL_FILE_NAME)-1); > + struct qstr null_name = QSTR(NULL_FILE_NAME); > int err; > > if (!selinux_enabled_boot) Technically I imagine QSTR_INIT() would be slightly quicker since we use sizeof() instead of strlen(), but the code is simpler and I can't we only pay the performance hit once at boot. Merged into selinux/dev, thanks. -- paul-moore.com