From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7844BC433E0 for ; Wed, 13 Jan 2021 07:18:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A9192313F for ; Wed, 13 Jan 2021 07:18:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726759AbhAMHS0 (ORCPT ); Wed, 13 Jan 2021 02:18:26 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:53414 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726567AbhAMHSZ (ORCPT ); Wed, 13 Jan 2021 02:18:25 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: tomeu) with ESMTPSA id 5C62D1F455D0 Subject: Re: [PATCH v10 0/4] drm/panfrost: Add support for mt8183 GPU To: Nicolas Boichat , Rob Herring , Steven Price , Alyssa Rosenzweig Cc: fshao@chromium.org, boris.brezillon@collabora.com, hsinyi@chromium.org, hoegsberg@chromium.org, Daniel Vetter , David Airlie , Matthias Brugger , Rob Herring , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20210113060703.3122661-1-drinkcat@chromium.org> From: Tomeu Vizoso Message-ID: <3fa8f9c5-5956-73fc-e464-4df68a564b64@collabora.com> Date: Wed, 13 Jan 2021 08:17:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210113060703.3122661-1-drinkcat@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/13/21 7:06 AM, Nicolas Boichat wrote: > Hi! > > Follow-up on the v5 [1], things have gotten significantly > better in the last 9 months, thanks to the efforts on Bifrost > support by the Collabora team (and probably others I'm not > aware of). > > I've been testing this series on a MT8183/kukui device, with a > chromeos-5.10 kernel [2], and got basic Chromium OS UI up with > mesa 20.3.2 (lots of artifacts though). Btw, don't know if you plan to retest with a newer Mesa, but a recent master should have pretty good ES 3.0 compliance on the Duet. Cheers, Tomeu > devfreq is currently not supported, as we'll need: > - Clock core support for switching the GPU core clock (see 2/4). > - Platform-specific handling of the 2-regulator (see 3/4). > > Since the latter is easy to detect, patch 3/4 just disables > devfreq if the more than one regulator is specified in the > compatible matching table. > > [1] https://patchwork.kernel.org/project/linux-mediatek/cover/20200306041345.259332-1-drinkcat@chromium.org/ > [2] https://crrev.com/c/2608070 > > Changes in v10: > - Fix the binding to make sure sram-supply property can be provided. > > Changes in v9: > - Explain why devfreq needs to be disabled for GPUs with >1 > regulators. > > Changes in v8: > - Use DRM_DEV_INFO instead of ERROR > > Changes in v7: > - Fix GPU ID in commit message > - Fix GPU ID in commit message > > Changes in v6: > - Rebased, actually tested with recent mesa driver. > > Nicolas Boichat (4): > dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 > arm64: dts: mt8183: Add node for the Mali GPU > drm/panfrost: devfreq: Disable devfreq when num_supplies > 1 > drm/panfrost: Add mt8183-mali compatible string > > .../bindings/gpu/arm,mali-bifrost.yaml | 28 +++++ > arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 6 + > .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 6 + > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 105 ++++++++++++++++++ > drivers/gpu/drm/panfrost/panfrost_devfreq.c | 9 ++ > drivers/gpu/drm/panfrost/panfrost_drv.c | 10 ++ > 6 files changed, 164 insertions(+) >