From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01463C4167B for ; Wed, 6 Dec 2023 17:09:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442717AbjLFRJO (ORCPT ); Wed, 6 Dec 2023 12:09:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442647AbjLFRJM (ORCPT ); Wed, 6 Dec 2023 12:09:12 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D86AED3; Wed, 6 Dec 2023 09:09:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=lAZ9nI3AnS0SLIGSfNh7gWXoYcgJuboGn4WiQFw6uGE=; b=CXBtRYlnjFDan4M4CiH+JdrUwF SuzhFI6CVgSw9Vpb8N3OlHYsE+f4ma5r+c4UzgAc63SYsNdf4kIvPa5KhdGczLuk6b/KeR8Vh/krw xhg/cNMVBfv7coKiSmY+ZnyE+MW7HZ8k2a5UosVHIlbDt2r73GE9wiQ7zvQPb5sIpJXA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rAvOY-002ESH-JS; Wed, 06 Dec 2023 18:09:10 +0100 Date: Wed, 6 Dec 2023 18:09:10 +0100 From: Andrew Lunn To: Christian Marangi Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next PATCH v2 02/12] net: phy: at803x: move disable WOL to specific at8031 probe Message-ID: <3fc86d32-7faf-46d1-aff1-816f103acd5b@lunn.ch> References: <20231201001423.20989-1-ansuelsmth@gmail.com> <20231201001423.20989-3-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231201001423.20989-3-ansuelsmth@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 01, 2023 at 01:14:12AM +0100, Christian Marangi wrote: > Move the WOL disable call to specific at8031 probe to make at803x_probe > more generic and drop extra check for PHY ID. > > Keep the same previous behaviour by first calling at803x_probe and then > disabling WOL. > > Signed-off-by: Christian Marangi Reviewed-by: Andrew Lunn Andrew