From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jingyi Wang <quic_jingyw@quicinc.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, andersson@kernel.org,
konradybcio@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
quic_tingweiz@quicinc.com, quic_aiquny@quicinc.com,
quic_tengfan@quicinc.com
Subject: Re: [PATCH 1/3] dt-bindings: arm: qcom: document QCS8275/QCS8300 SoC and reference board
Date: Wed, 14 Aug 2024 10:56:01 +0200 [thread overview]
Message-ID: <3fd0fa88-eee0-45f8-bd8b-f5b2bc15c25a@kernel.org> (raw)
In-Reply-To: <20240814072806.4107079-2-quic_jingyw@quicinc.com>
On 14/08/2024 09:28, Jingyi Wang wrote:
> Document the QCS8275/QCS8300 SoC and its reference board QCS8300 RIDE.
> QCS8300 is an Industrial Safe SoC, while QCS8275 is the Industrial
> Non-Safe version which can share the same SoC dtsi and board DTS.
>
> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index f08e13b61172..3952e1579767 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -42,6 +42,8 @@ description: |
> msm8996
> msm8998
> qcs404
> + qcs8275
> + qcs8300
> qcs8550
> qcm2290
> qcm6490
> @@ -884,6 +886,12 @@ properties:
> - const: qcom,qcs404-evb
> - const: qcom,qcs404
>
> + - items:
> + - enum:
> + - qcom,qcs8300-ride
This is not used. You miss DTS patch. Look how people upstream things:
such binding *never* goes separate from the DTS.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-14 8:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 7:28 [PATCH 0/3] soc: qcom: socinfo: Add QCS8275/QCS8300 SoC ID Jingyi Wang
2024-08-14 7:28 ` [PATCH 1/3] dt-bindings: arm: qcom: document QCS8275/QCS8300 SoC and reference board Jingyi Wang
2024-08-14 8:56 ` Krzysztof Kozlowski [this message]
2024-08-15 2:27 ` Jingyi Wang
2024-08-14 7:28 ` [PATCH 2/3] dt-bindings: arm: qcom,ids: add SoC ID for QCS8275/QCS8300 Jingyi Wang
2024-08-14 8:56 ` Krzysztof Kozlowski
2024-08-14 7:28 ` [PATCH 3/3] soc: qcom: socinfo: add QCS8275/QCS8300 SoC ID Jingyi Wang
2024-08-15 20:40 ` (subset) [PATCH 0/3] soc: qcom: socinfo: Add " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fd0fa88-eee0-45f8-bd8b-f5b2bc15c25a@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_aiquny@quicinc.com \
--cc=quic_jingyw@quicinc.com \
--cc=quic_tengfan@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®