From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754259AbdJPQ05 (ORCPT ); Mon, 16 Oct 2017 12:26:57 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:57370 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752297AbdJPQ0y (ORCPT ); Mon, 16 Oct 2017 12:26:54 -0400 Subject: Re: [RFC 07/19] KVM: s390: introduce AP matrix configuration interface To: Martin Schwidefsky Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, freude@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, qemu-s390x@nongnu.org, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com References: <1507916344-3896-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1507916344-3896-8-git-send-email-akrowiak@linux.vnet.ibm.com> <20171016111030.1a955866@mschwideX1> From: Tony Krowiak Date: Mon, 16 Oct 2017 12:26:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20171016111030.1a955866@mschwideX1> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 17101616-0040-0000-0000-000003B3916A X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007899; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000236; SDB=6.00932011; UDB=6.00469302; IPR=6.00712301; BA=6.00005641; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017560; XFM=3.00000015; UTC=2017-10-16 16:26:52 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17101616-0041-0000-0000-000007A8970D Message-Id: <3fd9ce01-e886-b3f3-021d-f2a147cafdb7@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-16_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710160229 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/2017 05:10 AM, Martin Schwidefsky wrote: > On Fri, 13 Oct 2017 13:38:52 -0400 > Tony Krowiak wrote: > >> This patch introduces a new compilation unit that will contain >> all of the data structures and logic for configuring AP adapters, >> usage domains and control domains for a KVM guest. >> >> Signed-off-by: Tony Krowiak >> --- >> MAINTAINERS | 2 ++ >> arch/s390/include/asm/ap-config.h | 12 ++++++++++++ >> arch/s390/kvm/Makefile | 2 +- >> arch/s390/kvm/ap-config.c | 9 +++++++++ >> 4 files changed, 24 insertions(+), 1 deletions(-) >> create mode 100644 arch/s390/include/asm/ap-config.h >> create mode 100644 arch/s390/kvm/ap-config.c >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 0c8855a..4de0904 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -11721,6 +11721,8 @@ F: drivers/s390/crypto/ap_matrix_bus.c >> F: drivers/s390/crypto/vfio_ap_matrix_drv.c >> F: drivers/s390/crypto/vfio_ap_matrix_private.h >> F: drivers/s390/crypto/vfio_ap_matrix_ops.c >> +F: arch/s390/include/asm/kvm/ap-config.h >> +F: arch/s390/kvm/ap-config.c >> >> S390 ZFCP DRIVER >> M: Steffen Maier >> diff --git a/arch/s390/include/asm/ap-config.h b/arch/s390/include/asm/ap-config.h >> new file mode 100644 >> index 0000000..8491b5f >> --- /dev/null >> +++ b/arch/s390/include/asm/ap-config.h >> @@ -0,0 +1,12 @@ >> +/* >> + * Adjunct Processor (AP) configuration management for KVM guests >> + * >> + * Copyright IBM Corp. 2017 >> + * >> + * Author(s): Tony Krowiak >> + */ >> + >> +#ifndef _ASM_KVM_AP_CONFIG_H_ >> +#define _ASM_KVM_AP_CONFIG_H_ >> + >> +#endif /* _ASM_KVM_AP_CONFIG_H_ */ >> diff --git a/arch/s390/kvm/Makefile b/arch/s390/kvm/Makefile >> index 09a9e6d..0397b9c 100644 >> --- a/arch/s390/kvm/Makefile >> +++ b/arch/s390/kvm/Makefile >> @@ -12,6 +12,6 @@ common-objs = $(KVM)/kvm_main.o $(KVM)/eventfd.o $(KVM)/async_pf.o $(KVM)/irqch >> ccflags-y := -Ivirt/kvm -Iarch/s390/kvm >> >> kvm-objs := $(common-objs) kvm-s390.o intercept.o interrupt.o priv.o sigp.o >> -kvm-objs += diag.o gaccess.o guestdbg.o sthyi.o vsie.o >> +kvm-objs += diag.o gaccess.o guestdbg.o sthyi.o vsie.o ap-config.o >> >> obj-$(CONFIG_KVM) += kvm.o >> diff --git a/arch/s390/kvm/ap-config.c b/arch/s390/kvm/ap-config.c >> new file mode 100644 >> index 0000000..84fdf43 >> --- /dev/null >> +++ b/arch/s390/kvm/ap-config.c >> @@ -0,0 +1,9 @@ >> +/* >> + * Adjunct Processor (AP) configuration management for KVM guests >> + * >> + * Copyright IBM Corp. 2017 >> + * >> + * Author(s): Tony Krowiak >> + */ >> + >> +#include > Another patch that introduces empty files. Please don't do that. Merge > patch #7 with patch #16. With the dependency in patch #8 on the ap-config.h > header the new place for the combined patch would be prior to patch #8. Sounds reasonable, will do. >