From: Dan Carpenter <dan.carpenter@linaro.org>
To: yunchuan <yunchuan@nfschina.com>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
iyappan@os.amperecomputing.com, keyur@os.amperecomputing.com,
quan@os.amperecomputing.com, andrew@lunn.ch,
hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next 08/10] net: mdio: Remove unnecessary (void*) conversions
Date: Thu, 29 Jun 2023 08:50:57 +0300 [thread overview]
Message-ID: <3fda1d81-e350-42e9-8fec-6f107ae75932@kadam.mountain> (raw)
In-Reply-To: <325f00e3-1dfd-f77b-9795-6f89e44c0417@nfschina.com>
On Thu, Jun 29, 2023 at 09:59:56AM +0800, yunchuan wrote:
> On 2023/6/28 17:50, Russell King (Oracle) wrote:
> > On Wed, Jun 28, 2023 at 10:45:17AM +0800, wuych wrote:
> > > @@ -211,7 +211,7 @@ static void xgene_enet_wr_mdio_csr(void __iomem *base_addr,
> > > static int xgene_xfi_mdio_write(struct mii_bus *bus, int phy_id,
> > > int reg, u16 data)
> > > {
> > > - void __iomem *addr = (void __iomem *)bus->priv;
> > > + void __iomem *addr = bus->priv;
> > > int timeout = 100;
> > > u32 status, val;
> > > @@ -234,7 +234,7 @@ static int xgene_xfi_mdio_write(struct mii_bus *bus, int phy_id,
> > > static int xgene_xfi_mdio_read(struct mii_bus *bus, int phy_id, int reg)
> > > {
> > > - void __iomem *addr = (void __iomem *)bus->priv;
> > > + void __iomem *addr = bus->priv;
> > > u32 data, status, val;
> > > int timeout = 100;
> > These probably cause Sparse to warn whether or not the cast is there.
>
> Hi, Russell King,
>
> I didn't notice this Sparse warning.
> Should I remove this cast although it cause Sparse warning?
No. Don't introduce new Sparse warnings.
regards,
dan carpenter
next prev parent reply other threads:[~2023-06-29 5:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 2:45 wuych
2023-06-28 9:50 ` Russell King (Oracle)
2023-06-29 1:59 ` yunchuan
2023-06-29 5:50 ` Dan Carpenter [this message]
2023-06-29 6:19 ` yunchuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fda1d81-e350-42e9-8fec-6f107ae75932@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=iyappan@os.amperecomputing.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=keyur@os.amperecomputing.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quan@os.amperecomputing.com \
--cc=yunchuan@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®