From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65F314A5EB2 for ; Thu, 1 Oct 2026 08:10:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790842269; cv=none; b=pQeehnl7WpOKbM6BNulCixJUgif6bFVkoeTtKPGLgTDVuSMo4uC5QnS8GyBh/V09qzAMacXUr1bbivdFF2/10g7ZvsE8cLUHOBgujf1vCnc0+P5VnjH1uWW6DE68kC372A5CHq2FDK2LIL/CX45Y1n+NICUGwP9MMDd6hCuQKhc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790842269; c=relaxed/simple; bh=H6gXBDzdcFMlIAowvTzC7IWbOKDgXR6auVjiNftxDf8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=u6bgyxNqvKY1fh5fIFCSUpqN68naLDo/xLoEiUSF16OxrJIWjjyOXKVNW6xxJM+zpytwBW8qqP9kX39r8tVj3Vi4VkXExNBkc94AC1Th7dlwxNP9/smQ7+WzHDGzpNHway2mrOZcInQ02ADEqdiSNvTCgDvAMZIKx2vYJHuacF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=TaSfPzZY; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="TaSfPzZY" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id E8C4C1A10A2; Thu, 1 Oct 2026 08:10:53 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id B9F4760341; Thu, 1 Oct 2026 08:10:53 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id F17D9103290CF; Thu, 1 Oct 2026 10:10:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1790842251; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=1iEXv1MzdrgaIRYlO6IHAkcD/PzrlJhsiGovH6P/zgo=; b=TaSfPzZYx75PUEp1as/SOZwnqw+vAb7IWcXpDNW4dcPjGWosHLHT0VabrjEwdirzGLZqS7 jngsLORTHpV8vfvGRDoN2XYRLPUa/cKaRJsPaG4C5Z/GJM+oWP8zPu72qnbLinphCk6jQD lFeEGgtltO2wtzB5QDOd3k2mgohWRf6yuY6ZL7mrJkKAU5mx/VnWo4CDFGKPNeF4V5FtKs W8JoNWgykWDPmsDm7bUxT1xs16ZZMLTFYZppy0yfI5F2h5WqrNaOuUVER/Mwy6gwC5ndKM pJnQwLqsQATFwFnLgpEIG1H1fCDMPjuXdWg1tHwMw6Fl4SDe1KklXU8Ty3Rq8Q== Message-ID: <3fdc30dfdddfb5f529398541aefe92ae86a07b3e.camel@bootlin.com> Subject: Re: [PATCH v2 4/7] drm/bridge: dw-mipi-dsi2: stop using deprecated devm_drm_of_get_bridge() From: Paul Cercueil To: Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Icenowy Zheng , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Dave Stevenson , =?ISO-8859-1?Q?Ma=EDra?= Canal , Raspberry Pi Kernel Maintenance , Geert Uytterhoeven Cc: Arnd Bergmann , Doug Anderson , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Date: Thu, 01 Oct 2026 10:10:40 +0200 In-Reply-To: <20260929-drm-fix-of_get_bridge-build-regression-v2-4-6da431d8f180@bootlin.com> References: <20260929-drm-fix-of_get_bridge-build-regression-v2-0-6da431d8f180@bootlin.com> <20260929-drm-fix-of_get_bridge-build-regression-v2-4-6da431d8f180@bootlin.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 Hi Luca (and not Lucas, sorry), Le mardi 29 septembre 2026 =C3=A0 15:39 +0200, Luca Ceresoli a =C3=A9crit= =C2=A0: > devm_drm_of_get_bridge() is deprecated, switch to > of_drm_get_bridge_by_endpoint(). As of_drm_get_bridge_by_endpoint() retur= ns > a refcounted bridge, ensure it is put by using bridge.next_bridge. >=20 > Signed-off-by: Luca Ceresoli Reviewed-by: Paul Cercueil With one nitpick below. >=20 > --- >=20 > Changes in v2: > - fix bridge reference leak on attach error and detach paths > --- > =C2=A0drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c | 11 +++++------ > =C2=A01 file changed, 5 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c > b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c > index 7fd2f1e60654..eb7d5713bd28 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c > @@ -192,7 +192,6 @@ struct cmd_header { > =C2=A0struct dw_mipi_dsi2 { > =C2=A0 struct drm_bridge bridge; > =C2=A0 struct mipi_dsi_host dsi_host; > - struct drm_bridge *panel_bridge; > =C2=A0 struct device *dev; > =C2=A0 struct regmap *regmap; > =C2=A0 struct clk *pclk; > @@ -528,12 +527,12 @@ static int dw_mipi_dsi2_host_attach(struct mipi_dsi= _host > *host, > =C2=A0 dsi2->format =3D device->format; > =C2=A0 dsi2->mode_flags =3D device->mode_flags; > =C2=A0 > - bridge =3D devm_drm_of_get_bridge(dsi2->dev, dsi2->dev->of_node, 1, 0); > + bridge =3D of_drm_get_bridge_by_endpoint(dsi2->dev->of_node, 1, 0); > =C2=A0 if (IS_ERR(bridge)) > =C2=A0 return PTR_ERR(bridge); > =C2=A0 > =C2=A0 bridge->pre_enable_prev_first =3D true; > - dsi2->panel_bridge =3D bridge; > + dsi2->bridge.next_bridge =3D bridge; > =C2=A0 > =C2=A0 drm_bridge_add(&dsi2->bridge); > =C2=A0 > @@ -547,6 +546,7 @@ static int dw_mipi_dsi2_host_attach(struct mipi_dsi_h= ost > *host, > =C2=A0 > =C2=A0err_remove_bridge: > =C2=A0 drm_bridge_remove(&dsi2->bridge); > + drm_bridge_clear_and_put(&dsi2->bridge.next_bridge); > =C2=A0 return ret; > =C2=A0} > =C2=A0 > @@ -564,8 +564,7 @@ static int dw_mipi_dsi2_host_detach(struct mipi_dsi_h= ost > *host, > =C2=A0 } > =C2=A0 > =C2=A0 drm_bridge_remove(&dsi2->bridge); > - > - drm_of_panel_bridge_remove(host->dev->of_node, 1, 0); > + drm_bridge_clear_and_put(&dsi2->bridge.next_bridge); > =C2=A0 > =C2=A0 return 0; > =C2=A0} > @@ -884,7 +883,7 @@ static int dw_mipi_dsi2_bridge_attach(struct drm_brid= ge > *bridge, > =C2=A0 encoder->encoder_type =3D DRM_MODE_ENCODER_DSI; > =C2=A0 > =C2=A0 /* Attach the panel-bridge to the dsi bridge */ > - return drm_bridge_attach(encoder, dsi2->panel_bridge, bridge, > + return drm_bridge_attach(encoder, dsi2->bridge.next_bridge, bridge, > =C2=A0 flags); Same remark as for the patch 3/7, it would look a bit better to have the 'bridge' moved to the second line. Cheers, -Paul