From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9554C433EF for ; Wed, 16 Mar 2022 23:03:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234550AbiCPXEz (ORCPT ); Wed, 16 Mar 2022 19:04:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229812AbiCPXEw (ORCPT ); Wed, 16 Mar 2022 19:04:52 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8E13DFAC for ; Wed, 16 Mar 2022 16:03:33 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 71F991F44C42 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1647471812; bh=cw1c3IVv325Z8b6mJJEs4HEBjZj9x2UDC55LA51Tjsw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gNN7CMmhxdZZ7js/GDH/LeNCtv99QQu//2AA/ElU7yHMo9wb9thbdFSK3P33l7byl 5DuTzvAk9xh5dBfjI8doFHWcLYJqarjfrzmM58A/7t9yBl4EVhZp9RXBSItKET0rjo pQ3mbIPSUVvr5RuYODuK5FnD0N10cxrnnCnzxazkZ4vozKzr8qGdg9LbUjWT+AR13w +OOeHCGPbbw4by9zcpnxr/rDWBDLgflOCuHLfRzORwSojjbbnTQjId9ldAs7m8YJkl Ik/5QeTy+8c18s7M1sn4lH2VB0FzQ1Nx27AiCwKqNFjcjoEdSf4iHV40krt8Ca9fe4 QAbCpmPvPsqWQ== Message-ID: <3fe18a5f-081c-c5aa-7366-0a44035e5082@collabora.com> Date: Thu, 17 Mar 2022 02:03:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v2 6/8] drm/shmem-helper: Add generic memory shrinker Content-Language: en-US To: Steven Price , David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Daniel Almeida , Gert Wollny , Tomeu Vizoso , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Alyssa Rosenzweig Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Gustavo Padovan , Daniel Stone , virtualization@lists.linux-foundation.org, Dmitry Osipenko References: <20220314224253.236359-1-dmitry.osipenko@collabora.com> <20220314224253.236359-7-dmitry.osipenko@collabora.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/16/22 18:04, Steven Price wrote: > On 14/03/2022 22:42, Dmitry Osipenko wrote: >> Introduce a common DRM SHMEM shrinker. It allows to reduce code >> duplication among DRM drivers, it also handles complicated lockings >> for the drivers. This is initial version of the shrinker that covers >> basic needs of GPU drivers. >> >> This patch is based on a couple ideas borrowed from Rob's Clark MSM >> shrinker and Thomas' Zimmermann variant of SHMEM shrinker. >> >> GPU drivers that want to use generic DRM memory shrinker must support >> generic GEM reservations. >> >> Signed-off-by: Daniel Almeida >> Signed-off-by: Dmitry Osipenko > This looks fine to me, but one nitpick: you should update the comment in > struct drm_gem_shmem_object: > >> /** >> * @madv: State for madvise >> * >> * 0 is active/inuse. >> * A negative value is the object is purged. >> * Positive values are driver specific and not used by the helpers. >> */ >> int madv; > This is adding a helper which cares about the positive values. Good catch, I'll update the comment in v3.