From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1938A314A7A for ; Tue, 6 Jan 2026 12:03:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767701005; cv=none; b=s5Tcrj+ZClvNKkmOYlII7z2F0MMKJSaWt1Gt2sglnUzxRiTqJHp5J6ZAfFBu8rFHnzZfW7YfIvmTu/+F9OTFzDsG0DrC5L+olHvg14Nl8v4PIzeKGa+avo7YWJ1IHPY6Zw5zRR/ARgyluSuA7U1JcZJ2+MNGcUO+0ZJTRp6xyz4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767701005; c=relaxed/simple; bh=Uv82Eud2+qQYekf4jOxXEpCdWv9RuoIFOpRsSZ7Vu0Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EW7pBZBRGn+WgKlhOwc/KPXHst2XbM+mbSGfhQ6p1DuZhz2Zlk1bpmrQx/mlan78TCj0RIl7fTmk5pwLV0/5pSZJ9hUM3wD8/saEy0MrAFOcmTicLSOz29sLODEy6fG4hWIAetr0yRfp9BkkBDQ2LWcJL0wfLx6Q1XBZwQv0R7I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PejtpBFd; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PejtpBFd" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-59583505988so1410595e87.1 for ; Tue, 06 Jan 2026 04:03:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767701002; x=1768305802; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=R24kDi7ycrD9dY59pwPxZ5h8zPUnSHdzoVoXCvf0GVU=; b=PejtpBFdiyV86Oves1GoWsI2WIRx67M3gJiMJIh4YWlDKjwPDOhmLyWfE9FodWY05c Fna3T+5wOBPZDjfZLRv1b6mvSLurqBu5nigCxivFY8ArbrNd0MLkPuUA7GIErI/7syLA iXfMoWePdJHHExFyPBoJ92aMYL01C03RnyeqUcgCgvogo6rT9cHJXur9sEc8v4s21L/B 6owfpOf36fZM7r1LHSfrj6UU53jxzIkDAkbT6pyNq41hDbLVVAy3P1w03lJoNumQgJLq +B/Cd4VcxLj7eyXxutuR2HDHDKJEBnS2pUU/+uEBlFGkm5MO+tS3lS8E1f0sldupGhV6 gUyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767701002; x=1768305802; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R24kDi7ycrD9dY59pwPxZ5h8zPUnSHdzoVoXCvf0GVU=; b=EHbJPuh22ML1IbzL02JEl7auu10nxa5mIzX9u7GS1kGQ0GRTm4zwasBwAOWVFomoPS I35sBZ1SfycHx9kh9NuCUODcQ4QUC2Fni0TCvTI73Cfqq6Es04AYZ5LX3VdQwN6IMrt4 h+nhaWZHKP3zuOhh30l/dfQyABauIETcpfzebPOngwaQdJsz6GjC+P7BpWihOyrkhRrm E/4rl7guIiiNreg0CLEmJWU0vbNHe3WITPNU8pfzo0qpnmMAIHZNCKFYU8XcSTVtborP 2IYSuMJfL8PI+BFNQP2hT5Fo6XbOoKKzmtAa/b8T0OLKMLoiDdKBqP1XyTWgXUimQjRz JMFA== X-Forwarded-Encrypted: i=1; AJvYcCWmvyV+yBQ4W2jkZ6mnkRABWa3FD53AbzlvJS/pHvA2MzBq+Hd+hAIoCKJdysdijOMWj/qhKKBbt//Ggwo=@vger.kernel.org X-Gm-Message-State: AOJu0YywIVcw8KtqeZpHymIMyrPPgY9crfqqlFd2Ecu5g5fELWKUtV6T v3EZ67VlnvTp5Xzr4yjtKnK/Q9yx0NxzG/aIcdG9H55lA+hDuzDPmPQ0 X-Gm-Gg: AY/fxX7Ho2+WgpoMJzGsD8aYq5YBbHDDgIQIwxvt/27ZALgziBf8bxgUAjzfjZnLNW0 Te+kvFm1mEjUXUqEod8+vB7Q7vLfH+53utHzjbXvFbDTNDMktACVdrcmpj3L4ZlI0UjSY3C+BDW YmT/AuH3u8okt9IJ+Q9KhrPm1J8Q4ZZDGmtkn7t3fRCpETtC39K1sVHIl720AE/tq1TA8Ta9qlV Y1y+MlcWInjH5Q2OjLjxy7BqlnbrJOkTt/c1YVyvN87bO/pI5d8/a8mefNvlD6dmsF+IqSN8QGo 6x6aB6isOPK6Mi24LQLMxVTSeM66LQygRcAcSXVwZKo2e0i1QaIgwXNqokeOJluHFM67A4rC++h QgZPc/8NWcgZEGozoGWpHUcsnZUilkhCp8MUixf1V+/lsHNLv19BQ739Ea6XIdBgiHaAXLbiXGK J0I+cvdxyyrwv1V5xP0XKzjaU= X-Google-Smtp-Source: AGHT+IFQ34mkfMwuZtHPU+EK43Z3U18GgFyWPUtQcLuGBqEmE4MawbvUoM0v/a/8F9LW9CHZvBDqvw== X-Received: by 2002:ac2:4c06:0:b0:595:7d7c:59a9 with SMTP id 2adb3069b0e04-59b65878424mr688495e87.22.1767701001878; Tue, 06 Jan 2026 04:03:21 -0800 (PST) Received: from [192.168.0.131] ([194.183.54.57]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59b6addaab0sm185546e87.28.2026.01.06.04.03.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jan 2026 04:03:21 -0800 (PST) Message-ID: <3fe2eb05-f45d-4910-a9e5-8472c5c7f43f@gmail.com> Date: Tue, 6 Jan 2026 13:03:18 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] leds: ltc3220: add driver To: Edelweise Escala , Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260106-ltc3220-driver-v1-0-73601d6f1649@analog.com> <20260106-ltc3220-driver-v1-2-73601d6f1649@analog.com> Content-Language: en-US From: Jacek Anaszewski In-Reply-To: <20260106-ltc3220-driver-v1-2-73601d6f1649@analog.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/6/26 06:27, Edelweise Escala wrote: > Add driver for ltc3220. LTC3220 18 Channel LED Driver > > Signed-off-by: Edelweise Escala > --- > MAINTAINERS | 1 + > drivers/leds/Kconfig | 10 + > drivers/leds/Makefile | 1 + > drivers/leds/leds-ltc3220.c | 465 ++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 477 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d640c35d1f93..fda0d2963c4f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -14961,6 +14961,7 @@ L: linux-leds@vger.kernel.org > S: Maintained > W: https://ez.analog.com/linux-software-drivers > F: Documentation/devicetree/bindings/leds/leds-ltc3220.yaml > +F: drivers/leds/leds-ltc3220.c > [...] > + "Failed to set command\n"); > + > + device_for_each_child_node_scoped(&client->dev, child) { > + struct led_init_data init_data = {}; > + struct ltc3220_uled_cfg *led; > + u32 source; > + > + ret = fwnode_property_read_u32(child, "reg", &source); > + if (ret) > + return dev_err_probe(&client->dev, ret, > + "Couldn't read LED address\n"); > + > + if (!source || source > LTC3220_NUM_LEDS) > + return dev_err_probe(&client->dev, -EINVAL, > + "LED address out of range\n"); > + > + init_data.fwnode = child; > + init_data.devicename = "ltc3220"; > + init_data.devname_mandatory = true; Why? Please get acquainted with the section "LED Device Naming" in [0], and the documentation of this property in [1]. > + > + /* LED node reg/index/address goes from 1 to 18 */ > + i = source - 1; > + led = <c3220_state->uled_cfg[i]; > + led->led_index = i; > + led->reg_value = 0; > + led->ltc3220_state = ltc3220_state; > + led->led_cdev.brightness_set_blocking = ltc3220_set_led_data; > + led->led_cdev.brightness_get = ltc3220_get_led_data; > + led->led_cdev.max_brightness = 255; > + led->led_cdev.blink_set = ltc3220_blink_set; > + led->led_cdev.pattern_set = ltc3220_pattern_set; > + led->led_cdev.pattern_clear = ltc3220_pattern_clear; > + > + ret = devm_led_classdev_register_ext(&client->dev, > + &led->led_cdev, > + &init_data); > + if (ret) > + return dev_err_probe(&client->dev, ret, > + "Failed to register LED class device\n"); [0] Documentation/leds/leds-class.rst [1] include/linux/leds.h -- Best regards, Jacek Anaszewski