From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4039E31E83D for ; Sat, 28 Mar 2026 06:25:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774679157; cv=none; b=eYERsP/B32MMmaQ/YNj4vYe4Z2q9OaqsZK0LIk+K9SsBxyjhp3MkWi77k10f6Iqt8P85O2O376cSFzEP8cvogS04g9V9WUrpE6qBAzmuv2Aprb85GnzR9yBPLvWlX343gCedCeGjfk4o/hezhSuzjGKDG4IJ/GAmfCFzZNvqMBM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774679157; c=relaxed/simple; bh=x378TmYIvCw7bbd+OA9uXgGesY3LGv8GwqbJTuA6yyM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fLGkE3sIsBa2xuoxwZDi8zUGb6r9SV48EEtTbvgBMU2Tgfad8cgksB57UV2j2xh7mymwH5C8T/kOad961LHHVqTvRKJW0MWiESOGqJU0Fsrbvr9pb9zdeMmBOZcgqQVPhZvE8aqbOhsGnM9ONQK6XIFinc1zWnqjBw5rMao5do0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LK6QF+H3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GGgaIJjd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LK6QF+H3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GGgaIJjd" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62S2qAsF566667 for ; Sat, 28 Mar 2026 06:25:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AnmAY2j6WsZg+gjoAQiABlVqqmlC+uI6ln6mUZFTiOA=; b=LK6QF+H3ZTL8mBSm UNdL1oSaq3P7IvYciyLIt397Z9F7QwyRxFChOajUg0PFLYxLDS5GgiTAqoVHOdNp x9HRbPuXmRQrnOv9d5qT4Nri8OSopIB3WK9zAPyOLjgMjtkfw7zdsNMMeg3fFvin SCCXDa9jAeUYRNJTdEGBhI+svsag7Pax5nziwZA4moFtBDFcLkbyE7j3yuac4ttg bwv9XpCDLW2ZD8UMwdOONXO7iCqnhcfbuRbAn1OQnHN0Nhwx74xb3a4TJHKjJKNn dPByVTiPAgfKnCn23dHQzIv8NAY7ihuXjJmTwjWFYBM82/S6QA+ozSSFnfE1x+KN 5A9TcA== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d66jwgb54-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 28 Mar 2026 06:25:55 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82a88a2704fso1660848b3a.0 for ; Fri, 27 Mar 2026 23:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774679154; x=1775283954; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AnmAY2j6WsZg+gjoAQiABlVqqmlC+uI6ln6mUZFTiOA=; b=GGgaIJjdnRx7ypN2QX+rYYjcw8EU0ue8YeNFtolEmzJwlEscs6hEBYzAZUzXPZVqpA 37G9l8PM4QQJSCv5xxwoUesa40Jcd56N2+/IXHplvcfxbS6vXSL+O9ouTcBkw5+MT0Ts 1OFdwl1wI1U2hL++oDAO1nOB5OYwVP/RXQvWTm38KwHTVsUxrMliZw25vcStB5IRRj+B r3xH2Pw1iMmtPrBIo0U1FazAzKXEn/SEsLMQ3BC/KQ+J5aT3d6eMZZVQ5Ik93afDQzrT uxZdQIHCmxCU4LUDT3qM+XT0AT66nsGoQbIGpa7VDtLfq6IMgkbQtTVJKe6usB6LO2Wc QnQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774679154; x=1775283954; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AnmAY2j6WsZg+gjoAQiABlVqqmlC+uI6ln6mUZFTiOA=; b=RtE/H9wliK0hzylfd2AFJSG8k2BVeB5/tn2Y6yz+9Mbxy4+zR7F+514nfsiQc9Qh5L MjWvJCkL8vZs5h3IISOvRTfFx00imGFes6tMqOU1V4M/C2p3pWGjvhcOzI+F34AQnGL1 aWqTzazwfFS+hNP4qOHh/nNAZLFyGTcINVrqFnoAv/+7FlpQWdyBPTRKMGzFtpUJCpsK z4hHOnPSTsiI3E4/qB4+2cL/XonyXMht03VAbd7vQmIid1sDmwz/tdJ+f6XDAb3IfkyL Ve21osXbDL9JyLN51JMXxlBpKewnmFEasreXKtfbGAPX4LFAONdig1AYJhbSZ72KJIZj N4eA== X-Forwarded-Encrypted: i=1; AJvYcCUA5TKsSa9mMwC7lDxScw7SpZGer79ivxgX2lSfViqPu5wlNaPZHKUfo/BSpBT+S1w0cHksR45KQEZeWrE=@vger.kernel.org X-Gm-Message-State: AOJu0YzKgFqq/HkMTG6ZnZki4l/s4x/b9KgTlmpJjBJxurrKkOEvs39Z 7qu/yHFnX1PYZXWHjYkDjvl+A+NE/Twf7RvjRBJ87loudbI67PG9Xf9t30LZytZIYIHoweuHWgb tdDrMcYf0+Kr/jhUAT6Fm6le3QdpVCqXFlztbZhDkMdmUQkNdm36nXHc8u6d84bLGPME= X-Gm-Gg: ATEYQzwGYGHOfPnN5ewYd6Xt7nM67WOpBcbmTuyIZggpz7gMFEAcKydtYsoYz+ifK/c 2Yy0+rNpUp5sWqp3jWttil2ot4SJBARK6uUb9oA7MppYHFam80J6RBtnWp1i4Y4ivCcd8BSCbnw EFKLmX7x2MvH2+1BZBnXZ5i9ITwSXOr0H3d7zOAWDVDZFuHkRUIyEt6q0pd89TXGd5dKk0pXmpt aEBVqpVlfcd0OTxtgPpM2nX2V4ASPowi+m6uwTcIeh9swmmn4Wqft9GfO3H/XFd+SxtnHZDOWVg v4gX/DKkTcSS+VmjzKKt1kL0vhd/OMLEByRv+ubcNms+3FZQdbb8T6GMEmM9xCeX9E7XyrYPWq+ SdtOl2+hwrT6J7iVkSbK5uad0LcR1biAGyIUA2MgSZekVWfxXzUsNlg== X-Received: by 2002:a05:6a00:4517:b0:82a:75d2:73c6 with SMTP id d2e1a72fcca58-82c869c5f49mr6718339b3a.18.1774679154221; Fri, 27 Mar 2026 23:25:54 -0700 (PDT) X-Received: by 2002:a05:6a00:4517:b0:82a:75d2:73c6 with SMTP id d2e1a72fcca58-82c869c5f49mr6718322b3a.18.1774679153709; Fri, 27 Mar 2026 23:25:53 -0700 (PDT) Received: from [10.0.0.3] ([106.222.229.231]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca86307a5sm1071769b3a.60.2026.03.27.23.25.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2026 23:25:53 -0700 (PDT) Message-ID: <3fe34754-e691-9fd9-7fab-1c81f98ef534@oss.qualcomm.com> Date: Sat, 28 Mar 2026 11:55:49 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v10 11/11] media: qcom: iris: extract firmware description data To: Dmitry Baryshkov , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260328-iris-platform-data-v10-0-46b92bfe7b52@oss.qualcomm.com> <20260328-iris-platform-data-v10-11-46b92bfe7b52@oss.qualcomm.com> Content-Language: en-US From: Dikshita Agarwal In-Reply-To: <20260328-iris-platform-data-v10-11-46b92bfe7b52@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=I8dohdgg c=1 sm=1 tr=0 ts=69c77473 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=n9i7a1ABM4vdrNuulSdbnA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=1XFNu35YfRq_e6hXo-gA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: 3FJ8pWdEr2DNIdX9TBDdgs7HGV79x2dr X-Proofpoint-ORIG-GUID: 3FJ8pWdEr2DNIdX9TBDdgs7HGV79x2dr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI4MDA0NCBTYWx0ZWRfXw6cF3fY6LV4X Dmvn87hnJv+7fS6gQ35yF/W3pdbJz+5qAEDoEFM4YIXxWSTKx5MjblR3hgxq3ndFOzvAChOqpIJ l0TRCN75U2qQGmeckvT2+uAFhwfQMBLjg/rtb93piUQWlKSa3aj2KC8lbRPiOplZL7A8yrB3Hor mtEqPUpW6naJJVVYcFB02VLDi7zhk1W4+pYAdVLRKFvVTcE8KYPWYgticCSr3sIxlHa/GXZqr05 /NffTPAlDYIWfjPpgE2d1x9HaC1c30rrP6qmknpFXCivhQYCayvSueHstNflFI3wL4hRClpuKiM F6knugKP6yEmbKxZ2bn+2n6pUJAr/47zRcXGC0UbqqE2XSGio9rWSlXcpGlu6hVKwar2wQc2gq+ yT/umaTxdTILOMGlpCepQ6twuwMO+IH91+o5tsLsWpfBfkn6poDQr6bq3GR/mW9ARY+l7NQQpmX TjwfQXEyTEG16/tszRA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-27_02,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603280044 On 3/28/2026 4:58 AM, Dmitry Baryshkov wrote: > In preparation to adding support for several firmware revisions to be > used for a platform, extract the firmware description data. It > incorporates firmware name, HFI ops and buffer requirements of the > particular firmware build. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_buffer.c | 2 +- > drivers/media/platform/qcom/iris/iris_core.h | 1 + > drivers/media/platform/qcom/iris/iris_firmware.c | 2 +- > .../platform/qcom/iris/iris_hfi_gen1_command.c | 2 +- > .../platform/qcom/iris/iris_platform_common.h | 15 ++++---- > .../media/platform/qcom/iris/iris_platform_vpu2.c | 20 +++++++---- > .../media/platform/qcom/iris/iris_platform_vpu3x.c | 41 +++++++++++++++------- > drivers/media/platform/qcom/iris/iris_probe.c | 3 +- > 8 files changed, 57 insertions(+), 29 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media/platform/qcom/iris/iris_buffer.c > index fbe136360aa1..ef7f6f931557 100644 > --- a/drivers/media/platform/qcom/iris/iris_buffer.c > +++ b/drivers/media/platform/qcom/iris/iris_buffer.c > @@ -295,7 +295,7 @@ static void iris_fill_internal_buf_info(struct iris_inst *inst, > { > struct iris_buffers *buffers = &inst->buffers[buffer_type]; > > - buffers->size = inst->core->iris_platform_data->get_vpu_buffer_size(inst, buffer_type); > + buffers->size = inst->core->iris_firmware_desc->get_vpu_buffer_size(inst, buffer_type); > buffers->min_count = iris_vpu_buf_count(inst, buffer_type); > } > > diff --git a/drivers/media/platform/qcom/iris/iris_core.h b/drivers/media/platform/qcom/iris/iris_core.h > index e0ca245c8c63..7f36eb65dcbf 100644 > --- a/drivers/media/platform/qcom/iris/iris_core.h > +++ b/drivers/media/platform/qcom/iris/iris_core.h > @@ -99,6 +99,7 @@ struct iris_core { > struct reset_control_bulk_data *controller_resets; > const struct iris_platform_data *iris_platform_data; > const struct iris_firmware_data *iris_firmware_data; > + const struct iris_firmware_desc *iris_firmware_desc; > const struct qcom_ubwc_cfg_data *ubwc_cfg; > enum iris_core_state state; > dma_addr_t iface_q_table_daddr; This is still missing the doc update I pointed out in v8/v9 as well. With that fixed, Reviewed-by: Dikshita Agarwal Thanks, Dikshita