From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86214411627 for ; Mon, 2 Mar 2026 15:45:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772466322; cv=none; b=iK5vWOMBKG/KqFH/AYymWs2+ros03Ck2IOX96IO8m2SJsAeDoOMapyGNY0eLNQYYfn6GKYQ5PPFs6ux0xLv1YE7lXC3wrR0B/0uXYGAFrQbCDTZ2cS5RI7ObDKww0QWt3bVF8gtLZFOUa1jvOpY2dzWHwiwT3JT8o5AYSToCs+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772466322; c=relaxed/simple; bh=5QhNWK08EnIEokCkgCGA5mBi02+mJGugJBhnyHtXRJg=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=bTK0rZOdROH4YXMqsOWBGrk1BROJK/w09qw6lhp7t+AloWBSW2bE1NFJvm1ja5pcrqojPY/bWaep22KArOzP5FNq5UBP2khfovYzWKlc7M9vkTjKef/NaWGTYCayHZb4WxVold1RPbHBwXFHBqtw9Z201y9lqAb0dS8EsZ1jp9A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EFKqLs7g; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EFKqLs7g" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4836f363ad2so55672395e9.1 for ; Mon, 02 Mar 2026 07:45:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772466319; x=1773071119; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=5QhNWK08EnIEokCkgCGA5mBi02+mJGugJBhnyHtXRJg=; b=EFKqLs7gzueURAcSG6xgDCVjGvmvQX8xBtfC/zfmbudG5XD416dfXZ21twGFao+voD Wbn7ENVu31uetcuc6OQBCz+ocJcbZU+lhekHFhXvdYaVV9Eu1t0T0vgOXRhz+Fc3zfLo iLzQ7NSl/dWkG6c8yF6pAhaiPv0vIsPAbi/jHFXQphKypiFv+LHEFWd8odtRZJALC2vh lSoI+ug/GwZ59iL0YRNo5IJBOEdPAmGquBOptWBqCWTA+QDPIo3ReNHGqbPizrKkgmK9 u5HxPUXPcsehRtFpagOuJnpihcL3K+jBu401cFd61WC+/yVLQHJQGK66lqRxDCndq0hn 0ZkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772466319; x=1773071119; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5QhNWK08EnIEokCkgCGA5mBi02+mJGugJBhnyHtXRJg=; b=r3P+YfJcQQl/FX9GCYntVQS79TZJO8BiLJHJDPQLTl4mPHksa+ZoYw2B3JdBnU9ANP wqeOaKYbTEJqRwJUF7JA4Q8zxweDAw2amm6GhwS5GdiuBxNzNlGe34qeyiVjLjgiqw/C gTAt0NZQfVrnCWjI/ndwb9/0t72X/HTR0mFww/uFvKOsOwP1EhiOQk24Sga1KrcdWAww zqvB8H/J1kwqKrZfbb8jlToIr+qlumGEmPoeV+2+f9P71FOO90BD8KuR72cMlLuF0pc4 +mV1PR804mluqh8vJ0dRmWQB6DKytaYglQWNr4i178FfJzzRB++aTwCHwVxB6lLg89Jy fXJA== X-Forwarded-Encrypted: i=1; AJvYcCXth+ycoolt4bArseomh+2iTYv7DtvlLXyqjvx4dXqlVtVi+FpizldTNHSSfiGvC+Hkv+mfQRLQ7uIIM0Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yz22casv7v+EvJ5X3UxkSOiaSZC9Iy6bn0dPixtDAJIsP9e37gx BCeDbuVDlP+IWkNEsGn+R3fM70KCPHkmebm8B3dhSaJEy+XvwlraJgdl X-Gm-Gg: ATEYQzwNHRJSA21LTkUYeR+8OeWcKAkfv/9PnjwUxYuzgoDrc4doYxPxthiu7e44WW4 I2bQJ3/TyZhhD0o+WpUuyKdTa2PV4w9ESx+jPp1seokpoANtc2im0gW7+rw5m3Mv2f1EShUVSpm ndyMh/lAqU1BXvLVKpRAGiE64Ul2o2VtnGKcJyHIZgC2hza9msQIpSJiRwxMVT5Ee3iYlrCnzvN r1i3Bd7rzTfY05zcgua8fwA0no1rYsSGeMIzSC5CZ4LC5MQFfdTqPpFtplS2Zq0zjfGikkq3u/z Hop8WJy8jAEbIkS5LWkG0RkFwoiVk6zSS1Ybbg0rqtdDMGBPbfGj846f9mcxx9YUvebiutxi22/ fDU0rDbZ1jqEDMahEuLzsdxZUuAc8WMgEJbG68R8aAzZ1G3CmGYBQsFydDuyz2f3qYYTuhgexbt Pql9ZMm6jqZwZvybw4 X-Received: by 2002:a05:600c:c490:b0:477:63b5:7148 with SMTP id 5b1f17b1804b1-483c9bb65ffmr188273145e9.6.1772466318382; Mon, 02 Mar 2026 07:45:18 -0800 (PST) Received: from [127.0.0.1] ([86.1.69.5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd6f2f88sm399613205e9.2.2026.03.02.07.45.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 07:45:18 -0800 (PST) Date: Mon, 2 Mar 2026 15:45:16 +0000 From: Josh Law To: Mark Rutland Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Josh Law Message-ID: <3fe578cc-07b3-442b-8eca-1f94c1975e85@gmail.com> In-Reply-To: References: <20260301003407.2493781-1-objecting@objecting.org> <20260301003407.2493781-4-objecting@objecting.org> Subject: Re: [PATCH 4/4] arm64: kernel: Fix style in io.c macro Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: <3fe578cc-07b3-442b-8eca-1f94c1975e85@gmail.com> 2 Mar 2026 14:51:19 Mark Rutland : > On Sun, Mar 01, 2026 at 12:34:07AM +0000, Josh Law wrote: >> Signed-off-by: Josh Law >> --- >> arch/arm64/kernel/io.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/kernel/io.c b/arch/arm64/kernel/io.c >> index fe86ada23c7d..ce27fa5d2e37 100644 >> --- a/arch/arm64/kernel/io.c >> +++ b/arch/arm64/kernel/io.c >> @@ -17,10 +17,10 @@ >> #define memcpy_toio_aligned(to, from, count, bits)=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ >> =C2=A0=C2=A0=C2=A0 ({=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 \ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 volatile u##bits __iomem *_to= =3D to;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 const u##bits *_from =3D from;=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 \ >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 const u##bits * _from =3D from;=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 \ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 size_t _count =3D count;=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 const u##bits *_end_from =3D _from= + ALIGN_DOWN(_count, 8); \ >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 const u##bits * _end_from =3D _fro= m + ALIGN_DOWN(_count, 8);\ >> +\ > > There is no style violation here. There's no need to add a space between > '*' and the variable name. > > Mark. I used checkpatch.pl... it detected that