From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E690933C514 for ; Wed, 17 Dec 2025 15:38:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765985888; cv=none; b=eo6oJbo3KSNEFK6c5qku6pCMD5UqSLLpGBY6AWk/eXafsuxVtwbMCSKhMNJci87SMqe+jR69NNIav/4/xYiN0uDWF7HzbljyUsMwfru1ybasGDDMgf+8L8hWa00KbW+15tcZrZa39PfO4RlGlx2kD9gX2kU5NhuUV4mEJi0oFyI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765985888; c=relaxed/simple; bh=UvBuPBraSuScNykRm41cie8KTLLTw5EcbxldAifHsNs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AWPxJqn8X+DhwCq/7MoQalY1AtAQPr3ZFFCsd9HxHCqeFi+Ys/0tenxngi2OU93pg5aRsWH2LgFBRHzEPgYLS/kst72rGouR8OXiDPmKFbpb1Ym8XSPbJyvNWXYvkA959NM/OpK8M/LFwlsShhdNicmkoVh7wvdsmmVlmtieMWg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mgBpYQ1X; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aUAteGZP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mgBpYQ1X"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aUAteGZP" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BHEvTgt2720289 for ; Wed, 17 Dec 2025 15:38:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LSGrrMOZDftVyShltOugtueXWriebHKj74tTN0kr5LY=; b=mgBpYQ1XiiZopXy8 kiipgdIK+0akT+g+CVOwDxLiWK84Jt1lHt/sPGkwuJwaHcX6TfzqjluDd7QCVdKu LSR3MbtZoBOByVzg30z1+7x3ucO6gcKdVkQyO6fv0p3ea7omdrwYBt6AKF8lwt1o NJqR4pXkASkwBGnl9i3vMsTfdPh7pyJdMk6b3it2G2H6IAr+ZM2Hps8D/b9ofqlC 2ZMb2ZFVF31CcntujWm9GJ9NTE7og267Hk+SuQ3VKpbfgJvWxuV2I74x1NB4akZs PWyAMCc7ACCBTNM0Dh23Qk7J/DXiryP9ELPpbmFkmI09iByTCI1+8iJUFLCB7ilt ocjh1A== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3xr583y9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 15:38:03 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-7aa148105a2so5459169b3a.1 for ; Wed, 17 Dec 2025 07:38:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765985883; x=1766590683; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LSGrrMOZDftVyShltOugtueXWriebHKj74tTN0kr5LY=; b=aUAteGZPU2OaNZLzQpNvIo5xcp0m/oE3bVV1KQGwhbRDHhovzkgZJWp1phEjE774/W 0sqpME4ITs+lb1Qq9Y5QnWxaKH/Iw4cWegfXnM8yPOi3oeLsQj54k41f58K0vHWxwCd4 ynUqFBp8Bc6Ly+TKKszIGKThOG+DY6l1FnrTprEgqg+S9Ehu/rLDl0rs1toOZyxYcLY5 QzuBKDe9TtsjkXMzcVO40EiC8ewz0CMQke+Er+3wIzDuZHekU4AXQi0ZP2zBz4RDkvck AXYTp03VSlglrmzfoEgK5mN+5rsJcP1Ho2pr40VUN/FvYeQp4Nw0axMTLCajCeKh/YQQ JMow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765985883; x=1766590683; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LSGrrMOZDftVyShltOugtueXWriebHKj74tTN0kr5LY=; b=SC325m4u7jF9mH19hJI5v8/Q8EA0dXzM7tI8StjurIpsPp2X+oSJhNv3+n/94eyuKI jn6XokN54swDXJLp3/RpuMzml8zmrbztH+OcoLs87HywEMmDtlqGFBcL6JghoVC4V2n8 8uB6BE5+AESpOCfBCYO2iSsnf4Osb5REno57gujYS836No0TJrw/xLbtRDgp+YlpfWgN kwLeP5B4CzO6UO4b+fO8MKhX/5csm2mG7a3Qg6tD+5P0zWcaNewmDPXMpKyS80M+U4WI 1HcwowNSZZ8RZxPDHsXyEqcMEf0upP0cppPuAHaXcJ4oFHNf1C7mwGez6hqNPS/OnPJ+ sRKw== X-Forwarded-Encrypted: i=1; AJvYcCUGtLTlKXeEW0pIPBEsJle6pgQhWRbitwNo4GaZDIcgCEtC4GwQJHfPjApWDdF6aeI4TEKRfidnGO/Wu9Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxT7JLIfEeJ2COOAaqH7yr5SCU7+9h/zktKOkF4fYSTcHspISqb WpBVi/xWzFvZSM6NbU//BvD4YeLDfV/9MiRew5wC+l3E01sPBrawQPTJ/Tfaztfi9+XFOrMSGmi ibJQmjMLx1IlKDeDjrxefc/k06UKBAMONL+i8vRLILKUoPfKedQ7RT08Ub/gKlHxY/Is= X-Gm-Gg: AY/fxX6pfcJTXZHP6xvoaaEAypv6MRuX/NqLQmA4J/GoYreG87Z/CPLwMSC0sZQD81K S7ZKWW7Fkh3NvWSyd0zurpZd14lOihrBwplR21Ca4wP1pG4F6cbZrLW5iqN/T94VDBcAJDm0GOb WGx1Gmog3a8B/1R8dF9pk7jxKkuI/E1B/qmUjtAbBP6Etb9HcKF3sY+c7WW8bRYga14B7q2O4xU 0iINjaFg+ow2KpRzWytO9Gf2ybEIJTYYT16QsbuTz8D/yKWtHygIBGpbXabk9IMn4tldTJG5bzg vFgE6N1v8nKGEYunWReuXLUuNINC02Es2LCbqdS9j6JR0naq6r1O1KqAFl6YCsdy5gvO7RUZOue 2F8wBTlQ3sMgjnM+xl7Eq8n1Tp2G16Qlk6h0wnMqI4mFotIB4ZnwpgNVTA9FeOm0fxifITA== X-Received: by 2002:a05:701a:ca0d:b0:119:e55a:9bff with SMTP id a92af1059eb24-11f34c4ef22mr12350780c88.27.1765985882633; Wed, 17 Dec 2025 07:38:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IHuYhQhTKxvcnoRTBpYREH3wuizCXsyRtb+/Rc7v++l/oc6Rv3Gfgj3rgD5AsJzw2v+k2058A== X-Received: by 2002:a05:701a:ca0d:b0:119:e55a:9bff with SMTP id a92af1059eb24-11f34c4ef22mr12350751c88.27.1765985882084; Wed, 17 Dec 2025 07:38:02 -0800 (PST) Received: from [10.227.110.203] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11f2e1bb3b4sm62197815c88.4.2025.12.17.07.38.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Dec 2025 07:38:01 -0800 (PST) Message-ID: <3fe689f9-c434-4c3c-a8cf-0b8ab65153c2@oss.qualcomm.com> Date: Wed, 17 Dec 2025 07:38:00 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] rtl8723bs: Add kernel-doc comment for rtw_reset_continual_io_error in rtw_io.c To: cjz , linux-staging@vger.kernel.org Cc: gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jeff Johnson Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: KGwWr4g1bmwMEOpXmmnH__zKdFYdifRH X-Authority-Analysis: v=2.4 cv=DsBbOW/+ c=1 sm=1 tr=0 ts=6942ce5b cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=dZbOZ2KzAAAA:8 a=o4_jF1gwsiqNhuO3VYgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=D0TqAXdIGyEA:10 a=xa8LZTUigIcA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDEyMyBTYWx0ZWRfX/hmVTqPm6S06 hcDE3NGWwWzNPacrIZtUBPoohgUXgADDTJ0GkmJNumtRW3UK23Gg9WLnRZ5YveZ70lVASH4HsRv jkoFBjaNI96ZztV7FZHKItitNM5bOhyRH8Siljh0bHzuhANLpdRzEu2lFEo3/viI8/W5n7qv5eB gA0XevbaCM6NXQQUBVzp9zkhWp0KKEuz9EHwa+PUeO11iNiEpE/FqYFeMTbUhXi7cI+o6GWrrNY xmbQidslFl82O3Lf7FUdfwxgyI+6zlCd637Cb9EbKjqhg8sllEKnTRajL66ZAieKXEk7ZvZgyun qVNx8TxDAKuSyZ7+UdCSfBNi/EQUNAiJ8UH2NJco/tRBjKo88KBolTUU2qo4DQM4NRpPjedVJGS dlZDu/kAxplf9xdk6JpF8gBApnwIJQ== X-Proofpoint-ORIG-GUID: KGwWr4g1bmwMEOpXmmnH__zKdFYdifRH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_03,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 impostorscore=0 spamscore=0 adultscore=0 clxscore=1015 bulkscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170123 On 12/13/2025 10:16 PM, cjz wrote: > From: changjunzheng > > rtw_reset_continual_io_error lacks a standard kernel-doc comment and has an incorrect > parameter name (dvobjprive vs dvobj) in the existing comment, which causes gcc W=1 > warning and reduces code readability. > > This change replaces the non-standard comment with a complete English kernel-doc comment, > fixes the parameter name error, and keeps all functional logic unchanged. In addition to Greg's comment, please also review: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes In particular: Describe your changes in imperative mood, e.g. “make xyzzy do frotz” instead of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy to do frotz”, as if you are giving orders to the codebase to change its behaviour.