From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15B433B6373 for ; Fri, 13 Mar 2026 20:59:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773435562; cv=none; b=hc7y1d+4J3vvfgQEnImwTn8GKTv+wYk0gJC8/ahISDeZ8hpVsoXlK2dPHAFBbS15FePCpcmCYX9wfSSG2L3RGBrUwyaHNNDhtQN8UHw5AWKlUF+0ocHMDOd9IZKnLQUIH3gJrKb7QuCXaCe5OKwAYVAs/Ln533N9VtBcK3oLfw0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773435562; c=relaxed/simple; bh=Ivlddc2eARAnXq/aGTDnV4sw6/07YD/TnzvDTxxlw1o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p6ga9UhQ6GaxA3nQW3Bf0umZfFyGVMsG2YNEMP01tpl9uCw1DsT0TlfB377jmVwTyH08kKL155zODzXV238OwqCFWlr5Tzy/Fv2G8Y08J84ptsP/jPNiw4bZUhauVH5YJnN+RjtlgDQw6WhVbZ85QaOnRSCbHgJEyAOe3uehj3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=VJ4F/OW2; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="VJ4F/OW2" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MTPibdSt4cFTmjVaH/wPcfOT83c1WtdF7A6cG2qap5k=; b=VJ4F/OW2/PXEXkmbHm8/aDfZjW E1fQBQr3L0QaPFJGxZYUu8FoU+UWGJ5BrGgsECLVOiDDrkVkFFJg4kUs3CH5BpeSTbuY9Cd0n6a24 rH2wr9+Q+cuwLLD/UnuNPpNYemcOuQDdefAQYYiGe8VpoJoCl80xHnt+3gruwoAa2Ds4+6qkK+8vp FlTEAefoCLaZFsLGbxCDCDGKgOmufZ3xgxhKYSQ8/0imPu9H4fNOA6qAWJsUtcRAyAA69NK6Mavm1 IRiZ1x40byEPbRDdW1AFac2XieeZmfzq5xYKiEBRfCEcVhVI3GEqNH5NORWUQkoRCZkROJ4+Us1ms xX+gGaoA==; Received: from [179.93.15.111] (helo=[192.168.1.54]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1w19bF-00FR99-3l; Fri, 13 Mar 2026 21:59:13 +0100 Message-ID: <3fe8232d-f563-7e02-ee83-3535e88e2f7a@igalia.com> Date: Fri, 13 Mar 2026 17:59:09 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH V2 1/2] mm/memblock: Print out errors on reserve_mem parser Content-Language: en-US To: SeongJae Park Cc: linux-mm@kvack.org, rppt@kernel.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, Andrew Morton , Steven Rostedt References: <20260305011429.79193-1-sj@kernel.org> From: "Guilherme G. Piccoli" In-Reply-To: <20260305011429.79193-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 04/03/2026 22:14, SeongJae Park wrote: > On Wed, 4 Mar 2026 17:14:10 -0300 "Guilherme G. Piccoli" wrote: > >> The parsing of kernel parameter "reserve_mem=" is subject to >> multiple failures, like duplicate naming, malformed expression >> or even lack of available memory. Right now, all of these fail >> silently. Let's add some messages so the kernel log can provide >> useful information in case of failures. > > Makes sense to me. > >> >> Cc: Andrew Morton >> Cc: Mike Rapoport >> Cc: Steven Rostedt >> Signed-off-by: Guilherme G. Piccoli > > Reviewed-by: SeongJae Park > Hi SJ! thanks a lot for the review, I'll resubmit with your tag and fixing the unnecessary blank line. Cheers, Guilherme