From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E62F717FD for ; Wed, 10 Jul 2024 09:59:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720605595; cv=none; b=MlkSKVGZMz3i7Seir17bvPX1pAnQ2KCX90KCd7lgMh0LslIr2AJxun/Q126hro7B0R7v1xYzLxPW5cA+8rrMapowd4K1ihlg4qNgQNa9lm+ZVomK/6mURzyU5+Pwb8t1S4BC48vc5uPPSqtnOWVJ2by4Ovl9o3taL0xoYKAWFxk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720605595; c=relaxed/simple; bh=ZkE1bV+5dqKs9zBEfCKHUdeXbA/g6X79LkJPlrpjd8Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mv+EStquYVdY5s5BN+5EafgYTnil1gsr8lUXtT6O8CpwVWaB3UuUII5dNKq2Gl68VHwjsSWOPzXZcNZ5qwdf+khvO2UYr8zc3U/+pV4FpcOGIMQoE4jPQJt7GxBMwFVLVyPnYcvXe53kfHk/13G+wPZ5Uo/2ZAvN9cCitizk+Q0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=g3KMveok; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="g3KMveok" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720605592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LLxyb06M9OF7tGSK1sebYwuTJMPMxYQY3JflFoHNWPk=; b=g3KMveok1SvIIss6J9oDnrozjkvCVNnyzGo/4pS53CqdWmJnxlCRT622xd7u2MVplhCMDf FTh4tMQXks7TRy85xMgryL4bcTJ4ru/nuN9x1wDMNLPBMSAXoJN4VGqg6cGoyDcF5KifRp HbJyZFM+rA7SvoGo6EFHYKuzpJGq2tY= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-155-UhVcaFKGNI2vXDaO7dFbPg-1; Wed, 10 Jul 2024 05:59:51 -0400 X-MC-Unique: UhVcaFKGNI2vXDaO7dFbPg-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a77c9c6bdadso373444166b.2 for ; Wed, 10 Jul 2024 02:59:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720605590; x=1721210390; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LLxyb06M9OF7tGSK1sebYwuTJMPMxYQY3JflFoHNWPk=; b=BJKa0bGXdUG+Z5+SN/0f9xaRzgFZaOto8jNj6gZTtxRDkA/6Dyb11y1FpYOKybMlZE Q39nOyX3GeRErYHJ83tgXkd4vMT6J270sTROlvyL6iOvm5ZVO+bK9VlXwoxr2MLWblcq dukSXyDtxlFURzCuqRoKa0d/Z2tEWZ2Re+lgm0ixZfEalem5fhX2HYOpQViJe4BOvdmP yOsNypdGIGNhqxOP7GK4oYqU2JpZOtHSod9jFheWjE9DvSYTtP3icDwJv42E/RDEGcGd 1rd/9bt8C07L80QWf1BjKmGiYha9gIu39/GFj9psY93NCZq5aVlVGuZcLULBsaeudkXa 76Lw== X-Gm-Message-State: AOJu0Yxo41MbbqRdvUsTXT4MB2aVdnh0h0Rs8Coz0dppcv+9fG3iqZJZ sAV6C5qUUXeCsuaFuUclZtCy1HQwHqK22vkCuR5IzNGcGlN+25/AAO8KFloKLHwhWPi/SH16AER s82i07kJWaqADSQCo6lbrCyxKUNkSGQKoPYu9OPlZXkPfkZCAoxP+aBElhcO+wA== X-Received: by 2002:a17:907:2d2b:b0:a75:2d52:8ca8 with SMTP id a640c23a62f3a-a780b89f457mr432508766b.75.1720605590295; Wed, 10 Jul 2024 02:59:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHOVv5tjV+ZXhGBNceewPQ0SKgmJuebVyZTWcQNIYlT/xWngzHd590SoEr9Bq/atGdH5wEU1A== X-Received: by 2002:a17:907:2d2b:b0:a75:2d52:8ca8 with SMTP id a640c23a62f3a-a780b89f457mr432506866b.75.1720605589935; Wed, 10 Jul 2024 02:59:49 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a780a6dfa84sm146172166b.63.2024.07.10.02.59.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jul 2024 02:59:49 -0700 (PDT) Message-ID: <3fece177-f6b4-41e4-a781-7c4c923ff7d9@redhat.com> Date: Wed, 10 Jul 2024 11:59:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH AUTOSEL 6.1 23/29] Input: silead - Always support 10 fingers To: Pavel Machek , Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Dmitry Torokhov , linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20240618124018.3303162-1-sashal@kernel.org> <20240618124018.3303162-23-sashal@kernel.org> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Pavel, On 7/10/24 11:58 AM, Pavel Machek wrote: > Hi! > >> From: Hans de Goede >> >> [ Upstream commit 38a38f5a36da9820680d413972cb733349400532 ] >> >> When support for Silead touchscreens was orginal added some touchscreens >> with older firmware versions only supported 5 fingers and this was made >> the default requiring the setting of a "silead,max-fingers=10" uint32 >> device-property for all touchscreen models which do support 10 fingers. >> >> There are very few models with the old 5 finger fw, so in practice the >> setting of the "silead,max-fingers=10" is boilerplate which needs to >> be copy and pasted to every touchscreen config. >> >> Reporting that 10 fingers are supported on devices which only support >> 5 fingers doesn't cause any problems for userspace in practice, since >> at max 4 finger gestures are supported anyways. Drop the max_fingers >> configuration and simply always assume 10 fingers. > > This does not fix a serious bug, should not be in stable. This patch is necessary for clean backporting of new DMI quirks added to drivers/platform/x86/touchscreen_dmi.c, so IMHO it does make sense as a stable series patch. Regards, Hans