From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753360AbdLMPpV (ORCPT <rfc822;w@1wt.eu>);
        Wed, 13 Dec 2017 10:45:21 -0500
Received: from fllnx209.ext.ti.com ([198.47.19.16]:35423 "EHLO
        fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752860AbdLMPpU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Dec 2017 10:45:20 -0500
Subject: Re: [PATCH 01/10] ASoC: tlv320aic32x4: Remove filename from header
 and switch to SPDX
To: Joe Perches <joe@perches.com>, Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>
CC: <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
References: <20171212224311.24045-1-afd@ti.com>
 <1513131575.3036.67.camel@perches.com>
From: "Andrew F. Davis" <afd@ti.com>
Message-ID: <3ff091f8-1366-ab38-dd7b-2633e6f3dd80@ti.com>
Date: Wed, 13 Dec 2017 09:44:17 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1513131575.3036.67.camel@perches.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/12/2017 08:19 PM, Joe Perches wrote:
> On Tue, 2017-12-12 at 16:43 -0600, Andrew F. Davis wrote:
>> The filename is often wrong after moves and adds nothing of value,
>> lets drop it. While already here, switch to SPDX.
> []
>> diff --git a/sound/soc/codecs/tlv320aic32x4-i2c.c b/sound/soc/codecs/tlv320aic32x4-i2c.c
> []
>> @@ -1,21 +1,10 @@
>> +// SPDX-License-Identifier: GPL-2.0
>>  /*
>> - * linux/sound/soc/codecs/tlv320aic32x4-i2c.c
>> - *
>>   * Copyright 2011 NW Digital Radio
>>   *
>>   * Author: Jeremy McDermond <nh6z@nh6z.net>
>>   *
>>   * Based on sound/soc/codecs/wm8974 and TI driver for kernel 2.6.27.
>> - *
>> - * This program is free software; you can redistribute it and/or modify
>> - * it under the terms of the GNU General Public License as published by
>> - * the Free Software Foundation; either version 2 of the License, or
>> - * (at your option) any later version.
>> - *
>> - * This program is distributed in the hope that it will be useful,
>> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> - * GNU General Public License for more details.
> 
> nack.  Note the "(at your option) any later version"
> 
> If you are going to update to spdx and remove the old license
> verbiage, make sure you are adding the correct spdx tag.
> 

My bad, will fix.

By the way, do you like these spdx update patch? Or would you rather I
drop this one and wait to let some script do it for the whole subsystem?