mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: Peter Zijlstra <peterz@infradead.org>, Greg KH <greg@kroah.com>
Cc: stable@vger.kernel.org, x86@kernel.org,
	linux-kernel@vger.kernel.org, corbet@lwn.net,
	kernel-dev@igalia.com, kernel@gpiccoli.net, fenghua.yu@intel.com,
	joshua@froggi.es, pgofman@codeweavers.com, pavel@denx.de,
	pgriffais@valvesoftware.com, zfigura@codeweavers.com,
	cristian.ciocaltea@collabora.com,
	Thomas Gleixner <tglx@linutronix.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Tony Luck <tony.luck@intel.com>,
	Andre Almeida <andrealmeid@igalia.com>
Subject: Re: [PATCH 6.0.y / 6.1.y] x86/split_lock: Add sysctl to control the misery mode
Date: Mon, 19 Dec 2022 09:48:18 -0300	[thread overview]
Message-ID: <3ff9f56c-479b-2dbd-9ee6-c7d00c7bd285@igalia.com> (raw)
In-Reply-To: <Y6BD9W7hk4CjhSdh@hirez.programming.kicks-ass.net>

On 19/12/2022 07:59, Peter Zijlstra wrote:
> On Mon, Dec 19, 2022 at 11:17:39AM +0100, Greg KH wrote:
> 
>> What specific programs have this problem and what are the exact results
>> of it?
> 
> IIRC it was God of War (2018) that triggered this initially. But it's
> possible more games were found to tickle this specific thing. Since it's
> binary only gunk that is unlikely to ever get fixed we need something to
> allow for it.
> 
> (slow motion Kratos yelling B...o...y...)
> 
>> Also, this is really a new feature and not really a "fix", but one could
>> argue a lot that this is a "resolve a performance problem" if you want
>> to and have the numbers to back it up  {hint}
> 
> Right, there were some, they should indeed have been included.

Thanks Peter, that's exactly it - the current report is linked on commit
message.

About performance numbers, the only "numbers" I have is: game is
unplayable, according to the report "When I launch God of War through
Steam or Lutris I get around 25 fps, on lowest settings and at 10%
resolution scaling", FPS for for games is double of that usually.

I understand this is not a regular fix in which something is completely
broken, but it does fix a behavior introduced on kernel that prevent
some userspace binaries to properly run, in practice. Ofc some will
argue that we already have the kernel parameter, but it's different -
requires reboot and bootloader understanding.

If 6.0.y is too much, I'd ask we have it at least for 6.1, which is
long-term, that will help a lot of people for sure.
Thanks,


Guilherme

  reply	other threads:[~2022-12-19 12:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-18 23:44 Guilherme G. Piccoli
2022-12-19 10:17 ` Greg KH
2022-12-19 10:59   ` Peter Zijlstra
2022-12-19 12:48     ` Guilherme G. Piccoli [this message]
2023-03-29 17:14       ` Sean Christopherson
2023-03-29 17:43         ` stsp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ff9f56c-479b-2dbd-9ee6-c7d00c7bd285@igalia.com \
    --to=gpiccoli@igalia.com \
    --cc=andrealmeid@igalia.com \
    --cc=corbet@lwn.net \
    --cc=cristian.ciocaltea@collabora.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=greg@kroah.com \
    --cc=joshua@froggi.es \
    --cc=kernel-dev@igalia.com \
    --cc=kernel@gpiccoli.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@denx.de \
    --cc=peterz@infradead.org \
    --cc=pgofman@codeweavers.com \
    --cc=pgriffais@valvesoftware.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=zfigura@codeweavers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®