From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAD9CCE79AD for ; Wed, 20 Sep 2023 07:56:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233621AbjITH4b (ORCPT ); Wed, 20 Sep 2023 03:56:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233802AbjITH4I (ORCPT ); Wed, 20 Sep 2023 03:56:08 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7899CCE for ; Wed, 20 Sep 2023 00:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695196555; x=1726732555; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=PMdqRxGvUvcQLS6EMGIpghBZ2plKJ6T+R8ospUk7Ykc=; b=LezoSUfLrYEcrAhyauetVjIHsErNNhYDIHO9Uc5kSO/UKPiyE8yYidWP 8PV4s2N/42dgOqansrf1yjWvyqPhfP3UamohcISmzVZlYpUbvXkxtxFNW qXXvMQwBHU/y0c9+8djPr98WQZgnbBCFT6IbCjWN2FJsB1iFLLzkBkrul j34PSnoUlWjgJWUZ/mIAVqWoTr4mB5vo0kmyqmq3w6S2TgsafQcfeR0Ye M5VGVGzoKbgKzfNk19vFIY6uMVdi7APr1Ahb69hFuTlG0zd7fJkl8Exjh me0wWFUOsw73jG+YUO7qW0uQS5Jl4J/z8Th9dAx7X3o0G+o5EbRuUfsd3 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="384001915" X-IronPort-AV: E=Sophos;i="6.02,161,1688454000"; d="scan'208";a="384001915" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2023 00:55:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="1077330435" X-IronPort-AV: E=Sophos;i="6.02,161,1688454000"; d="scan'208";a="1077330435" Received: from jiaxu2-mobl.ccr.corp.intel.com (HELO [10.93.21.134]) ([10.93.21.134]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2023 00:55:48 -0700 Message-ID: <3ffa081d-2711-6fb7-9861-4e6494a44591@intel.com> Date: Wed, 20 Sep 2023 15:55:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.15.1 Subject: Re: [virtio-dev] Re: [virtio-comment] Re: [VIRTIO PCI PATCH v5 1/1] transport-pci: Add freeze_mode to virtio_pci_common_cfg Content-Language: en-US To: Parav Pandit , "Chen, Jiqian" , "Michael S. Tsirkin" Cc: Gerd Hoffmann , Jason Wang , Xuan Zhuo , David Airlie , Gurchetan Singh , Chia-I Wu , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Robert Beckett , Mikhail Golubev-Ciuchea , "virtio-comment@lists.oasis-open.org" , "virtio-dev@lists.oasis-open.org" , "qemu-devel@nongnu.org" , "linux-kernel@vger.kernel.org" , Stefano Stabellini , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "Deucher, Alexander" , "Koenig, Christian" , "Hildebrand, Stewart" , Xenia Ragiadakou , "Huang, Honglei1" , "Zhang, Julia" , "Huang, Ray" References: <20230919114242.2283646-1-Jiqian.Chen@amd.com> <20230919114242.2283646-2-Jiqian.Chen@amd.com> <20230919082802-mutt-send-email-mst@kernel.org> <701bb67c-c52d-4eb3-a6ed-f73bd5d0ff33@intel.com> <40765650-ba6e-357a-cf73-ff6a0288c0e8@intel.com> From: "Zhu, Lingshan" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/20/2023 3:51 PM, Parav Pandit wrote: >> From: Zhu, Lingshan >> Sent: Wednesday, September 20, 2023 1:17 PM >>> This is not live or device migration. This is restoring the device context >> initiated by the driver owning the device. >> restore the device context should be done by the hypervisor before setting >> DRIVER_OK and waking up the guest, not a concern here, out of spec > The framework is generic for the PCI devices hence, there may not be any hypervisor at all. Hence restore operation to trigger on DRIVER_OK setting, when previously suspended. > > Since we already agree in previous email that re-read until device sets the DRIVER_OK, its fine to me. It covers the above restore condition. OK > > Thanks. >