From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f33.google.com (mail-wr2-f33.google.com [74.125.225.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21D7039022A for ; Fri, 2 Oct 2026 12:32:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.97 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790944325; cv=none; b=HdFFFdGQHzovRM3eydpOm+Mtp892IP+t8Ls1PVsA5pyxliWiva2GItF0nwekpqrz5g2TOFpvITYuTqtAQz/AaaV6S2wYlgabI+QcmKsBb2FgJcZe8scNzJOmS07ZRG42hQ75a1FIj2H7/2eW5G0Z3UdvsS6SkCSSXQd7pBPU/wk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790944325; c=relaxed/simple; bh=K2WLOvCouWwizZY/0nd5slNgHbO26Xtg/oTPG00nO+E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DrODk0/ZO4VpU5bZhsdelQMAoHHf0rVC9Jyp0MQyBwTVTciE4NKAdcuSD8NyzV5oPyil5a3c5dXlFjkYytDMRSOPP9dj0pBLZKxytDgvabBtqgCU38jcZIcMiaoMwmc++H1/7U+twqNHL3oi0/422/PU8BlV1nCHuzhu+mGtFtM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=bqSlEv+E; arc=none smtp.client-ip=74.125.225.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="bqSlEv+E" Received: by mail-wr2-f33.google.com with SMTP id ffacd0b85a97d-48b024549a2so2319560f8f.3 for ; Fri, 02 Oct 2026 05:32:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1790944322; x=1791549122; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=/phs7jHum1HKMD5+n/ngyLXVbU8kytKeDWtVqYb5TKY=; b=bqSlEv+E3hyuHH/+48TYBiBuUPJG338zAH8I7DMAxOHktZiVfrw4D9gitpQAtKOzvq /1ysrcpo6yLdoDayloh3G+03FzSxgNHOeXmUps6H9kReNufCq0M+dWRBa2cXkthprQ4K h6ARV0zHXdh3EMOzTqIzxPRUCJauRGofJ44lcGihIyZS3rW1nMqZ1PPUf47TAdC32Sqz 1rfTj8s47AnrrAi6uOlYQ2FFBNptUpQj+qfKovMa7CZ7DWmFZK6h4+gy6Zii9BhBMyq1 N5dv8bcURxHhzwL/fAWzEyUFpZbZ+9WPiUkROMDejkNRD3L1Pum/D5Ugpl4RBSuG3xa9 W92g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790944322; x=1791549122; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=/phs7jHum1HKMD5+n/ngyLXVbU8kytKeDWtVqYb5TKY=; b=WFONRQb9VTSPsSIGzbbZbMYP1XKc7yPkmMjAJ8tR3wcssp6hZeCDYABlfBxLmn2lpn OzxMoHcJ1w4uLC6g/0M9PA/KzM1xNqzZumVsSbf/9XaSDvQBXdmoyoJMgZ967fRf8vi8 UGG6XeFq5P9Ol1tiYauLrJC/0azFLOMLQIIuMarSHFNwZPBte2TTg+TlrfjXbhllWGMh S6ydq7bACiFpZqa7MtbSoz35jewiCPULj+a6LESo1no0EGUx8HCqpy9CTH64eNbq7ogF tHMegaOIzaRbFhqb2YP7Rvo2NFvzXguLlUqd3T7R0TjwddxhFY5zXJDAzurP2yW4LMJd KTNA== X-Forwarded-Encrypted: i=1; AKwUvBzGzv7vAI44CtoDRPAk9Akc4Q5aW2mlCcnuIRRepeV5oTyAUKTnOKVsHxZjpMkPOZ2nqw7hCf7tj+Ayyvo=@vger.kernel.org X-Gm-Message-State: AFq9FYI4ZN7Qx9VaVsAgbIU4blUJSKAOIym6z6yY4DM2v8yv6pXjwVSu +W3bX4RESmP7A5yVJogzI1djnXf3NUHvrH0ljSwJJbR4e30pfnOxfcjWjyu4enu1Y/Q= X-Gm-Gg: AYBFou1jjRNH9QAp+RijZoIthI7Dnxe5qxFOrJNNwxUrSqPKkMViqrzVsBU2zJmiey5 Q6XkJughPk7i+bWZkxhnsChwbHPwo1mFUnUOehPSIf2Z8sRLRpujCzjpJnMGqr2jdvA0vFXIGh5 UfujRLErcBZz2G9tUlFtbXOx1PY1omDmeYJhrj3BVo8lL0VLRl8iiP9CXjlx3jYriyDFCK8kMsk qm8qcTSVjSEU0hjQTs6u9Gaca2CBL/i+dusflFOKiA7pQ/qpv1dl8SPyvTzMeDI2G9/cpEwKF1z D1eiRkTjeGVFq8zLLjd7+WHaFSRGT4669368f9SORJBxvW/MLtnZSKK8PHE3uYT8+0oOw79WKD3 4T/Vp2w24ZMs1fZim1LrHRRZEciFMV8YBeO0ohtoh9FS2BL9zUL4xOBRMcrdD4rNrfxBdFk4jVV qd5iEiCZJIPqXDKoGnSOaJpbiQmmK/WMPTujy6wg9eizb/GVNMNGtUitBBzbsf6c+Mfzob8C4JI k6fCL42cXBVNjXCtJTB+x0= X-Received: by 2002:a05:6000:654:b0:488:8da2:4b16 with SMTP id ffacd0b85a97d-48b126f60ffmr4313323f8f.8.1790944322362; Fri, 02 Oct 2026 05:32:02 -0700 (PDT) Received: from [192.168.0.20] (nborisov.ddns.nbis.net. [185.218.66.243]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48b380fad53sm6093994f8f.19.2026.10.02.05.32.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Oct 2026 05:32:02 -0700 (PDT) Message-ID: <3fffdf68-f2b0-42e2-a3a9-024cfa483760@suse.com> Date: Fri, 2 Oct 2026 15:32:00 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/10] x86/virt/tdx: Convert the td_conf metadata reader To: Chao Gao , "Edgecombe, Rick P" Cc: "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "bp@alien8.de" , "kas@kernel.org" , "binbin.wu@linux.intel.com" , "dave.hansen@linux.intel.com" , "mingo@redhat.com" , "tony.lindgren@linux.intel.com" , "tglx@kernel.org" , "hpa@zytor.com" , "x86@kernel.org" , "yilun.xu@linux.intel.com" References: <20260930053901.22528-1-chao.gao@intel.com> <20260930053901.22528-8-chao.gao@intel.com> <763dcf982570e0ffcc69a6e1922fd2cc266539aa.camel@intel.com> <48ed6f1bd588c6ccab398c5310fb1fc073c1e53d.camel@intel.com> From: Nikolay Borisov Content-Language: en-US Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2.10.26 г. 15:28 ч., Chao Gao wrote: > On Fri, Oct 02, 2026 at 04:28:54AM +0800, Edgecombe, Rick P wrote: >> On Thu, 2026-10-01 at 19:34 +0300, Nikolay Borisov wrote: >>>> The comments are not strictly required, but probably fit into turning this >>>> thing >>>> into "hand coding". I think it's a nice addition. I wonder if we should make >>>> the >>>> "i * 2 + j" a bit clearer though? >>>> >>>> I'm not against leaving it as is for now. It helps that it doesn't morph too >>>> much from the code getting moved. But I think the above falls a bit short of >>>> hand coded quality. >>> >>> Perhaps this code warrants open coding? The code will end up looking >>> like config_values[i][0] ... config_values[i][1] .... >> >> Yea that would be a good way to improve it. > > Yes. With one less level of indentation, all three reads get the same > shape. I ended up with: > > /* > * cpuid_config_leaves[i] holds a CPUID leaf and sub-leaf number, > * and the two u64s of cpuid_config_values[i] mark which bits of > * that leaf's EAX/EBX/ECX/EDX the host can set to 0 or 1 for a TD. > * > * TDX_FIELD_CPUID_CONFIG_LEAVES and TDX_FIELD_CPUID_CONFIG_VALUES > * give the field ID of each array's first element, and the rest > * follow in order. > */ > for (i = 0; i < td_conf->num_cpuid_config; i++) { > ret = read_sys_metadata_field(TDX_FIELD_CPUID_CONFIG_LEAVES + i, > &td_conf->cpuid_config_leaves[i]); > if (ret) > return ret; > > ret = read_sys_metadata_field(TDX_FIELD_CPUID_CONFIG_VALUES + i * 2, > &td_conf->cpuid_config_values[i][0]); > if (ret) > return ret; nit: Is this more readable: int cpuid_config_val = TDX_FIELD_CPUID_CONFIG_VALUES + i * 2; read_sys_metadata_field(cpuid_config_val...) read_sys_metadata_field(cpuid_config_val+1...) > > ret = read_sys_metadata_field(TDX_FIELD_CPUID_CONFIG_VALUES + i * 2 + 1, > &td_conf->cpuid_config_values[i][1]); > if (ret) > return ret; > }