From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752760AbcEJVst (ORCPT ); Tue, 10 May 2016 17:48:49 -0400 Received: from ozlabs.org ([103.22.144.67]:52237 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751293AbcEJVsr (ORCPT ); Tue, 10 May 2016 17:48:47 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 03be7e53dee606c189a66a7389fecf870d1f3b9e In-Reply-To: <20160505204444.GE3264@csclub.uwaterloo.ca> To: Lennart Sorensen , linux-kernel@vger.kernel.org From: Michael Ellerman Cc: Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Len Sorensen Subject: Re: powerpc: Fix sstep compile on powerpcspe Message-Id: <3r4CYn2j81z9t4h@ozlabs.org> Date: Wed, 11 May 2016 07:48:45 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-05-05 at 20:44:44 UTC, Lennart Sorensen wrote: > powerpc: Fix sstep compile on powerpcspe > > Commit be96f63375a14ee8e690856ac77e579c75bd0bae introduced ldarx and stdcx > into the instructions in sstep.c, which are not accepted by the assembler > on powerpcspe, but does seem to be accepted by the normal powerpc assembler > even in 32 bit mode. > > Wrap these two instructions in a __powerpc64__ check like it is everywhere > else in the file. > > Fixes: be96f63375a1 ("powerpc: Split out instruction analysis part of emulate_step()") > Signed-off-by: Len Sorensen Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/03be7e53dee606c189a66a7389 cheers