From: Michael Ellerman <mpe@ellerman.id.au>
To: Boqun Feng <boqun.feng@gmail.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Boqun Feng <boqun.feng@gmail.com>,
Will Deacon <will.deacon@arm.com>, Alexander Graf <agraf@suse.de>,
Paul Mackerras <paulus@samba.org>,
"Suresh E. Warrier" <warrier@linux.vnet.ibm.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [v4] powerpc: spinlock: Fix spin_unlock_wait()
Date: Tue, 21 Jun 2016 10:40:54 +1000 (AEST) [thread overview]
Message-ID: <3rYTRV50CZz9t0w@ozlabs.org> (raw)
In-Reply-To: <20160610035128.21087-1-boqun.feng@gmail.com>
On Fri, 2016-10-06 at 03:51:28 UTC, Boqun Feng wrote:
> There is an ordering issue with spin_unlock_wait() on powerpc, because
> the spin_lock primitive is an ACQUIRE and an ACQUIRE is only ordering
> the load part of the operation with memory operations following it.
...
>
> Suggested-by: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
> Reviewed-by: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> [mpe: Inline the "nop" ll/sc loop and set EH=0, munge change log]
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/6262db7c088bbfc26480d10144
cheers
prev parent reply other threads:[~2016-06-21 0:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 3:51 [PATCH v4] " Boqun Feng
2016-06-21 0:40 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3rYTRV50CZz9t0w@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=agraf@suse.de \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=warrier@linux.vnet.ibm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®