From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932099AbcF3Mgn (ORCPT ); Thu, 30 Jun 2016 08:36:43 -0400 Received: from ozlabs.org ([103.22.144.67]:55021 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932067AbcF3Mgm (ORCPT ); Thu, 30 Jun 2016 08:36:42 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: d0226d315dba5e401a124b394a1af5e35e082b08 In-Reply-To: <1467171519-19882-2-git-send-email-sjitindarsingh@gmail.com> To: Suraj Jitindar Singh , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Cc: robh@kernel.org, arnd@arndb.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, paulus@samba.org, sjitindarsingh@gmail.com Subject: Re: [V5, 2/3] powerpc/opal: Add inline function to get rc from an ASYNC_COMP opal_msg Message-Id: <3rgJvD18wYz9t0V@ozlabs.org> Date: Thu, 30 Jun 2016 22:36:40 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-29-06 at 03:38:38 UTC, Suraj Jitindar Singh wrote: > An opal_msg of type OPAL_MSG_ASYNC_COMP contains the return code in the > params[1] struct member. However this isn't intuitive or obvious when > reading the code and requires that a user look at the skiboot > documentation or opal-api.h to verify this. > > Add an inline function to get the return code from an opal_msg and update > call sites accordingly. > > Signed-off-by: Suraj Jitindar Singh Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/d0226d315dba5e401a124b394a cheers