From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754989AbcGEOKT (ORCPT ); Tue, 5 Jul 2016 10:10:19 -0400 Received: from ozlabs.org ([103.22.144.67]:36344 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951AbcGEOKQ (ORCPT ); Tue, 5 Jul 2016 10:10:16 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: e2be23712a9c8e3710c9e2684a3204bd20c685d6 In-Reply-To: <1457472378-22274-1-git-send-email-linux@rasmusvillemoes.dk> To: Rasmus Villemoes , Benjamin Herrenschmidt , Paul Mackerras From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, Rasmus Villemoes , linux-kernel@vger.kernel.org Subject: Re: powerpc/pseries: fix error return value in cmm_mem_going_offline Message-Id: <3rkQkt2qMHz9t0T@ozlabs.org> Date: Wed, 6 Jul 2016 00:10:14 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-08-03 at 21:26:17 UTC, Rasmus Villemoes wrote: > cmm_mem_going_offline is (only) called from cmm_memory_cb(), which > sends the return value through notifier_from_errno(). The latter > expects 0 or -errno (notifier_to_errno(notifier_from_errno(x)) is 0 > for any x >= 0, so passing a positive value cannot make sense). Hence > negate ENOMEM. > > Signed-off-by: Rasmus Villemoes Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/e2be23712a9c8e3710c9e2684a cheers