From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932955AbcITNHY (ORCPT ); Tue, 20 Sep 2016 09:07:24 -0400 Received: from ozlabs.org ([103.22.144.67]:46397 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932124AbcITNHV (ORCPT ); Tue, 20 Sep 2016 09:07:21 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 0d0fecc5b5bfddb0e67bef985cdeda2eac7ad6d8 In-Reply-To: <5667FBD5.2050206@linux.vnet.ibm.com> To: xinhui , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org From: Michael Ellerman Cc: Andrzej Hajda , Christophe Jaillet , Nathan Fontenot , Hari Bathini , Paul Mackerras Subject: Re: powerpc/nvram: Fix a memory leak in err path Message-Id: <3sdjhl1yhFz9sQw@ozlabs.org> Date: Tue, 20 Sep 2016 23:07:19 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-09-12 at 10:00:53 UTC, xinhui wrote: > If kmemdup fails, We need kfree *buff* first then return -ENOMEM. > Otherwise there is a memory leak. > > Signed-off-by: Pan Xinhui > Reviewed-by: Nathan Fontenot Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/0d0fecc5b5bfddb0e67bef985c cheers