From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753713AbdBPF7s (ORCPT ); Thu, 16 Feb 2017 00:59:48 -0500 Received: from ozlabs.org ([103.22.144.67]:54553 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753439AbdBPF7r (ORCPT ); Thu, 16 Feb 2017 00:59:47 -0500 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: c21a493a2b44650707d06741601894329486f2ad In-Reply-To: <1479806759-5409-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> To: Ravi Bangoria From: Michael Ellerman Cc: peterz@infradead.org, linux-kernel@vger.kernel.org, npiggin@gmail.com, Ravi Bangoria , paulus@samba.org, naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org Subject: Re: powerpc/xmon: Fix data-breakpoint Message-Id: <3vP58d4wR4z9s8x@ozlabs.org> Date: Thu, 16 Feb 2017 16:59:45 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-11-22 at 09:25:59 UTC, Ravi Bangoria wrote: > Xmon data-breakpoint feature is broken. > > Whenever there is a watchpoint match occurs, hw_breakpoint_handler will > be called by do_break via notifier chains mechanism. If watchpoint is > registered by xmon, hw_breakpoint_handler won't find any associated > perf_event and returns immediately with NOTIFY_STOP. Similarly, do_break > also returns without notifying to xmon. > > Solve this by returning NOTIFY_DONE when hw_breakpoint_handler does not > find any perf_event associated with matched watchpoint. > > Signed-off-by: Ravi Bangoria Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/c21a493a2b44650707d06741601894 cheers